Foundry376/Mailspring
1
1
Fork 0
mirror of https://github.com/Foundry376/Mailspring.git synced 2024-09-22 00:06:06 +08:00
Code Issues Packages Projects Releases Wiki Activity
Mailspring/internal_packages
History
Ben Gotow 2e2ecf0647 fix(quoted-text): div vs blockquote, signature cleanup #1746 
Summary:
Previously we always created <blockquote class="gmail_quote"> to wrap quoted text. This is not correct.
Gmail uses blockquotes only when it wants visual indentation, and <div>s to wrap other quoted text, like forwarded
messages which are not displayed indented.

This diff updates N1 to match Gmail exactly. Note that for replies, Gmail actually nests a blockquote.gmail_quote
inside a div.gmail_quote.

I also updated signature handling because it turns out the regexp that was removing existing signatures would blow
away any and all divs until it reached a <blockquote> tag.

Test Plan: See updated specs. Manually tested by creating a thread in Google Inbox and then performing fwd and reply in both N1 and Inbox. Results match.

Reviewers: juan, evan

Reviewed By: evan

Differential Revision: https://phab.nylas.com/D2750
2016-03-17 13:11:00 -07:00
..
account-error-header fix(sync-errors): Handle account deltas indicating sync issues 2016-03-08 16:06:04 -08:00
account-sidebar fix(acct-menu): Add option to add account from context menu 2016-03-14 11:22:52 -07:00
attachments refactor(ui-variables): Clean UI variables for consistency/usage 2016-03-15 11:18:50 -07:00
category-picker fix(gmail-labels): Constraint so threads always belong to all,spam or trash 2016-03-10 14:13:31 -08:00
composer fix(quoted-text): div vs blockquote, signature cleanup #1746 2016-03-17 13:11:00 -07:00
composer-emoji sp(composer-emoji): Correct emojis to emoji 2016-03-15 13:37:54 -07:00
composer-signature fix(quoted-text): div vs blockquote, signature cleanup #1746 2016-03-17 13:11:00 -07:00
composer-spellcheck fix(syncback): Bidirectional transforms, ready-to-send saved state 2016-03-16 19:27:12 -07:00
composer-templates fix(quoted-text): div vs blockquote, signature cleanup #1746 2016-03-17 13:11:00 -07:00
composer-translate remove(popover): Remove Popover in favor of FixedPopover 2016-03-09 10:05:46 -08:00
events refactor(ui-variables): Clean UI variables for consistency/usage 2016-03-15 11:18:50 -07:00
github-contact-card fix(sidebar): minor sidebar style and padding tweaks 2016-03-10 15:06:59 -05:00
link-tracking fix(syncback): Bidirectional transforms, ready-to-send saved state 2016-03-16 19:27:12 -07:00
message-autoload-images fix(autoload-images): Bar disappears when you choose to load images 2016-03-07 18:19:17 -08:00
message-list refactor(ui-variables): Clean UI variables for consistency/usage 2016-03-15 11:18:50 -07:00
message-view-on-github fix(github): Correct minor issue during ES6 conversion 2016-03-10 14:31:50 -08:00
mode-switch 💄(sidebar): Replace icon with person 2016-03-10 11:15:52 -08:00
notification-mailto fix(license): GPLv3 => GPL-3.0 2015-12-07 10:50:47 -08:00
notification-update-available refactor(ui-variables): Clean UI variables for consistency/usage 2016-03-15 11:18:50 -07:00
notifications refactor(ui-variables): Clean UI variables for consistency/usage 2016-03-15 11:18:50 -07:00
onboarding fix(onboarding): We should accept IPs for servers during auth 2016-03-10 12:08:05 -08:00
open-tracking fix(syncback): Bidirectional transforms, ready-to-send saved state 2016-03-16 19:27:12 -07:00
participant-profile fix(sidebar): keep trying on 202s 2016-03-11 16:27:04 -05:00
personal-level-indicators es6(*): convert 20+ source files used in example packages to ES2016 2016-02-29 18:47:22 -08:00
phishing-detection Fixed text overflow in phishing detection indicator 2016-03-11 20:33:06 +01:00
plugins 🎨(plugins): Add theme-specific icon in plugins tab 2016-03-14 17:55:25 -07:00
preferences feat(view-mode): Add option in menu to select view mode 2016-03-15 11:20:55 -07:00
print 💄(print): Fix #1425 2016-02-26 14:40:16 -08:00
quick-schedule fix(quoted-text): div vs blockquote, signature cleanup #1746 2016-03-17 13:11:00 -07:00
screenshot-mode feat(screenshot-mode): Minor fix to unmount method 2016-01-29 16:59:51 -08:00
search-bar refactor(ui-variables): Clean UI variables for consistency/usage 2016-03-15 11:18:50 -07:00
send-and-archive fix(gmail-labels): Constraint so threads always belong to all,spam or trash 2016-03-10 14:13:31 -08:00
send-later fix(lint): Actions is defined but never used 2016-03-16 20:04:01 -07:00
sidebar-fullcontact feat(sidebar): Add thread list of currently selected participants 2016-03-09 14:33:31 -05:00
system-tray fix(focus): Show drafts in unfocused state when window is blurred 2016-03-15 12:12:30 -07:00
theme-picker fix(themes): Add quick fixes for Ubuntu 2016-03-11 11:02:02 -08:00
thread-list fix(syncback): Bidirectional transforms, ready-to-send saved state 2016-03-16 19:27:12 -07:00
thread-snooze fix(snooze): Correctly query and create snooze categories per account 2016-03-14 15:36:39 -07:00
ui-dark refactor(ui-variables): Clean UI variables for consistency/usage 2016-03-15 11:18:50 -07:00
ui-darkside using new toolbar selectors, svgs, etc. 2016-03-14 19:02:00 -05:00
ui-light feat(theme-selector): Add theme selector to preferences page 2015-12-15 10:29:58 -08:00
ui-taiga 🎨(theme-picker): Order internal themes and update theme names 2016-03-10 16:37:06 -08:00
ui-ubuntu refactor(ui-variables): Clean UI variables for consistency/usage 2016-03-15 11:18:50 -07:00
undo-redo fix(undo): Ensure undo bar dismisses after re-appearing 2016-02-05 19:11:27 -08:00
unread-notifications Revert "fix(sidebar): Correctly update sidebar when a notif is selected" 2016-02-02 10:58:24 -08:00
worker-sync fix(snooze): Correctly query and create snooze categories per account 2016-03-14 15:36:39 -07:00
worker-ui fix(syncback): Bidirectional transforms, ready-to-send saved state 2016-03-16 19:27:12 -07:00