Mailspring/spec/models/query-subscription-spec.es6
Evan Morikawa d1c587a01c fix(spec): add support for async specs and disable misbehaving ones
More spec fixes

replace process.nextTick with setTimeout(fn, 0) for specs

Also added an unspy in the afterEach

Temporarily disable specs

fix(spec): start fixing specs

Summary:
This is the WIP fix to our spec runner.

Several tests have been completely commented out that will require
substantially more work to fix. These have been added to our sprint
backlog.

Other tests have been fixed to update to new APIs or to deal with genuine
bugs that were introduced without our knowing!

The most common non-trivial change relates to observing the `NylasAPI` and
`NylasAPIRequest`. We used to observe the arguments to `makeRequest`.
Unfortunately `NylasAPIRequest.run` is argumentless. Instead you can do:
`NylasAPIRequest.prototype.run.mostRecentCall.object.options` to get the
`options` passed into the object. the `.object` property grabs the context
of the spy when it was last called.

Fixing these tests uncovered several concerning issues with our test
runner. I spent a while tracking down why our participant-text-field-spec
was failling every so often. I chose that spec because it was the first
spec to likely fail, thereby requiring looking at the least number of
preceding files. I tried binary searching, turning on and off, several
files beforehand only to realize that the failure rate was not determined
by a particular preceding test, but rather the existing and quantity of
preceding tests, AND the number of console.log statements I had. There is
some processor-dependent race condition going on that needs further
investigation.

I also discovered an issue with the file-download-spec. We were getting
errors about it accessing a file, which was very suspicious given the code
stubs out all fs access. This was caused due to a spec that called an
async function outside ot a `waitsForPromise` block or a `waitsFor` block.
The test completed, the spies were cleaned up, but the downstream async
chain was still running. By the time the async chain finished the runner
was already working on the next spec and the spies had been restored
(causing the real fs access to run).

Juan had an idea to kill the specs once one fails to prevent cascading
failures. I'll implement this in the next diff update

Test Plan: npm test

Reviewers: juan, halla, jackie

Differential Revision: https://phab.nylas.com/D3501

Disable other specs

Disable more broken specs

All specs turned off till passing state

Use async-safe versions of spec functions

Add async test spec

Remove unused package code

Remove canary spec
2016-12-15 13:02:00 -05:00

303 lines
12 KiB
JavaScript

import DatabaseStore from '../../src/flux/stores/database-store';
import QueryRange from '../../src/flux/models/query-range';
import MutableQueryResultSet from '../../src/flux/models/mutable-query-result-set';
import QuerySubscription from '../../src/flux/models/query-subscription';
import Thread from '../../src/flux/models/thread';
import Utils from '../../src/flux/models/utils';
describe("QuerySubscription", function QuerySubscriptionSpecs() {
describe("constructor", () =>
describe("when a query is provided", () => {
it("should finalize the query", () => {
const query = DatabaseStore.findAll(Thread);
const subscription = new QuerySubscription(query);
expect(subscription).toBeDefined();
expect(query._finalized).toBe(true);
});
it("should throw an exception if the query is a count query, which cannot be observed", () => {
const query = DatabaseStore.count(Thread);
expect(() => {
const subscription = new QuerySubscription(query);
return subscription;
})
.toThrow();
});
it("should call `update` to initialize the result set", () => {
const query = DatabaseStore.findAll(Thread);
spyOn(QuerySubscription.prototype, 'update');
const subscription = new QuerySubscription(query);
expect(subscription).toBeDefined();
expect(QuerySubscription.prototype.update).toHaveBeenCalled();
});
describe("when initialModels are provided", () =>
it("should apply the models and trigger", () => {
const query = DatabaseStore.findAll(Thread);
const threads = [1, 2, 3, 4, 5].map(i => new Thread({id: i}));
const subscription = new QuerySubscription(query, {initialModels: threads});
expect(subscription._set).not.toBe(null);
})
);
})
);
describe("query", () =>
it("should return the query", () => {
const query = DatabaseStore.findAll(Thread);
const subscription = new QuerySubscription(query);
expect(subscription.query()).toBe(query);
})
);
describe("addCallback", () =>
it("should emit the last result to the new callback if one is available", () => {
const cb = jasmine.createSpy('callback');
spyOn(QuerySubscription.prototype, 'update').andReturn();
const subscription = new QuerySubscription(DatabaseStore.findAll(Thread));
subscription._lastResult = 'something';
runs(() => {
subscription.addCallback(cb);
advanceClock();
});
waitsFor(() => cb.calls.length > 0);
runs(() => expect(cb).toHaveBeenCalledWith('something'));
})
);
describe("applyChangeRecord", () => {
spyOn(Utils, 'generateTempId').andCallFake(() => undefined);
const scenarios = [{
name: "query with full set of objects (4)",
query: DatabaseStore.findAll(Thread).where(Thread.attributes.accountId.equal('a')).limit(4).offset(2),
lastModels: [
new Thread({accountId: 'a', clientId: '4', lastMessageReceivedTimestamp: 4}),
new Thread({accountId: 'a', clientId: '3', lastMessageReceivedTimestamp: 3}),
new Thread({accountId: 'a', clientId: '2', lastMessageReceivedTimestamp: 2}),
new Thread({accountId: 'a', clientId: '1', lastMessageReceivedTimestamp: 1}),
],
tests: [{
name: 'Item in set saved - new serverId, same sort value',
change: {
objectClass: Thread.name,
objects: [new Thread({accountId: 'a', serverId: 's-4', clientId: '4', lastMessageReceivedTimestamp: 4, subject: 'hello'})],
type: 'persist',
},
nextModels: [
new Thread({accountId: 'a', serverId: 's-4', clientId: '4', lastMessageReceivedTimestamp: 4, subject: 'hello'}),
new Thread({accountId: 'a', clientId: '3', lastMessageReceivedTimestamp: 3}),
new Thread({accountId: 'a', clientId: '2', lastMessageReceivedTimestamp: 2}),
new Thread({accountId: 'a', clientId: '1', lastMessageReceivedTimestamp: 1}),
],
mustUpdate: false,
mustTrigger: true,
}, {
name: 'Item in set saved - new sort value',
change: {
objectClass: Thread.name,
objects: [new Thread({accountId: 'a', clientId: '5', lastMessageReceivedTimestamp: 3.5})],
type: 'persist',
},
nextModels: [
new Thread({accountId: 'a', clientId: '4', lastMessageReceivedTimestamp: 4}),
new Thread({accountId: 'a', clientId: '5', lastMessageReceivedTimestamp: 3.5}),
new Thread({accountId: 'a', clientId: '3', lastMessageReceivedTimestamp: 3}),
new Thread({accountId: 'a', clientId: '2', lastMessageReceivedTimestamp: 2}),
],
mustUpdate: true,
mustTrigger: true,
}, {
name: 'Item saved - does not match query clauses, offset > 0',
change: {
objectClass: Thread.name,
objects: [new Thread({accountId: 'b', clientId: '5', lastMessageReceivedTimestamp: 5})],
type: 'persist',
},
nextModels: 'unchanged',
mustUpdate: true,
}, {
name: 'Item saved - matches query clauses',
change: {
objectClass: Thread.name,
objects: [new Thread({accountId: 'a', clientId: '5', lastMessageReceivedTimestamp: -2})],
type: 'persist',
},
mustUpdate: true,
}, {
name: 'Item in set saved - no longer matches query clauses',
change: {
objectClass: Thread.name,
objects: [new Thread({accountId: 'b', clientId: '4', lastMessageReceivedTimestamp: 4})],
type: 'persist',
},
nextModels: [
new Thread({accountId: 'a', clientId: '3', lastMessageReceivedTimestamp: 3}),
new Thread({accountId: 'a', clientId: '2', lastMessageReceivedTimestamp: 2}),
new Thread({accountId: 'a', clientId: '1', lastMessageReceivedTimestamp: 1}),
],
mustUpdate: true,
}, {
name: 'Item in set deleted',
change: {
objectClass: Thread.name,
objects: [new Thread({accountId: 'a', clientId: '4'})],
type: 'unpersist',
},
nextModels: [
new Thread({accountId: 'a', clientId: '3', lastMessageReceivedTimestamp: 3}),
new Thread({accountId: 'a', clientId: '2', lastMessageReceivedTimestamp: 2}),
new Thread({accountId: 'a', clientId: '1', lastMessageReceivedTimestamp: 1}),
],
mustUpdate: true,
}, {
name: 'Item not in set deleted',
change: {
objectClass: Thread.name,
objects: [new Thread({accountId: 'a', clientId: '5'})],
type: 'unpersist',
},
nextModels: 'unchanged',
mustUpdate: false,
}],
}, {
name: "query with multiple sort orders",
query: DatabaseStore.findAll(Thread).where(Thread.attributes.accountId.equal('a')).limit(4).offset(2).order([
Thread.attributes.lastMessageReceivedTimestamp.ascending(),
Thread.attributes.unread.descending(),
]),
lastModels: [
new Thread({accountId: 'a', clientId: '1', lastMessageReceivedTimestamp: 1, unread: true}),
new Thread({accountId: 'a', clientId: '2', lastMessageReceivedTimestamp: 1, unread: false}),
new Thread({accountId: 'a', clientId: '3', lastMessageReceivedTimestamp: 1, unread: false}),
new Thread({accountId: 'a', clientId: '4', lastMessageReceivedTimestamp: 2, unread: true}),
],
tests: [{
name: 'Item in set saved, secondary sort order changed',
change: {
objectClass: Thread.name,
objects: [new Thread({accountId: 'a', clientId: '3', lastMessageReceivedTimestamp: 1, unread: true})],
type: 'persist',
},
mustUpdate: true,
}],
}];
jasmine.unspy(Utils, 'generateTempId');
describe("scenarios", () =>
scenarios.forEach(scenario => {
scenario.tests.forEach(test => {
it(`with ${scenario.name}, should correctly apply ${test.name}`, () => {
const subscription = new QuerySubscription(scenario.query);
subscription._set = new MutableQueryResultSet();
subscription._set.addModelsInRange(scenario.lastModels, new QueryRange({start: 0, end: scenario.lastModels.length}));
spyOn(subscription, 'update');
spyOn(subscription, '_createResultAndTrigger');
subscription._updateInFlight = false;
subscription.applyChangeRecord(test.change);
if (test.mustUpdate) {
expect(subscription.update).toHaveBeenCalledWith({mustRefetchEntireRange: true});
} else if (test.nextModels === 'unchanged') {
expect(subscription._set.models()).toEqual(scenario.lastModels);
} else {
expect(subscription._set.models()).toEqual(test.nextModels);
}
if (test.mustTriger) {
expect(subscription._createResultAndTrigger).toHaveBeenCalled();
}
});
});
})
);
});
describe("update", () => {
beforeEach(() =>
spyOn(QuerySubscription.prototype, '_fetchRange').andCallFake(() => {
if (this._set == null) { this._set = new MutableQueryResultSet(); }
return Promise.resolve();
})
);
describe("when the query has an infinite range", () => {
it("should call _fetchRange for the entire range", () => {
const subscription = new QuerySubscription(DatabaseStore.findAll(Thread));
subscription.update();
advanceClock();
expect(subscription._fetchRange).toHaveBeenCalledWith(QueryRange.infinite(), {fetchEntireModels: true, version: 1});
});
it("should fetch full full models only when the previous set is empty", () => {
const subscription = new QuerySubscription(DatabaseStore.findAll(Thread));
subscription._set = new MutableQueryResultSet();
subscription._set.addModelsInRange([new Thread()], new QueryRange({start: 0, end: 1}));
subscription.update();
advanceClock();
expect(subscription._fetchRange).toHaveBeenCalledWith(QueryRange.infinite(), {fetchEntireModels: false, version: 1});
});
});
describe("when the query has a range", () => {
beforeEach(() => {
this.query = DatabaseStore.findAll(Thread).limit(10);
});
describe("when we have no current range", () =>
it("should call _fetchRange for the entire range and fetch full models", () => {
const subscription = new QuerySubscription(this.query);
subscription._set = null;
subscription.update();
advanceClock();
expect(subscription._fetchRange).toHaveBeenCalledWith(this.query.range(), {fetchEntireModels: true, version: 1});
})
);
describe("when we have a previous range", () => {
it("should call _fetchRange with the missingRange", () => {
const customRange = jasmine.createSpy('customRange1');
spyOn(QueryRange, 'rangesBySubtracting').andReturn([customRange]);
const subscription = new QuerySubscription(this.query);
subscription._set = new MutableQueryResultSet();
subscription._set.addModelsInRange([new Thread()], new QueryRange({start: 0, end: 1}));
advanceClock();
subscription._fetchRange.reset();
subscription._updateInFlight = false;
subscription.update();
advanceClock();
expect(subscription._fetchRange.callCount).toBe(1);
expect(subscription._fetchRange.calls[0].args).toEqual([customRange, {fetchEntireModels: true, version: 1}]);
});
it("should call _fetchRange for the entire query range when the missing range encompasses more than one range", () => {
const customRange1 = jasmine.createSpy('customRange1');
const customRange2 = jasmine.createSpy('customRange2');
spyOn(QueryRange, 'rangesBySubtracting').andReturn([customRange1, customRange2]);
const range = new QueryRange({start: 0, end: 1});
const subscription = new QuerySubscription(this.query);
subscription._set = new MutableQueryResultSet();
subscription._set.addModelsInRange([new Thread()], range);
advanceClock();
subscription._fetchRange.reset();
subscription._updateInFlight = false;
subscription.update();
advanceClock();
expect(subscription._fetchRange.callCount).toBe(1);
expect(subscription._fetchRange.calls[0].args).toEqual([this.query.range(), {fetchEntireModels: true, version: 1}]);
});
});
});
});
});