mirror of
https://github.com/Foundry376/Mailspring.git
synced 2025-01-04 07:10:06 +08:00
f1c0a1615d
Summary:
- Removes controlled focus in the composer!
- No React components ever perfom focus in lifecycle methods. Never again.
- A new `Utils.schedule({action, after, timeout})` helper makes it easy to say "setState or load draft, etc. and then focus"
- The DraftStore issues a focusDraft action after creating a draft, which causes the MessageList to focus and scroll to the desired composer, which itself decides which field to focus.
- The MessageList never focuses anything automatically.
- Refactors ComposerView apart — ComposerHeader handles all top fields, DraftSessionContainer handles draft session initialization and exposes props to ComposerView
- ComposerHeader now uses a KeyCommandRegion (with focusIn and focusOut) to do the expanding and collapsing of the participants fields. May rename that container very soon.
- Removes all CommandRegistry handling of tab and shift-tab. Unless you preventDefault, the browser does it's thing.
- Removes all tabIndexes greater than 1. This is an anti-pattern—assigning everything a tabIndex of 0 tells the browser to move between them based on their order in the DOM, and is almost always what you want.
- Adds "TabGroupRegion" which allows you to create a tab/shift-tabbing group, (so tabbing does not leave the active composer). Can't believe this isn't a browser feature.
Todos:
- Occasionally, clicking out of the composer contenteditable requires two clicks. This is because atomicEdit is restoring selection within the contenteditable and breaking blur.
- Because the ComposerView does not render until it has a draft, we're back to it being white in popout composers for a brief moment. We will fix this another way - all the "return unless draft" statements were untenable.
- Clicking a row in the thread list no longer shifts focus to the message list and focuses the last draft. This will be restored soon.
Test Plan: Broken
Reviewers: juan, evan
Reviewed By: juan, evan
Differential Revision: https://phab.nylas.com/D2814
57 lines
2.5 KiB
CoffeeScript
57 lines
2.5 KiB
CoffeeScript
# _ = require "underscore"
|
|
# React = require "react"
|
|
# Fields = require '../lib/fields'
|
|
# ReactTestUtils = require('react-addons-test-utils')
|
|
# AccountContactField = require '../lib/account-contact-field'
|
|
# ExpandedParticipants = require '../lib/expanded-participants'
|
|
# {Actions} = require 'nylas-exports'
|
|
#
|
|
# describe "ExpandedParticipants", ->
|
|
# makeField = (props={}) ->
|
|
# @onChangeParticipants = jasmine.createSpy("onChangeParticipants")
|
|
# @onAdjustEnabledFields = jasmine.createSpy("onAdjustEnabledFields")
|
|
# props.onChangeParticipants = @onChangeParticipants
|
|
# props.onAdjustEnabledFields = @onAdjustEnabledFields
|
|
# @fields = ReactTestUtils.renderIntoDocument(
|
|
# <ExpandedParticipants {...props} />
|
|
# )
|
|
#
|
|
# it "always renders to field", ->
|
|
# makeField.call(@)
|
|
# el = ReactTestUtils.findRenderedDOMComponentWithClass(@fields, "to-field")
|
|
# expect(el).toBeDefined()
|
|
#
|
|
# it "renders cc when enabled", ->
|
|
# makeField.call(@, enabledFields: [Fields.Cc])
|
|
# el = ReactTestUtils.findRenderedDOMComponentWithClass(@fields, "cc-field")
|
|
# expect(el).toBeDefined()
|
|
#
|
|
# it "renders bcc when enabled", ->
|
|
# makeField.call(@, enabledFields: [Fields.Bcc])
|
|
# el = ReactTestUtils.findRenderedDOMComponentWithClass(@fields, "bcc-field")
|
|
# expect(el).toBeDefined()
|
|
#
|
|
# it "renders from when enabled", ->
|
|
# makeField.call(@, enabledFields: [Fields.From])
|
|
# el = ReactTestUtils.findRenderedComponentWithType(@fields, AccountContactField)
|
|
# expect(el).toBeDefined()
|
|
#
|
|
# it "empties cc and focuses on to field", ->
|
|
# makeField.call(@, enabledFields: [Fields.Cc, Fields.Bcc, Fields.Subject])
|
|
# @fields.refs[Fields.Cc].props.onEmptied()
|
|
# expect(@onAdjustEnabledFields).toHaveBeenCalledWith hide: [Fields.Cc]
|
|
#
|
|
# it "empties bcc and focuses on to field", ->
|
|
# makeField.call(@, enabledFields: [Fields.Cc, Fields.Bcc, Fields.Subject])
|
|
# @fields.refs[Fields.Bcc].props.onEmptied()
|
|
# expect(@onAdjustEnabledFields).toHaveBeenCalledWith hide: [Fields.Bcc]
|
|
#
|
|
# it "empties bcc and focuses on cc field", ->
|
|
# makeField.call(@, enabledFields: [Fields.Bcc, Fields.Subject])
|
|
# @fields.refs[Fields.Bcc].props.onEmptied()
|
|
# expect(@onAdjustEnabledFields).toHaveBeenCalledWith hide: [Fields.Bcc]
|
|
#
|
|
# it "notifies when participants change", ->
|
|
# makeField.call(@, enabledFields: [Fields.Cc, Fields.Bcc, Fields.Subject])
|
|
# @fields.refs[Fields.Cc].props.change()
|
|
# expect(@onChangeParticipants).toHaveBeenCalled()
|