Mailspring/spec-nylas
Ben Gotow 3a947ccf54 fix(undo-redo): Minor tweaks to undo/redo based on testing - see description
Summary:
Give UpdateThreadsTask a description method for strings like "Marked as read"

Give ChangeLabelsTask a better description method that returns shorter strings and is specific when possible

Give ChangeFolderTask a more specific description and don't assume folderOrId will always be a folder

Make it so that passive "mark as read" from the message store isn't undoable

Give the base class a description method that names the object

Change UndoRedo component CSS a bit:

- Use "inline-flexbox" with a max-width so that we can define shrinking rules on the label and Undo button (label gets ellipsis, button does not shrink at all)

- Avoid left:39%, since it assumed that the undo-redo element would be 22% of the width of the thread list, which wasn't always true. Instead, make the `undo-redo-manager` container "text-align:center", so the `undo-redo` div is always centered within it.

- Add `cursor:default` so that the user sees the pointer, not the text insertion cursor when hovering over "Undo"

- Add overflow / text-overflow so that if the message is ever too long, the user sees `...` ellipsis properly.

Test Plan: Run a few new tests

Reviewers: evan, ethanb

Reviewed By: ethanb

Differential Revision: https://phab.nylas.com/D1830
2015-08-03 14:46:19 -07:00
..
components fix(contact-chips): Contact chips are editable and have much better style 2015-08-03 13:06:28 -07:00
fixtures Threads now sorted by receivedrecetndate 2015-07-28 14:03:55 -07:00
models fix(T2387): Use better file icons from SDW 2015-07-31 12:34:24 -07:00
stores fix(contact-chips): Contact chips are editable and have much better style 2015-08-03 13:06:28 -07:00
tasks fix(undo-redo): Minor tweaks to undo/redo based on testing - see description 2015-08-03 14:46:19 -07:00
action-bridge-spec.coffee
auto-update-manager-spec.coffee updater(*): Send current platform in update check, publish to S3 in /darwin/ folder 2015-06-30 11:03:24 -07:00
buffered-process-spec.coffee
clipboard-spec.coffee
component-registry-spec.coffee
database-view-spec.coffee Threads now sorted by receivedrecetndate 2015-07-28 14:03:55 -07:00
dom-utils-spec.coffee fix(quoted-text): new system to remove quoted text 2015-07-21 11:34:47 -07:00
menu-manager-spec.coffee
model-view-selection-spec.coffee
model-view-spec.coffee
module-cache-spec.coffee
nylas-protocol-handler-spec.coffee
nylas-sync-worker-spec.coffee feat(draft-syncback): Sync drafts with Gmail (API does not support Exchange syncback) 2015-07-22 11:18:23 -07:00
package-manager-spec.coffee fix(test): remove bad nondeterministic package spec 2015-06-17 20:49:06 -07:00
package-spec.coffee
quoted-html-parser-spec.coffee fix(quoted-text): new system to remove quoted text 2015-07-21 11:34:47 -07:00
quoted-plain-text-parser-spec.coffee feat(quoted-text): New quoted text engine 2015-07-08 09:51:33 -07:00
style-manager-spec.coffee
styles-element-spec.coffee
task-spec.coffee
test_utils.coffee
theme-manager-spec.coffee
undo-manager-spec.coffee
utils-spec.coffee Fixed bug where items in sent folder have "invalid date" 2015-07-31 08:23:03 -07:00