mirror of
https://github.com/Foundry376/Mailspring.git
synced 2024-09-23 16:56:08 +08:00
d1c587a01c
More spec fixes replace process.nextTick with setTimeout(fn, 0) for specs Also added an unspy in the afterEach Temporarily disable specs fix(spec): start fixing specs Summary: This is the WIP fix to our spec runner. Several tests have been completely commented out that will require substantially more work to fix. These have been added to our sprint backlog. Other tests have been fixed to update to new APIs or to deal with genuine bugs that were introduced without our knowing! The most common non-trivial change relates to observing the `NylasAPI` and `NylasAPIRequest`. We used to observe the arguments to `makeRequest`. Unfortunately `NylasAPIRequest.run` is argumentless. Instead you can do: `NylasAPIRequest.prototype.run.mostRecentCall.object.options` to get the `options` passed into the object. the `.object` property grabs the context of the spy when it was last called. Fixing these tests uncovered several concerning issues with our test runner. I spent a while tracking down why our participant-text-field-spec was failling every so often. I chose that spec because it was the first spec to likely fail, thereby requiring looking at the least number of preceding files. I tried binary searching, turning on and off, several files beforehand only to realize that the failure rate was not determined by a particular preceding test, but rather the existing and quantity of preceding tests, AND the number of console.log statements I had. There is some processor-dependent race condition going on that needs further investigation. I also discovered an issue with the file-download-spec. We were getting errors about it accessing a file, which was very suspicious given the code stubs out all fs access. This was caused due to a spec that called an async function outside ot a `waitsForPromise` block or a `waitsFor` block. The test completed, the spies were cleaned up, but the downstream async chain was still running. By the time the async chain finished the runner was already working on the next spec and the spies had been restored (causing the real fs access to run). Juan had an idea to kill the specs once one fails to prevent cascading failures. I'll implement this in the next diff update Test Plan: npm test Reviewers: juan, halla, jackie Differential Revision: https://phab.nylas.com/D3501 Disable other specs Disable more broken specs All specs turned off till passing state Use async-safe versions of spec functions Add async test spec Remove unused package code Remove canary spec
617 lines
27 KiB
CoffeeScript
617 lines
27 KiB
CoffeeScript
path = require 'path'
|
||
Package = require '../src/package'
|
||
DatabaseStore = require('../src/flux/stores/database-store').default
|
||
{Disposable} = require 'event-kit'
|
||
|
||
describe "PackageManager", ->
|
||
workspaceElement = null
|
||
|
||
beforeEach ->
|
||
workspaceElement = document.createElement('nylas-workspace')
|
||
jasmine.attachToDOM(workspaceElement)
|
||
|
||
describe "::loadPackage(name)", ->
|
||
beforeEach ->
|
||
NylasEnv.config.set("core.disabledPackages", [])
|
||
|
||
it "returns the package", ->
|
||
pack = NylasEnv.packages.loadPackage("package-with-index")
|
||
expect(pack instanceof Package).toBe true
|
||
expect(pack.metadata.name).toBe "package-with-index"
|
||
|
||
it "returns the package if it has an invalid keymap", ->
|
||
spyOn(console, 'warn')
|
||
spyOn(console, 'error')
|
||
pack = NylasEnv.packages.loadPackage("package-with-broken-keymap")
|
||
expect(pack instanceof Package).toBe true
|
||
expect(pack.metadata.name).toBe "package-with-broken-keymap"
|
||
|
||
it "returns the package if it has an invalid stylesheet", ->
|
||
spyOn(console, 'warn')
|
||
spyOn(console, 'error')
|
||
pack = NylasEnv.packages.loadPackage("package-with-invalid-styles")
|
||
expect(pack instanceof Package).toBe true
|
||
expect(pack.metadata.name).toBe "package-with-invalid-styles"
|
||
expect(pack.stylesheets.length).toBe 0
|
||
|
||
it "returns null if the package has an invalid package.json", ->
|
||
spyOn(console, 'warn')
|
||
spyOn(console, 'error')
|
||
expect(NylasEnv.packages.loadPackage("package-with-broken-package-json")).toBeNull()
|
||
expect(console.warn.callCount).toBe(2)
|
||
expect(console.warn.argsForCall[0][0]).toContain("Failed to load package.json")
|
||
|
||
it "returns null if the package is not found in any package directory", ->
|
||
spyOn(console, 'warn')
|
||
spyOn(console, 'error')
|
||
expect(NylasEnv.packages.loadPackage("this-package-cannot-be-found")).toBeNull()
|
||
expect(console.warn.callCount).toBe(1)
|
||
expect(console.warn.argsForCall[0][0]).toContain("Could not resolve")
|
||
|
||
it "invokes ::onDidLoadPackage listeners with the loaded package", ->
|
||
loadedPackage = null
|
||
NylasEnv.packages.onDidLoadPackage (pack) -> loadedPackage = pack
|
||
|
||
NylasEnv.packages.loadPackage("package-with-main")
|
||
|
||
expect(loadedPackage.name).toBe "package-with-main"
|
||
|
||
describe "::unloadPackage(name)", ->
|
||
describe "when the package is active", ->
|
||
it "throws an error", ->
|
||
pack = null
|
||
waitsForPromise ->
|
||
NylasEnv.packages.activatePackage('package-with-main').then (p) -> pack = p
|
||
|
||
runs ->
|
||
expect(NylasEnv.packages.isPackageLoaded(pack.name)).toBeTruthy()
|
||
expect(NylasEnv.packages.isPackageActive(pack.name)).toBeTruthy()
|
||
expect( -> NylasEnv.packages.unloadPackage(pack.name)).toThrow()
|
||
expect(NylasEnv.packages.isPackageLoaded(pack.name)).toBeTruthy()
|
||
expect(NylasEnv.packages.isPackageActive(pack.name)).toBeTruthy()
|
||
|
||
describe "when the package is not loaded", ->
|
||
it "throws an error", ->
|
||
expect(NylasEnv.packages.isPackageLoaded('unloaded')).toBeFalsy()
|
||
expect( -> NylasEnv.packages.unloadPackage('unloaded')).toThrow()
|
||
expect(NylasEnv.packages.isPackageLoaded('unloaded')).toBeFalsy()
|
||
|
||
describe "when the package is loaded", ->
|
||
it "no longers reports it as being loaded", ->
|
||
pack = NylasEnv.packages.loadPackage('package-with-main')
|
||
expect(NylasEnv.packages.isPackageLoaded(pack.name)).toBeTruthy()
|
||
NylasEnv.packages.unloadPackage(pack.name)
|
||
expect(NylasEnv.packages.isPackageLoaded(pack.name)).toBeFalsy()
|
||
|
||
it "invokes ::onDidUnloadPackage listeners with the unloaded package", ->
|
||
NylasEnv.packages.loadPackage('package-with-main')
|
||
unloadedPackage = null
|
||
NylasEnv.packages.onDidUnloadPackage (pack) -> unloadedPackage = pack
|
||
NylasEnv.packages.unloadPackage('package-with-main')
|
||
expect(unloadedPackage.name).toBe 'package-with-main'
|
||
|
||
describe "::activatePackage(id)", ->
|
||
describe "when called multiple times", ->
|
||
it "it only calls activate on the package once", ->
|
||
spyOn(Package.prototype, 'activateNow').andCallThrough()
|
||
waitsForPromise ->
|
||
NylasEnv.packages.activatePackage('package-with-index')
|
||
waitsForPromise ->
|
||
NylasEnv.packages.activatePackage('package-with-index')
|
||
waitsForPromise ->
|
||
NylasEnv.packages.activatePackage('package-with-index')
|
||
|
||
runs ->
|
||
expect(Package.prototype.activateNow.callCount).toBe 1
|
||
|
||
describe "when the package has a main module", ->
|
||
describe "when the metadata specifies a main module path˜", ->
|
||
it "requires the module at the specified path", ->
|
||
mainModule = require('./fixtures/packages/package-with-main/main-module')
|
||
spyOn(mainModule, 'activate')
|
||
pack = null
|
||
waitsForPromise ->
|
||
NylasEnv.packages.activatePackage('package-with-main').then (p) -> pack = p
|
||
|
||
runs ->
|
||
expect(mainModule.activate).toHaveBeenCalled()
|
||
expect(pack.mainModule).toBe mainModule
|
||
|
||
describe "when the metadata does not specify a main module", ->
|
||
it "requires index.coffee", ->
|
||
indexModule = require('./fixtures/packages/package-with-index/index')
|
||
spyOn(indexModule, 'activate')
|
||
pack = null
|
||
waitsForPromise ->
|
||
NylasEnv.packages.activatePackage('package-with-index').then (p) -> pack = p
|
||
|
||
runs ->
|
||
expect(indexModule.activate).toHaveBeenCalled()
|
||
expect(pack.mainModule).toBe indexModule
|
||
|
||
it "assigns config schema, including defaults when package contains a schema", ->
|
||
expect(NylasEnv.config.get('package-with-config-schema.numbers.one')).toBeUndefined()
|
||
|
||
waitsForPromise ->
|
||
NylasEnv.packages.activatePackage('package-with-config-schema')
|
||
|
||
runs ->
|
||
expect(NylasEnv.config.get('package-with-config-schema.numbers.one')).toBe 1
|
||
expect(NylasEnv.config.get('package-with-config-schema.numbers.two')).toBe 2
|
||
|
||
expect(NylasEnv.config.set('package-with-config-schema.numbers.one', 'nope')).toBe false
|
||
expect(NylasEnv.config.set('package-with-config-schema.numbers.one', '10')).toBe true
|
||
expect(NylasEnv.config.get('package-with-config-schema.numbers.one')).toBe 10
|
||
|
||
describe "when the package has no main module", ->
|
||
it "des not compalain if it doesn't have a package.json", ->
|
||
spyOn(console, "error")
|
||
spyOn(console, "warn")
|
||
waitsForPromise ->
|
||
NylasEnv.packages.activatePackage('package-without-module')
|
||
.then ->
|
||
expect(-> NylasEnv.packages.activatePackage('package-without-module')).not.toThrow()
|
||
expect(console.error).not.toHaveBeenCalled()
|
||
expect(console.warn).not.toHaveBeenCalled()
|
||
|
||
it "passes the activate method the package's previously serialized state if it exists", ->
|
||
pack = null
|
||
waitsForPromise ->
|
||
NylasEnv.packages.activatePackage("package-with-serialization").then (p) -> pack = p
|
||
|
||
runs ->
|
||
expect(pack.mainModule.someNumber).not.toBe 77
|
||
pack.mainModule.someNumber = 77
|
||
NylasEnv.packages.deactivatePackage("package-with-serialization")
|
||
spyOn(pack.mainModule, 'activate').andCallThrough()
|
||
waitsForPromise ->
|
||
NylasEnv.packages.activatePackage("package-with-serialization")
|
||
runs ->
|
||
expect(pack.mainModule.activate.calls[0].args[0]).toEqual({someNumber: 77})
|
||
|
||
it "invokes ::onDidActivatePackage listeners with the activated package", ->
|
||
activatedPackage = null
|
||
NylasEnv.packages.onDidActivatePackage (pack) ->
|
||
activatedPackage = pack
|
||
|
||
NylasEnv.packages.activatePackage('package-with-main')
|
||
|
||
waitsFor -> activatedPackage?
|
||
runs -> expect(activatedPackage.name).toBe 'package-with-main'
|
||
|
||
describe "when the package throws an error while loading", ->
|
||
it "logs a warning instead of throwing an exception", ->
|
||
NylasEnv.config.set("core.disabledPackages", [])
|
||
spyOn(console, "log")
|
||
spyOn(console, "warn")
|
||
spyOn(console, "error")
|
||
expect(-> NylasEnv.packages.activatePackage("package-that-throws-an-exception")).not.toThrow()
|
||
expect(console.warn).toHaveBeenCalled()
|
||
|
||
describe "when the package is not found", ->
|
||
it "rejects the promise", ->
|
||
NylasEnv.config.set("core.disabledPackages", [])
|
||
|
||
onSuccess = jasmine.createSpy('onSuccess')
|
||
onFailure = jasmine.createSpy('onFailure')
|
||
spyOn(console, 'warn')
|
||
spyOn(console, "error")
|
||
|
||
NylasEnv.packages.activatePackage("this-doesnt-exist").then(onSuccess, onFailure)
|
||
|
||
waitsFor "promise to be rejected", ->
|
||
onFailure.callCount > 0
|
||
|
||
runs ->
|
||
expect(console.warn.callCount).toBe 1
|
||
expect(onFailure.mostRecentCall.args[0] instanceof Error).toBe true
|
||
expect(onFailure.mostRecentCall.args[0].message).toContain "Failed to load package 'this-doesnt-exist'"
|
||
|
||
describe "keymap loading", ->
|
||
describe "when the metadata does not contain a 'keymaps' manifest", ->
|
||
it "loads all the .json files in the keymaps directory", ->
|
||
expect(NylasEnv.keymaps.getBindingsForCommand('my-package:command-a')).toHaveLength 0
|
||
expect(NylasEnv.keymaps.getBindingsForCommand('my-package:command-b')).toHaveLength 0
|
||
|
||
waitsForPromise ->
|
||
NylasEnv.packages.activatePackage("package-with-keymaps")
|
||
|
||
runs ->
|
||
expect(NylasEnv.keymaps.getBindingsForCommand('my-package:command-a')).toHaveLength 1
|
||
expect(NylasEnv.keymaps.getBindingsForCommand('my-package:command-b')).toHaveLength 1
|
||
|
||
describe "when the metadata contains a 'keymaps' manifest", ->
|
||
it "loads only the keymaps specified by the manifest, in the specified order", ->
|
||
expect(NylasEnv.keymaps.getBindingsForCommand('my-package:command-a')).toHaveLength 0
|
||
expect(NylasEnv.keymaps.getBindingsForCommand('my-package:command-b')).toHaveLength 0
|
||
|
||
waitsForPromise ->
|
||
NylasEnv.packages.activatePackage("package-with-keymaps-manifest")
|
||
|
||
runs ->
|
||
expect(NylasEnv.keymaps.getBindingsForCommand('my-package:command-a')).toHaveLength 1
|
||
expect(NylasEnv.keymaps.getBindingsForCommand('my-package:command-b')).toHaveLength 1
|
||
|
||
describe "when the keymap file is empty", ->
|
||
it "does not throw an error on activation", ->
|
||
spyOn(console, 'error')
|
||
waitsForPromise ->
|
||
NylasEnv.packages.activatePackage("package-with-empty-keymap")
|
||
|
||
runs ->
|
||
expect(NylasEnv.packages.isPackageActive("package-with-empty-keymap")).toBe true
|
||
|
||
describe "menu loading", ->
|
||
beforeEach ->
|
||
NylasEnv.menu.template = []
|
||
|
||
describe "when the metadata does not contain a 'menus' manifest", ->
|
||
it "loads all the .json files in the menus directory", ->
|
||
waitsForPromise ->
|
||
NylasEnv.packages.activatePackage("package-with-menus")
|
||
|
||
runs ->
|
||
expect(NylasEnv.menu.template.length).toBe 2
|
||
expect(NylasEnv.menu.template[1].label).toBe "Second to Last"
|
||
expect(NylasEnv.menu.template[0].label).toBe "Last"
|
||
|
||
describe "when the metadata contains a 'menus' manifest", ->
|
||
it "loads only the menus specified by the manifest, in the specified order", ->
|
||
waitsForPromise ->
|
||
NylasEnv.packages.activatePackage("package-with-menus-manifest")
|
||
|
||
runs ->
|
||
expect(NylasEnv.menu.template[0].label).toBe "Second to Last"
|
||
expect(NylasEnv.menu.template[1].label).toBe "Last"
|
||
|
||
describe "when the menu file is empty", ->
|
||
it "does not throw an error on activation", ->
|
||
waitsForPromise ->
|
||
NylasEnv.packages.activatePackage("package-with-empty-menu")
|
||
|
||
runs ->
|
||
expect(NylasEnv.packages.isPackageActive("package-with-empty-menu")).toBe true
|
||
|
||
describe "stylesheet loading", ->
|
||
describe "when the metadata contains a 'styleSheets' manifest", ->
|
||
it "loads style sheets from the styles directory as specified by the manifest", ->
|
||
one = require.resolve("./fixtures/packages/package-with-style-sheets-manifest/styles/1.css")
|
||
two = require.resolve("./fixtures/packages/package-with-style-sheets-manifest/styles/2.less")
|
||
three = require.resolve("./fixtures/packages/package-with-style-sheets-manifest/styles/3.css")
|
||
|
||
one = NylasEnv.themes.stringToId(one)
|
||
two = NylasEnv.themes.stringToId(two)
|
||
three = NylasEnv.themes.stringToId(three)
|
||
|
||
expect(NylasEnv.themes.stylesheetElementForId(one)).toBeNull()
|
||
expect(NylasEnv.themes.stylesheetElementForId(two)).toBeNull()
|
||
expect(NylasEnv.themes.stylesheetElementForId(three)).toBeNull()
|
||
|
||
waitsForPromise ->
|
||
NylasEnv.packages.activatePackage("package-with-style-sheets-manifest")
|
||
|
||
runs ->
|
||
expect(NylasEnv.themes.stylesheetElementForId(one)).not.toBeNull()
|
||
expect(NylasEnv.themes.stylesheetElementForId(two)).not.toBeNull()
|
||
expect(NylasEnv.themes.stylesheetElementForId(three)).toBeNull()
|
||
expect(window.getComputedStyle(document.getElementById('jasmine-content')).fontSize).toBe '1px'
|
||
|
||
describe "when the metadata does not contain a 'styleSheets' manifest", ->
|
||
it "loads all style sheets from the styles directory", ->
|
||
one = require.resolve("./fixtures/packages/package-with-styles/styles/1.css")
|
||
two = require.resolve("./fixtures/packages/package-with-styles/styles/2.less")
|
||
three = require.resolve("./fixtures/packages/package-with-styles/styles/3.test-context.css")
|
||
four = require.resolve("./fixtures/packages/package-with-styles/styles/4.css")
|
||
|
||
one = NylasEnv.themes.stringToId(one)
|
||
two = NylasEnv.themes.stringToId(two)
|
||
three = NylasEnv.themes.stringToId(three)
|
||
four = NylasEnv.themes.stringToId(four)
|
||
|
||
expect(NylasEnv.themes.stylesheetElementForId(one)).toBeNull()
|
||
expect(NylasEnv.themes.stylesheetElementForId(two)).toBeNull()
|
||
expect(NylasEnv.themes.stylesheetElementForId(three)).toBeNull()
|
||
expect(NylasEnv.themes.stylesheetElementForId(four)).toBeNull()
|
||
|
||
waitsForPromise ->
|
||
NylasEnv.packages.activatePackage("package-with-styles")
|
||
|
||
runs ->
|
||
expect(NylasEnv.themes.stylesheetElementForId(one)).not.toBeNull()
|
||
expect(NylasEnv.themes.stylesheetElementForId(two)).not.toBeNull()
|
||
expect(NylasEnv.themes.stylesheetElementForId(three)).not.toBeNull()
|
||
expect(NylasEnv.themes.stylesheetElementForId(four)).not.toBeNull()
|
||
expect(window.getComputedStyle(document.getElementById('jasmine-content')).fontSize).toBe '3px'
|
||
|
||
it "assigns the stylesheet's context based on the filename", ->
|
||
waitsForPromise ->
|
||
NylasEnv.packages.activatePackage("package-with-styles")
|
||
|
||
runs ->
|
||
count = 0
|
||
|
||
for styleElement in NylasEnv.styles.getStyleElements()
|
||
if styleElement.sourcePath.match /1.css/
|
||
expect(styleElement.context).toBe undefined
|
||
count++
|
||
|
||
if styleElement.sourcePath.match /2.less/
|
||
expect(styleElement.context).toBe undefined
|
||
count++
|
||
|
||
if styleElement.sourcePath.match /3.test-context.css/
|
||
expect(styleElement.context).toBe 'test-context'
|
||
count++
|
||
|
||
if styleElement.sourcePath.match /4.css/
|
||
expect(styleElement.context).toBe undefined
|
||
count++
|
||
|
||
expect(count).toBe 4
|
||
|
||
describe "::deactivatePackage(id)", ->
|
||
afterEach ->
|
||
NylasEnv.packages.unloadPackages()
|
||
|
||
it "calls `deactivate` on the package's main module if activate was successful", ->
|
||
pack = null
|
||
waitsForPromise ->
|
||
NylasEnv.packages.activatePackage("package-with-deactivate").then (p) -> pack = p
|
||
|
||
runs ->
|
||
expect(NylasEnv.packages.isPackageActive("package-with-deactivate")).toBeTruthy()
|
||
spyOn(pack.mainModule, 'deactivate').andCallThrough()
|
||
|
||
NylasEnv.packages.deactivatePackage("package-with-deactivate")
|
||
expect(pack.mainModule.deactivate).toHaveBeenCalled()
|
||
expect(NylasEnv.packages.isPackageActive("package-with-module")).toBeFalsy()
|
||
|
||
spyOn(console, 'log')
|
||
spyOn(console, 'warn')
|
||
spyOn(console, "error")
|
||
|
||
badPack = null
|
||
waitsForPromise ->
|
||
NylasEnv.packages.activatePackage("package-that-throws-on-activate").then (p) -> badPack = p
|
||
|
||
runs ->
|
||
expect(NylasEnv.packages.isPackageActive("package-that-throws-on-activate")).toBeTruthy()
|
||
spyOn(badPack.mainModule, 'deactivate').andCallThrough()
|
||
|
||
NylasEnv.packages.deactivatePackage("package-that-throws-on-activate")
|
||
expect(badPack.mainModule.deactivate).not.toHaveBeenCalled()
|
||
expect(NylasEnv.packages.isPackageActive("package-that-throws-on-activate")).toBeFalsy()
|
||
|
||
it "does not serialize packages that have not been activated called on their main module", ->
|
||
spyOn(console, 'log')
|
||
spyOn(console, 'warn')
|
||
spyOn(console, "error")
|
||
badPack = null
|
||
waitsForPromise ->
|
||
NylasEnv.packages.activatePackage("package-that-throws-on-activate").then (p) -> badPack = p
|
||
|
||
runs ->
|
||
spyOn(badPack.mainModule, 'serialize').andCallThrough()
|
||
|
||
NylasEnv.packages.deactivatePackage("package-that-throws-on-activate")
|
||
expect(badPack.mainModule.serialize).not.toHaveBeenCalled()
|
||
|
||
it "absorbs exceptions that are thrown by the package module's serialize method", ->
|
||
spyOn(console, 'error')
|
||
|
||
waitsForPromise ->
|
||
NylasEnv.packages.activatePackage('package-with-serialize-error')
|
||
|
||
waitsForPromise ->
|
||
NylasEnv.packages.activatePackage('package-with-serialization')
|
||
|
||
runs ->
|
||
NylasEnv.packages.deactivatePackages()
|
||
expect(NylasEnv.packages.packageStates['package-with-serialize-error']).toBeUndefined()
|
||
expect(NylasEnv.packages.packageStates['package-with-serialization']).toEqual someNumber: 1
|
||
expect(console.error).toHaveBeenCalled()
|
||
|
||
it "absorbs exceptions that are thrown by the package module's deactivate method", ->
|
||
spyOn(console, 'error')
|
||
|
||
waitsForPromise ->
|
||
NylasEnv.packages.activatePackage("package-that-throws-on-deactivate")
|
||
|
||
runs ->
|
||
expect(-> NylasEnv.packages.deactivatePackage("package-that-throws-on-deactivate")).not.toThrow()
|
||
expect(console.error).toHaveBeenCalled()
|
||
|
||
it "removes the package's keymaps", ->
|
||
waitsForPromise ->
|
||
NylasEnv.packages.activatePackage('package-with-keymaps')
|
||
|
||
runs ->
|
||
expect(NylasEnv.keymaps.getBindingsForCommand('my-package:command-a')).toHaveLength 1
|
||
expect(NylasEnv.keymaps.getBindingsForCommand('my-package:command-b')).toHaveLength 1
|
||
NylasEnv.packages.deactivatePackage('package-with-keymaps')
|
||
expect(NylasEnv.keymaps.getBindingsForCommand('my-package:command-a')).toHaveLength 0
|
||
expect(NylasEnv.keymaps.getBindingsForCommand('my-package:command-b')).toHaveLength 0
|
||
|
||
it "removes the package's stylesheets", ->
|
||
waitsForPromise ->
|
||
NylasEnv.packages.activatePackage('package-with-styles')
|
||
|
||
runs ->
|
||
NylasEnv.packages.deactivatePackage('package-with-styles')
|
||
one = require.resolve("./fixtures/packages/package-with-style-sheets-manifest/styles/1.css")
|
||
two = require.resolve("./fixtures/packages/package-with-style-sheets-manifest/styles/2.less")
|
||
three = require.resolve("./fixtures/packages/package-with-style-sheets-manifest/styles/3.css")
|
||
expect(NylasEnv.themes.stylesheetElementForId(one)).toBe(null)
|
||
expect(NylasEnv.themes.stylesheetElementForId(two)).toBe(null)
|
||
expect(NylasEnv.themes.stylesheetElementForId(three)).toBe(null)
|
||
|
||
it "invokes ::onDidDeactivatePackage listeners with the deactivated package", ->
|
||
waitsForPromise ->
|
||
NylasEnv.packages.activatePackage("package-with-main")
|
||
|
||
runs ->
|
||
deactivatedPackage = null
|
||
NylasEnv.packages.onDidDeactivatePackage (pack) -> deactivatedPackage = pack
|
||
NylasEnv.packages.deactivatePackage("package-with-main")
|
||
expect(deactivatedPackage.name).toBe "package-with-main"
|
||
|
||
describe "::activate()", ->
|
||
beforeEach ->
|
||
spyOn(console, 'warn')
|
||
spyOn(console, "error")
|
||
NylasEnv.packages.loadPackages()
|
||
|
||
loadedPackages = NylasEnv.packages.getLoadedPackages()
|
||
expect(loadedPackages.length).toBeGreaterThan 0
|
||
|
||
afterEach ->
|
||
NylasEnv.packages.deactivatePackages()
|
||
NylasEnv.packages.unloadPackages()
|
||
|
||
it "activates all the packages, and none of the themes", ->
|
||
packageActivator = spyOn(NylasEnv.packages, 'activatePackages')
|
||
themeActivator = spyOn(NylasEnv.themes, 'activatePackages')
|
||
|
||
NylasEnv.packages.activate()
|
||
|
||
expect(packageActivator).toHaveBeenCalled()
|
||
expect(themeActivator).toHaveBeenCalled()
|
||
|
||
packages = packageActivator.mostRecentCall.args[0]
|
||
expect(['nylas']).toContain(pack.getType()) for pack in packages
|
||
|
||
themes = themeActivator.mostRecentCall.args[0]
|
||
expect(['theme']).toContain(theme.getType()) for theme in themes
|
||
|
||
it "refreshes the database after activating packages with models", ->
|
||
spyOn(DatabaseStore, "refreshDatabaseSchema")
|
||
package2 = NylasEnv.packages.loadPackage('package-with-models')
|
||
NylasEnv.packages.activatePackages([package2])
|
||
expect(DatabaseStore.refreshDatabaseSchema).toHaveBeenCalled()
|
||
expect(DatabaseStore.refreshDatabaseSchema.calls.length).toBe 1
|
||
|
||
it "calls callbacks registered with ::onDidActivateInitialPackages", ->
|
||
package1 = NylasEnv.packages.loadPackage('package-with-main')
|
||
package2 = NylasEnv.packages.loadPackage('package-with-index')
|
||
package3 = NylasEnv.packages.loadPackage('package-with-activation-commands')
|
||
spyOn(NylasEnv.packages, 'getLoadedPackages').andReturn([package1, package2])
|
||
|
||
activateSpy = jasmine.createSpy('activateSpy')
|
||
NylasEnv.packages.onDidActivateInitialPackages(activateSpy)
|
||
|
||
NylasEnv.packages.activate()
|
||
waitsFor -> activateSpy.callCount > 0
|
||
runs ->
|
||
jasmine.unspy(NylasEnv.packages, 'getLoadedPackages')
|
||
expect(package1 in NylasEnv.packages.getActivePackages()).toBe true
|
||
expect(package2 in NylasEnv.packages.getActivePackages()).toBe true
|
||
expect(package3 in NylasEnv.packages.getActivePackages()).toBe false
|
||
|
||
describe "::enablePackage(id) and ::disablePackage(id)", ->
|
||
describe "with packages", ->
|
||
it "enables a disabled package", ->
|
||
spyOn(DatabaseStore, "refreshDatabaseSchema")
|
||
packageName = 'package-with-main'
|
||
NylasEnv.config.pushAtKeyPath('core.disabledPackages', packageName)
|
||
NylasEnv.packages.observeDisabledPackages()
|
||
expect(NylasEnv.config.get('core.disabledPackages')).toContain packageName
|
||
|
||
pack = NylasEnv.packages.enablePackage(packageName)
|
||
loadedPackages = NylasEnv.packages.getLoadedPackages()
|
||
activatedPackages = null
|
||
waitsFor ->
|
||
activatedPackages = NylasEnv.packages.getActivePackages()
|
||
activatedPackages.length > 0
|
||
|
||
runs ->
|
||
expect(loadedPackages).toContain(pack)
|
||
expect(activatedPackages).toContain(pack)
|
||
expect(DatabaseStore.refreshDatabaseSchema).not.toHaveBeenCalled()
|
||
expect(NylasEnv.config.get('core.disabledPackages')).not.toContain packageName
|
||
|
||
it 'refreshes the DB when loading a package with models', ->
|
||
spyOn(DatabaseStore, "refreshDatabaseSchema")
|
||
packageName = "package-with-models"
|
||
NylasEnv.config.pushAtKeyPath('core.disabledPackages', packageName)
|
||
NylasEnv.packages.observeDisabledPackages()
|
||
NylasEnv.config.removeAtKeyPath("core.disabledPackages", packageName)
|
||
expect(DatabaseStore.refreshDatabaseSchema).toHaveBeenCalled()
|
||
expect(DatabaseStore.refreshDatabaseSchema.calls.length).toBe 1
|
||
|
||
it "disables an enabled package", ->
|
||
packageName = 'package-with-main'
|
||
waitsForPromise ->
|
||
NylasEnv.packages.activatePackage(packageName)
|
||
|
||
runs ->
|
||
NylasEnv.packages.observeDisabledPackages()
|
||
expect(NylasEnv.config.get('core.disabledPackages')).not.toContain packageName
|
||
|
||
pack = NylasEnv.packages.disablePackage(packageName)
|
||
|
||
activatedPackages = NylasEnv.packages.getActivePackages()
|
||
expect(activatedPackages).not.toContain(pack)
|
||
expect(NylasEnv.config.get('core.disabledPackages')).toContain packageName
|
||
|
||
it "returns null if the package cannot be loaded", ->
|
||
spyOn(console, 'warn')
|
||
spyOn(console, "error")
|
||
expect(NylasEnv.packages.enablePackage("this-doesnt-exist")).toBeNull()
|
||
expect(console.warn.callCount).toBe 1
|
||
|
||
describe "with themes", ->
|
||
didChangeActiveThemesHandler = null
|
||
|
||
beforeEach ->
|
||
theme_dir = path.resolve(__dirname, '../internal_packages')
|
||
NylasEnv.packages.packageDirPaths.unshift(theme_dir)
|
||
waitsForPromise ->
|
||
NylasEnv.themes.activateThemes()
|
||
|
||
afterEach ->
|
||
NylasEnv.themes.deactivateThemes()
|
||
|
||
it "enables and disables a theme", ->
|
||
packageName = 'theme-with-package-file'
|
||
|
||
expect(NylasEnv.config.get('core.themes')).not.toContain packageName
|
||
expect(NylasEnv.config.get('core.disabledPackages')).not.toContain packageName
|
||
|
||
# enabling of theme
|
||
pack = NylasEnv.packages.enablePackage(packageName)
|
||
|
||
waitsFor ->
|
||
pack in NylasEnv.packages.getActivePackages()
|
||
|
||
runs ->
|
||
expect(NylasEnv.config.get('core.themes')).toContain packageName
|
||
expect(NylasEnv.config.get('core.disabledPackages')).not.toContain packageName
|
||
|
||
didChangeActiveThemesHandler = jasmine.createSpy('didChangeActiveThemesHandler')
|
||
didChangeActiveThemesHandler.reset()
|
||
NylasEnv.themes.onDidChangeActiveThemes didChangeActiveThemesHandler
|
||
|
||
pack = NylasEnv.packages.disablePackage(packageName)
|
||
|
||
waitsFor ->
|
||
didChangeActiveThemesHandler.callCount is 1
|
||
|
||
runs ->
|
||
expect(NylasEnv.packages.getActivePackages()).not.toContain pack
|
||
expect(NylasEnv.config.get('core.themes')).not.toContain packageName
|
||
expect(NylasEnv.config.get('core.themes')).not.toContain packageName
|
||
expect(NylasEnv.config.get('core.disabledPackages')).not.toContain packageName
|
||
|
||
describe 'packages with models and tasks', ->
|
||
beforeEach ->
|
||
NylasEnv.packages.deactivatePackages()
|
||
NylasEnv.packages.unloadPackages()
|
||
|
||
it 'registers objects on load', ->
|
||
withModels = NylasEnv.packages.loadPackage("package-with-models")
|
||
withoutModels = NylasEnv.packages.loadPackage("package-with-main")
|
||
expect(withModels.declaresNewDatabaseObjects).toBe true
|
||
expect(withoutModels.declaresNewDatabaseObjects).toBe false
|
||
expect(NylasEnv.packages.packagesWithDatabaseObjects.length).toBe 1
|
||
expect(NylasEnv.packages.packagesWithDatabaseObjects[0]).toBe withModels
|