Foundry376/Mailspring
1
1
Fork 0
mirror of https://github.com/Foundry376/Mailspring.git synced 2024-09-24 09:16:07 +08:00
Code Issues Packages Projects Releases Wiki Activity
Mailspring/internal_packages/onboarding/lib
History
Drew Regitsky 62fb708797 fix(onboarding): fix error handling for invalid account data from server 
Summary:
Change `addAccountFromJSON` in `AccountStore` to throw an exception when it encounters
invalid data, instead of calling `atom.emitError()`. Just calling `emitError` doesn't
throw an exception, so the code proceeds as if an account has been added. Instead, call
`emitError` from AccountSettingsPage, and display an error message to the user.

Test Plan: manual

Reviewers: bengotow

Reviewed By: bengotow

Subscribers: evan

Differential Revision: https://phab.nylas.com/D2116
2015-10-05 17:31:29 -07:00
..
account-choose-page.cjsx fix(auth): Rename edgehill.token => invitationCode in config 2015-10-05 03:34:11 -07:00
account-settings-page.cjsx fix(onboarding): fix error handling for invalid account data from server 2015-10-05 17:31:29 -07:00
account-types.coffee feat(onboarding): add hotmail as a provider 2015-10-02 16:12:08 -07:00
initial-packages-page.cjsx fix(onboarding): Packages => plugins, at least in the text 2015-10-05 02:07:10 -07:00
initial-packages-store.coffee fix(install-package): Point to the examples directory by default 2015-10-03 19:31:31 -07:00
initial-preferences-page.cjsx feat(post-auth): Initial prefs + packages screens, welcome copy changes 2015-09-29 23:58:30 -07:00
main.cjsx fix(initial-packages): Pull from examples directory, include in ci builds 2015-09-30 11:43:06 -07:00
nylas-api-environment-store.coffee switch(env): Move N1 to Nylas production API 2015-10-02 15:01:31 -07:00
onboarding-actions.coffee fix(onboarding): Invitation code system, just in case 2015-10-04 16:49:41 -07:00
page-router-store.coffee disable(events): Turn off the events package until it can be polished 2015-10-04 16:57:43 -07:00
page-router.cjsx fix(onboarding): Invitation code system, just in case 2015-10-04 16:49:41 -07:00
token-auth-api.coffee fix(onboarding): Invitation code system, just in case 2015-10-04 16:49:41 -07:00
token-auth-page.cjsx fix(auth): Rename edgehill.token => invitationCode in config 2015-10-05 03:34:11 -07:00
welcome-page.cjsx fix(onboarding): Packages => plugins, at least in the text 2015-10-05 02:07:10 -07:00