918090a4e1
Summary:
The goal is to let us see what plugins are throwing errors on Sentry.
We are using a Sentry `tag` to identify and group plugins and their
errors.
Along the way, I cleaned up the error catching and reporting system. There
was a lot of duplicate error logic (that wasn't always right) and some
legacy Atom error handling.
Now, if you catch an error that we should report (like when handling
extensions), call `NylasEnv.reportError`. This used to be called
`emitError` but I changed it to `reportError` to be consistent with the
ErrorReporter and be a bit more indicative of what it does.
In the production version, the `ErrorLogger` will forward the request to
the `nylas-private-error-reporter` which will report to Sentry.
The `reportError` function also now inspects the stack to determine which
plugin(s) it came from. These are passed along to Sentry.
I also cleaned up the `console.log` and `console.error` code. We were
logging errors multiple times making the console confusing to read. Worse
is that we were logging the `error` object, which would print not the
stack of the actual error, but rather the stack of where the console.error
was logged from. Printing `error.stack` instead shows much more accurate
stack traces.
See changes in the Edgehill repo here:
|
||
---|---|---|
.. | ||
fixtures | ||
helpers | ||
jasmine | ||
clean-app-boot-spec.es6 | ||
contenteditable-integration-spec.es6 | ||
logged-in-app-boot-spec.es6 | ||
package.json | ||
README.md |
Integration Testing
In addition to unit tests, we run integration tests using ChromeDriver and WebdriverIO through the Spectron library.
Running Tests
script/grunt run-integration-tests
This command will, in order:
- Run
npm test
in the/spec_integration
directory and pass in theNYLAS_ROOT_PATH
- Boot
jasmine
and load all files ending in-spec
- Most tests in
beforeAll
will boot N1 via theN1Launcher
. Seespec_integration/helpers/n1-launcher.es6
- This instantiates a new
spectron
Application
which will spawn aChromeDriver
process with the appropriate N1 launch args. ChromeDriver
will then boot a Selenium server athttp://localhost:9515
- The ChromeDriver / Selenium server will boot N1 with testing hooks and expose an controlling API.
- The API is made easily available through the Spectron API
- The
N1Launcher
'smainWindowReady
orpopoutComposerWindowReady
oronboardingWindowReady
methods poll the app until the designated window is available and loaded. Then will resolve a Promise once everything has booted.
Writing Tests
The Spectron API is a pure extension over the Webdriver API. Reference both to write tests.
Most of the methods on app.client
object apply to the "currently
focused" window only. Since N1 has several windows (many of which are
hidden) the N1Launcher
extension will cycle through windows
automatically until it finds the one you want, and then select it.
Furthermore, "loaded" in the pure Spectron sense is only once the window
is booted. N1 windows take much longer to full finish loading packages and
rendering the UI. The N1Launcher::windowReady
method and its derivatives
take this into account.
You will almost always need the minimal boilerplate for each integration test:
describe('My test', () => {
beforeAll((done)=>{
// Boot in dev mode with no arguments
this.app = new N1Launcher(["--dev"]);
this.app.mainWindowReady().finally(done);
});
afterAll((done)=> {
if (this.app && this.app.isRunning()) {
this.app.stop().finally(done);
} else {
done()
}
});
it("is a test you'll write", () => {
});
it("is an async test you'll write", (done) => {
doSomething.finally(done)
});
});
Executing Code in N1's environment
The app.client.execute
and app.client.executeAsync
methods are
extremely helpful when running code in N1. Those are documented slightly
more on the WebdriveIO API docs page here
it("is a test you'll write", () => {
this.app.client.execute((arg1)=>{
// NOTE: `arg1` just got passed in over a JSON api. It can only be a
// primitive data type
// I'M RUNNING IN N1
return someValue
}, arg1).then(({value})=>{
// NOTE: the return is stuffed in an attribute called `value`. Also it
// passed back of a JSON API and can only be a primitive value.
})
});
Debugging tests.
Debugging is through lots of console.log
ing.
There is code is spec_integration/jasmine/bootstrap.js
that attempts to
catch unhandled Promises and color them accordingly.
If you want to access logs from within N1 via the app.client.execute
blocks, you'll have to either package it up yourself and return it, or use
the new app.client.getMainProcessLogs()
just added into Spectron.