mirror of
https://github.com/Foundry376/Mailspring.git
synced 2025-02-28 18:14:08 +08:00
Summary: This error is can flood Sentry pretty badly: https://sentry.io/nylas/nylas-mail/issues/230629801/ My initial thought was to rate limit it, but rate limiting wouldn't do any good because when we get that error we destroy the databases and restart the app, and we will loose the in-memory rate limiting data. The real fix, and reason why Sentry is being flooded with this error by a single user, is that once you encounter this error the app will enter a restart loop that constantly throws this error. The reason being that we weren't properly awaiting for the K2 account databases to be dropped before closing the app, so on restart, the database would still be malformed. The fix is to properly `await` for the database drops Test Plan: manual Reviewers: spang, mark, halla, evan Reviewed By: evan Differential Revision: https://phab.nylas.com/D4127 |
||
---|---|---|
.. | ||
client-app | ||
client-sync | ||
isomorphic-core | ||
README.md |
Monorepo Packages
Each folder here is designed to act as its own repository. For development convenience, they are all included here in one monorepo. This allows us to grep across multiple codebases, not use submodules, and keep a unified commit history.
We use Lerna to manage the monorepo and tie
them all together with the main nylas-mail-all/scripts/postinstall.es6
script,
which in turn, calls lerna bootstrap