Mailspring/spec/components
Evan Morikawa d1c587a01c fix(spec): add support for async specs and disable misbehaving ones
More spec fixes

replace process.nextTick with setTimeout(fn, 0) for specs

Also added an unspy in the afterEach

Temporarily disable specs

fix(spec): start fixing specs

Summary:
This is the WIP fix to our spec runner.

Several tests have been completely commented out that will require
substantially more work to fix. These have been added to our sprint
backlog.

Other tests have been fixed to update to new APIs or to deal with genuine
bugs that were introduced without our knowing!

The most common non-trivial change relates to observing the `NylasAPI` and
`NylasAPIRequest`. We used to observe the arguments to `makeRequest`.
Unfortunately `NylasAPIRequest.run` is argumentless. Instead you can do:
`NylasAPIRequest.prototype.run.mostRecentCall.object.options` to get the
`options` passed into the object. the `.object` property grabs the context
of the spy when it was last called.

Fixing these tests uncovered several concerning issues with our test
runner. I spent a while tracking down why our participant-text-field-spec
was failling every so often. I chose that spec because it was the first
spec to likely fail, thereby requiring looking at the least number of
preceding files. I tried binary searching, turning on and off, several
files beforehand only to realize that the failure rate was not determined
by a particular preceding test, but rather the existing and quantity of
preceding tests, AND the number of console.log statements I had. There is
some processor-dependent race condition going on that needs further
investigation.

I also discovered an issue with the file-download-spec. We were getting
errors about it accessing a file, which was very suspicious given the code
stubs out all fs access. This was caused due to a spec that called an
async function outside ot a `waitsForPromise` block or a `waitsFor` block.
The test completed, the spies were cleaned up, but the downstream async
chain was still running. By the time the async chain finished the runner
was already working on the next spec and the spies had been restored
(causing the real fs access to run).

Juan had an idea to kill the specs once one fails to prevent cascading
failures. I'll implement this in the next diff update

Test Plan: npm test

Reviewers: juan, halla, jackie

Differential Revision: https://phab.nylas.com/D3501

Disable other specs

Disable more broken specs

All specs turned off till passing state

Use async-safe versions of spec functions

Add async test spec

Remove unused package code

Remove canary spec
2016-12-15 13:02:00 -05:00
..
nylas-calendar lint(*): Bump to ESLint 3.8 2016-10-17 18:07:35 -07:00
table fix(mail-merge): Skip row in table data if its empty 2016-07-28 14:05:51 -07:00
blockquote-manager-spec.es6 fix(lint): update files to for new linter version 2016-11-15 10:20:39 -08:00
clipboard-service-spec.coffee es6(composer): Composer extensions => ES2016 2016-10-27 17:28:36 -07:00
contenteditable-component-spec.cjsx bump(react): 0.13.2 => 0.14.7 2016-03-29 01:43:12 -07:00
date-input-spec.jsx fix(specs): Fix date input specs 2016-10-27 11:35:37 -07:00
date-picker-popover-spec.jsx fix(specs): Fix remaining broken specs 2016-10-27 11:44:19 -07:00
editable-list-spec.jsx lint(*): Bump to ESLint 3.8 2016-10-17 18:07:35 -07:00
editable-table-spec.jsx fix(build): Fix linter errors 2016-05-11 16:38:30 -07:00
evented-iframe-spec.cjsx fix(frame): fix link clicking in iframes 2016-04-25 17:30:30 -07:00
fixed-popover-spec.jsx fix(lint): Correct more linter errors 2016-05-06 14:10:28 -07:00
injected-component-set-spec.jsx lint(*): Bump to ESLint 3.8 2016-10-17 18:07:35 -07:00
multiselect-dropdown-spec.jsx fix(specs): Fix tests that were console.logging, bump coffee-react 2016-09-20 15:17:48 -07:00
multiselect-list-interaction-handler-spec.coffee es6(*): Actions, ConfigSchema => ES2016 2016-10-27 18:48:33 -07:00
multiselect-split-interaction-handler-spec.coffee es6(*): Actions, ConfigSchema => ES2016 2016-10-27 18:48:33 -07:00
participants-text-field-spec.jsx fix(spec): add support for async specs and disable misbehaving ones 2016-12-15 13:02:00 -05:00
selectable-table-spec.jsx fix(build): Fix linter errors 2016-05-11 16:38:30 -07:00
tokenizing-text-field-spec.cjsx feat(tokens): Multi-select for tokenized text fields 2016-10-26 13:58:57 -07:00