mirror of
https://github.com/Foundry376/Mailspring.git
synced 2025-09-07 13:14:47 +08:00
590b17ae6f
Summary: Most of the times when removing a sync worker (i.e. when removing an account), we would see database errors in the console. This happened because more often than not we would interrupt in the middle of message processing, but `processMessage` is not interruptible, which means that the worker would be interrupted right after processing its current message. However, if `processMessage` would take more than 500ms (the current timeout for stopping the worker), we would destroy the database before processing was done and it would throw a bunch of errors. To fix this, we just don't set a timeout when removing the worker as a consequence of removing an account. However, when we are removing the worker when we detect that it is stuck, we set a time out of 5 seconds. Test Plan: manually test removing accounts, verify that it doesn't error Reviewers: mark, halla, evan Reviewed By: halla, evan Differential Revision: https://phab.nylas.com/D4308 |
||
|---|---|---|
| .. | ||
| client-app | ||
| client-sync | ||
| isomorphic-core | ||
| README.md | ||
Monorepo Packages
Each folder here is designed to act as its own repository. For development convenience, they are all included here in one monorepo. This allows us to grep across multiple codebases, not use submodules, and keep a unified commit history.
We use Lerna to manage the monorepo and tie
them all together with the main nylas-mail-all/scripts/postinstall.es6 script,
which in turn, calls lerna bootstrap