mirror of
https://github.com/Foundry376/Mailspring.git
synced 2024-11-11 18:32:20 +08:00
5c8915f144
Summary: The unapply transformation was incorrectly passing the props parameter to buildAnchorTag() as a string, even though it expects an object. buildAnchorTag() goes on to stringify this parameter, which causes extra surrounding quotations and escape slashes in front of all the other quotations. The unapply transform is applied on several re-renders, which causes the number of escape characters to unboundedly increase. Firstly, this was causing inline images to not appear properly in the draft, and secondly, the large number of escape characters was making the draft body large enough to make the app unresponsive. This generally wasn't an issue because the unapply transformation is only applied when there has been an apply transformation, and this is triggered by the SyncbackDraftTask. This task was previously only queued upon send, in which case the user never re-opens the draft. Now, enabling send-later on a draft will queue the task, and these issues appear if the user re-opens the draft for editing. This diff makes it so that the unapply transform passes in the props as an object, like the buildAnchorTag function expects. Test Plan: manual Reviewers: evan, juan Reviewed By: evan, juan Differential Revision: https://phab.nylas.com/D4348 |
||
|---|---|---|
| .. | ||
| client-app | ||
| client-sync | ||
| isomorphic-core | ||
| README.md | ||
Monorepo Packages
Each folder here is designed to act as its own repository. For development convenience, they are all included here in one monorepo. This allows us to grep across multiple codebases, not use submodules, and keep a unified commit history.
We use Lerna to manage the monorepo and tie
them all together with the main nylas-mail-all/scripts/postinstall.es6 script,
which in turn, calls lerna bootstrap