Mailspring/internal_packages/message-list
Ben Gotow a8a0154c44 fix(MessageContainer): Fix state, prevent from getting different messages. #1175
Summary:
This fixes a serious issue where drafts could appear to be sending if
they were located in the same index of the message list as a draft which was
previously sending.

Under the hood this was due to two bad programming choices:

1) State based on props in MessageContainer requires correct implementation of
   componentWillReceiveProps. This is definitely an anti-pattern.

2) Using item index rather than clientId as the key for items in the MessageList
   caused containers to be given a different message prop when one was inserted,
   rather than just shifting the existing ones down and inserting a new one.

Test Plan: Not sure how to test this really...

Reviewers: drew, juan

Differential Revision: https://phab.nylas.com/D2673
2016-03-03 12:10:03 -08:00
..
lib fix(MessageContainer): Fix state, prevent from getting different messages. #1175 2016-03-03 12:10:03 -08:00
spec fix(tracking): fix link tracking and read receipt plugins 2016-02-24 12:30:12 -08:00
stylesheets feat(find-in-thread): add the ability to find in a thread 2016-03-02 14:46:27 -08:00
.gitignore fix(drafts): Various improvements and fixes to drafts, draft state management 2015-02-03 16:24:31 -08:00
package.json fix(license): GPLv3 => GPL-3.0 2015-12-07 10:50:47 -08:00