mirror of
https://github.com/Foundry376/Mailspring.git
synced 2024-09-23 00:36:50 +08:00
7452705c31
Summary: Up until now, we've been requiring that every plugin control in the composer take the draftClientId, retreive the session, listen to it, build state from the draft, etc. This is a huge pain and is hard to explain to newcomers becaus it frankly makes no sense. In 0.3.45 we made it so that the ComposerView always has a non-null draft and session. (It isn't rendered until they're available). In this diff, I just pass those through to all the plugins and remove all the session retrieval cruft. Almost none of the buttons have state of their own, which I think is appropriate. They do render on every keystroke, but they were already running code (to recompute their state) on each keystroke and profiling suggests this has no impact. Prepare for immutable In preparation for Immutable models, make the draft store proxy returns a !== draft if any changes have been made. This means you can safely know that a draft has changed if `props.draft !== nextProps.draft` Test Plan: Run tests Reviewers: juan, evan Reviewed By: juan, evan Differential Revision: https://phab.nylas.com/D2902 |
||
|---|---|---|
| .. | ||
| account-store-spec.coffee | ||
| badge-store-spec.coffee | ||
| category-store-spec.es6 | ||
| contact-store-spec.coffee | ||
| database-setup-query-builder-spec.coffee | ||
| database-store-spec.coffee | ||
| database-transaction-spec.coffee | ||
| draft-factory-spec.es6 | ||
| draft-store-proxy-spec.coffee | ||
| draft-store-spec.es6 | ||
| file-download-store-spec.coffee | ||
| file-upload-store-spec.coffee | ||
| focused-contacts-store-spec.coffee | ||
| focused-content-store-spec.coffee | ||
| focused-perspective-store-spec.coffee | ||
| message-store-spec.coffee | ||
| nylas-sync-status-store-spec.es6 | ||
| task-queue-spec.coffee | ||