mirror of
https://github.com/Foundry376/Mailspring.git
synced 2024-09-22 16:26:08 +08:00
787e13a0d2
Summary: This greatly refactors the NylasAPIRequest object to be more single purpose, easier to read, async-ified. It also fixes issues where long stack traces weren't being reported bcause `reportError` was being called before the error had time to make it through Bluebird's rejection handler (which adds back in the long stack traces). This also fixes an issue where ignorable errors (like 404s, ESOCKETTIMEDOUT) were being reporting to Sentry. This also fixes subtle conditions where the request run would throw mixed error types (sometimes regular `Error`s, sometimes `APIError`s). The old class used to handle logging people out on 401s. This is now moved to the AccountStore in a different diff. We've also deprecated the `returnsModel` param in a separate diff. This deprecates the `PriorityUICoordinator` since we no longer need to worry about frequently making expensive API requests to pull down data like we used to in the old cloud-based API. This deprecates `ensureOnce` param in a separate diff. Test Plan: Manually boot app. Check regular 404s don't throw. Check requests get through. Check special ESOCKETTIMEDOUT type errors are properly handled Reviewers: juan, spang, halla Reviewed By: halla Differential Revision: https://phab.nylas.com/D4057 |
||
|---|---|---|
| .. | ||
| client-app | ||
| client-sync | ||
| isomorphic-core | ||
| README.md | ||
Monorepo Packages
Each folder here is designed to act as its own repository. For development convenience, they are all included here in one monorepo. This allows us to grep across multiple codebases, not use submodules, and keep a unified commit history.
We use Lerna to manage the monorepo and tie
them all together with the main nylas-mail-all/scripts/postinstall.es6 script,
which in turn, calls lerna bootstrap