mirror of
https://github.com/Foundry376/Mailspring.git
synced 2024-09-22 08:16:09 +08:00
c251884eaa
Summary: After importing an uneven csv (not all rows have the same number of columns e.g. rows: [[1,2][3,4,5]]), deleting the last column would improperly delete data in rows with fewer columns. This is because we were slicing each row based on row.length - 1 which is not the same for all rows. Fixed this by creating a new variable newNumColumns which is columns.length - 1. Test Plan: Added new test data with uneven data and added a test in table-data-source-spec for removeLastColumn on this uneven set. Reviewers: juan Reviewed By: juan Subscribers: juan Differential Revision: https://phab.nylas.com/D3133 |
||
|---|---|---|
| .. | ||
| nylas-calendar | ||
| table | ||
| blockquote-manager-spec.coffee | ||
| clipboard-service-spec.coffee | ||
| contenteditable-component-spec.cjsx | ||
| date-input-spec.jsx | ||
| editable-list-spec.jsx | ||
| editable-table-spec.jsx | ||
| evented-iframe-spec.cjsx | ||
| fixed-popover-spec.jsx | ||
| injected-component-set-spec.jsx | ||
| multiselect-dropdown-spec.jsx | ||
| multiselect-list-interaction-handler-spec.coffee | ||
| multiselect-split-interaction-handler-spec.coffee | ||
| participants-text-field-spec.cjsx | ||
| selectable-table-spec.jsx | ||
| tokenizing-text-field-spec.cjsx | ||