Mailspring/internal_packages
Ben Gotow 9099542643 fix(quoted-text): div vs blockquote, signature cleanup #1746
Summary:
Previously we always created <blockquote class="gmail_quote"> to wrap quoted text. This is not correct.
Gmail uses blockquotes only when it wants visual indentation, and <div>s to wrap other quoted text, like forwarded
messages which are not displayed indented.

This diff updates N1 to match Gmail exactly. Note that for replies, Gmail actually nests a blockquote.gmail_quote
inside a div.gmail_quote.

I also updated signature handling because it turns out the regexp that was removing existing signatures would blow
away any and all divs until it reached a <blockquote> tag.

Test Plan: See updated specs. Manually tested by creating a thread in Google Inbox and then performing fwd and reply in both N1 and Inbox. Results match.

Reviewers: juan, evan

Reviewed By: evan

Differential Revision: https://phab.nylas.com/D2750
2016-03-17 13:11:00 -07:00
..
account-error-header
account-sidebar
attachments
category-picker
composer fix(quoted-text): div vs blockquote, signature cleanup #1746 2016-03-17 13:11:00 -07:00
composer-emoji sp(composer-emoji): Correct emojis to emoji 2016-03-15 13:37:54 -07:00
composer-signature fix(quoted-text): div vs blockquote, signature cleanup #1746 2016-03-17 13:11:00 -07:00
composer-spellcheck fix(syncback): Bidirectional transforms, ready-to-send saved state 2016-03-16 19:27:12 -07:00
composer-templates fix(quoted-text): div vs blockquote, signature cleanup #1746 2016-03-17 13:11:00 -07:00
composer-translate
events
github-contact-card
link-tracking fix(syncback): Bidirectional transforms, ready-to-send saved state 2016-03-16 19:27:12 -07:00
message-autoload-images
message-list
message-view-on-github
mode-switch
notification-mailto
notification-update-available
notifications
onboarding
open-tracking fix(syncback): Bidirectional transforms, ready-to-send saved state 2016-03-16 19:27:12 -07:00
participant-profile
personal-level-indicators
phishing-detection
plugins
preferences
print
quick-schedule fix(quoted-text): div vs blockquote, signature cleanup #1746 2016-03-17 13:11:00 -07:00
screenshot-mode
search-bar
send-and-archive
send-later fix(lint): Actions is defined but never used 2016-03-16 20:04:01 -07:00
sidebar-fullcontact
system-tray fix(focus): Show drafts in unfocused state when window is blurred 2016-03-15 12:12:30 -07:00
theme-picker
thread-list fix(syncback): Bidirectional transforms, ready-to-send saved state 2016-03-16 19:27:12 -07:00
thread-snooze
ui-dark
ui-darkside
ui-light
ui-taiga
ui-ubuntu
undo-redo
unread-notifications
worker-sync
worker-ui fix(syncback): Bidirectional transforms, ready-to-send saved state 2016-03-16 19:27:12 -07:00