Mailspring/internal_packages/composer-templates/lib/template-picker.jsx
Ben Gotow b4434f6617 fix(focus): Remove focusedField in favor of imperative focus, break apart ComposerView
Summary:
- Removes controlled focus in the composer!
  - No React components ever perfom focus in lifecycle methods. Never again.
  - A new `Utils.schedule({action, after, timeout})` helper makes it easy to say "setState or load draft, etc. and then focus"
  - The DraftStore issues a focusDraft action after creating a draft, which causes the MessageList to focus and scroll to the desired composer, which itself decides which field to focus.
  - The MessageList never focuses anything automatically.
- Refactors ComposerView apart — ComposerHeader handles all top fields, DraftSessionContainer handles draft session initialization and exposes props to ComposerView
  - ComposerHeader now uses a KeyCommandRegion (with focusIn and focusOut) to do the expanding and collapsing of the participants fields. May rename that container very soon.
- Removes all CommandRegistry handling of tab and shift-tab. Unless you preventDefault, the browser does it's thing.
- Removes all tabIndexes greater than 1. This is an anti-pattern—assigning everything a tabIndex of 0 tells the browser to move between them based on their order in the DOM, and is almost always what you want.
- Adds "TabGroupRegion" which allows you to create a tab/shift-tabbing group, (so tabbing does not leave the active composer). Can't believe this isn't a browser feature.

Todos:
- Occasionally, clicking out of the composer contenteditable requires two clicks. This is because atomicEdit is restoring selection within the contenteditable and breaking blur.
- Because the ComposerView does not render until it has a draft, we're back to it being white in popout composers for a brief moment. We will fix this another way - all the "return unless draft" statements were untenable.
- Clicking a row in the thread list no longer shifts focus to the message list and focuses the last draft. This will be restored soon.

Test Plan: Broken

Reviewers: juan, evan

Reviewed By: juan, evan

Differential Revision: https://phab.nylas.com/D2814
2016-04-04 15:22:01 -07:00

117 lines
3 KiB
JavaScript

import {Actions, React, ReactDOM} from 'nylas-exports';
import {Menu, RetinaImg} from 'nylas-component-kit';
import TemplateStore from './template-store';
class TemplatePicker extends React.Component {
static displayName = 'TemplatePicker';
static propTypes = {
draftClientId: React.PropTypes.string,
};
constructor() {
super();
this.state = {
searchValue: '',
templates: TemplateStore.items(),
};
}
componentDidMount() {
this.unsubscribe = TemplateStore.listen(this._onStoreChange.bind(this));
}
componentWillUnmount() {
if (this.unsubscribe) this.unsubscribe();
}
_filteredTemplates(search = this.state.searchValue) {
const items = TemplateStore.items();
if (!search.length) { return items; }
return items.filter((t)=> {
return t.name.toLowerCase().indexOf(search.toLowerCase()) === 0;
});
}
_onStoreChange() {
return this.setState({
templates: this._filteredTemplates(),
});
}
_onSearchValueChange = () => {
const newSearch = event.target.value;
return this.setState({
searchValue: newSearch,
templates: this._filteredTemplates(newSearch),
});
};
_onChooseTemplate = (template) => {
Actions.insertTemplateId({templateId: template.id, draftClientId: this.props.draftClientId});
Actions.closePopover()
};
_onManageTemplates = () => {
Actions.showTemplates();
};
_onNewTemplate = () => {
Actions.createTemplate({draftClientId: this.props.draftClientId});
};
_onClickButton = ()=> {
const buttonRect = ReactDOM.findDOMNode(this).getBoundingClientRect()
Actions.openPopover(
this._renderPopover(),
{originRect: buttonRect, direction: 'up'}
)
};
_renderPopover() {
const headerComponents = [
<input
type="text"
tabIndex="1"
key="textfield"
className="search"
value={this.state.searchValue}
onChange={this._onSearchValueChange} />,
];
const footerComponents = [
<div className="item" key="new" onMouseDown={this._onNewTemplate}>Save Draft as Template...</div>,
<div className="item" key="manage" onMouseDown={this._onManageTemplates}>Manage Templates...</div>,
];
return (
<Menu
className="template-picker"
headerComponents={headerComponents}
footerComponents={footerComponents}
items={this.state.templates}
itemKey={ (item)=> item.id }
itemContent={ (item)=> item.name }
onSelect={this._onChooseTemplate.bind(this)}
/>
);
}
render() {
return (
<button
tabIndex={-1}
className="btn btn-toolbar narrow pull-right"
onClick={this._onClickButton}
title="Insert email template…">
<RetinaImg url="nylas://composer-templates/assets/icon-composer-templates@2x.png" mode={RetinaImg.Mode.ContentIsMask}/>
&nbsp;
<RetinaImg name="icon-composer-dropdown.png" mode={RetinaImg.Mode.ContentIsMask}/>
</button>
);
}
}
export default TemplatePicker;