Foundry376/Mailspring
1
1
Fork 0
mirror of https://github.com/Foundry376/Mailspring.git synced 2024-09-22 16:26:08 +08:00
Code Issues Packages Projects Releases Wiki Activity
Mailspring/spec
History
Evan Morikawa 31ae05fed2 fix(identity): remove the savePromise and optimistically update 
Summary:
Fixes T7832

The _savePromise mechanism of the IdentityStore was really cumbersome and
was throwing errors on the console for people. In hindsight, this is an
unnecessary complication to a very sensitive system and a source of very
hairy async bugs.

Test Plan:
I also updated the specs to ensure that when you call saveIdentity the
promise resolves after the local cache has been updated

Reviewers: spang, halla, juan

Reviewed By: juan

Maniphest Tasks: T7832

Differential Revision: https://phab.nylas.com/D3882
2017-02-10 15:52:57 -05:00
..
components fix(specs) Use shallow rendering 2017-02-10 12:19:38 -08:00
fixtures 🎨(rename): Update Nylas N1 to Nylas Mail 2017-01-12 12:05:44 -08:00
models fix(specs): fix more tests 2017-02-09 18:29:30 -05:00
n1-spec-runner fix(specs) Fix Spellchecker tests 2017-02-10 12:36:07 -08:00
registries refactor(registry): move all registries into src/registries 2016-11-14 14:01:00 -08:00
services fix(rendering): Fix quote stripping of many plaintext emails 2016-12-15 18:40:34 -08:00
stores fix(identity): remove the savePromise and optimistically update 2017-02-10 15:52:57 -05:00
tasks fix(tasks) ChangeMailTask should depend on EnsureMessagesInSentFolder 2017-01-27 14:02:50 -08:00
themes fix(specs) fix specs logging erroneous error messages 2017-02-09 17:51:43 -05:00
utils fix(specs): fix util specs 2017-02-09 19:05:19 -05:00
action-bridge-spec.coffee perf(sync): don't send message bodies across IPC & limit global IPC 2017-01-16 10:28:49 -08:00
async-test-spec.es6 fix(spec): add support for async specs and disable misbehaving ones 2016-12-15 13:02:00 -05:00
auto-update-manager-spec.coffee fix(specs) Fix AutoUpdateManager specs 2017-02-09 13:29:50 -08:00
buffered-process-spec.coffee refactor(spec) move spec-nylas to spec 2015-10-01 21:39:44 -07:00
database-object-registry-spec.es6 refactor(registry): move all registries into src/registries 2016-11-14 14:01:00 -08:00
default-client-helper-spec.coffee feat(win32): Allow N1 to become the system-wide mailto: handler 2016-10-12 16:05:36 -07:00
list-selection-spec.coffee fix(specs): Add regression test for list-selection 2016-11-02 11:46:28 -07:00
mail-rules-processor-spec.coffee fix(spec): add support for async specs and disable misbehaving ones 2016-12-15 13:02:00 -05:00
mailbox-perspective-spec.es6 lint(*): Bump to ESLint 3.8 2016-10-17 18:07:35 -07:00
menu-manager-spec.coffee es6(*): Misc src to ES2016 2016-10-27 12:08:59 -07:00
module-cache-spec.coffee fix(specs): Update specs following 0.29.2 > 0.34.3 move 2015-11-17 17:40:06 -08:00
nylas-api-spec.coffee fix(spec): add support for async specs and disable misbehaving ones 2016-12-15 13:02:00 -05:00
nylas-env-spec.es6 fix(spec): add support for async specs and disable misbehaving ones 2016-12-15 13:02:00 -05:00
nylas-protocol-handler-spec.es6 fix(specs) convert nylas-protocol-handler-spec to ES6 (#2886) 2016-10-12 11:38:30 -07:00
nylas-test-utils.coffee cson(cleanup): Remove imports, only used for config.cson now 2016-04-24 20:33:34 -05:00
package-manager-spec.coffee fix(spec): fix package manager spec 2017-02-09 15:17:58 -05:00
package-spec.coffee cleanup(specs): Remove space-pen. Goodbye, jQuery! 2016-04-26 13:14:07 -07:00
spellchecker-spec.es6 fix(specs) Fix Spellchecker tests 2017-02-10 12:36:07 -08:00
undo-stack-spec.es6 lint(*): Bump to ESLint 3.8 2016-10-17 18:07:35 -07:00