mirror of
https://github.com/Foundry376/Mailspring.git
synced 2024-09-24 01:06:07 +08:00
3eba41b8d8
Summary: Fixes T3510 Fixes T3509 Fixes T3508 Fixes T3549 Extracted clipboard service Remove unused style prop Begin extracting quoted text from composer. Spec for clipboard service Fix contenteditable specs Begin to extract floating toolbar Extract out DOMUtils and further extract floating toolbar Further extracting domutils and floating toolbar composer floating toolbar extracted Fixes to hover and link states Collapse adjacent ul lists Fix outdent when deleting on a bulleted list Fix bullet controls Fixes to list creation and deletion Add underline keyboard shortcut Test Plan: manual :( Reviewers: dillon, bengotow Reviewed By: bengotow Maniphest Tasks: T3508, T3509, T3510, T3549 Differential Revision: https://phab.nylas.com/D2036
168 lines
7.2 KiB
CoffeeScript
168 lines
7.2 KiB
CoffeeScript
ClipboardService = require '../lib/clipboard-service'
|
|
|
|
describe "ClipboardService", ->
|
|
beforeEach ->
|
|
@onFilePaste = jasmine.createSpy('onFilePaste')
|
|
@clipboardService = new ClipboardService
|
|
|
|
describe "when html and plain text parts are present", ->
|
|
beforeEach ->
|
|
@mockEvent =
|
|
preventDefault: jasmine.createSpy('preventDefault')
|
|
clipboardData:
|
|
getData: ->
|
|
return '<strong>This is text</strong>' if 'text/html'
|
|
return 'This is plain text' if 'text/plain'
|
|
return null
|
|
items: [{
|
|
kind: 'string'
|
|
type: 'text/html'
|
|
getAsString: -> '<strong>This is text</strong>'
|
|
},{
|
|
kind: 'string'
|
|
type: 'text/plain'
|
|
getAsString: -> 'This is plain text'
|
|
}]
|
|
|
|
it "should sanitize the HTML string and call insertHTML", ->
|
|
spyOn(document, 'execCommand')
|
|
spyOn(@clipboardService, '_sanitizeInput').andCallThrough()
|
|
|
|
runs ->
|
|
@clipboardService.onPaste(@mockEvent)
|
|
waitsFor ->
|
|
document.execCommand.callCount > 0
|
|
runs ->
|
|
expect(@clipboardService._sanitizeInput).toHaveBeenCalledWith('<strong>This is text</strong>', 'text/html')
|
|
[command, a, html] = document.execCommand.mostRecentCall.args
|
|
expect(command).toEqual('insertHTML')
|
|
expect(html).toEqual('<strong>This is text</strong>')
|
|
|
|
describe "when html and plain text parts are present", ->
|
|
beforeEach ->
|
|
@mockEvent =
|
|
preventDefault: jasmine.createSpy('preventDefault')
|
|
clipboardData:
|
|
getData: ->
|
|
return 'This is plain text' if 'text/plain'
|
|
return null
|
|
items: [{
|
|
kind: 'string'
|
|
type: 'text/plain'
|
|
getAsString: -> 'This is plain text'
|
|
}]
|
|
|
|
it "should sanitize the plain text string and call insertHTML", ->
|
|
spyOn(document, 'execCommand')
|
|
spyOn(@clipboardService, '_sanitizeInput').andCallThrough()
|
|
|
|
runs ->
|
|
@clipboardService.onPaste(@mockEvent)
|
|
waitsFor ->
|
|
document.execCommand.callCount > 0
|
|
runs ->
|
|
expect(@clipboardService._sanitizeInput).toHaveBeenCalledWith('This is plain text', 'text/html')
|
|
[command, a, html] = document.execCommand.mostRecentCall.args
|
|
expect(command).toEqual('insertHTML')
|
|
expect(html).toEqual('This is plain text')
|
|
|
|
describe "sanitization", ->
|
|
tests = [
|
|
{
|
|
in: ""
|
|
sanitizedAsHTML: ""
|
|
sanitizedAsPlain: ""
|
|
},
|
|
{
|
|
in: "Hello World"
|
|
sanitizedAsHTML: "Hello World"
|
|
sanitizedAsPlain: "Hello World"
|
|
},
|
|
{
|
|
in: " Hello World"
|
|
# Should collapse to 1 space when rendered
|
|
sanitizedAsHTML: " Hello World"
|
|
# Preserving 2 spaces
|
|
sanitizedAsPlain: " Hello World"
|
|
},
|
|
{
|
|
in: " Hello World"
|
|
sanitizedAsHTML: " Hello World"
|
|
# Preserving 3 spaces
|
|
sanitizedAsPlain: " Hello World"
|
|
},
|
|
{
|
|
in: " Hello World"
|
|
sanitizedAsHTML: " Hello World"
|
|
# Preserving 4 spaces
|
|
sanitizedAsPlain: " Hello World"
|
|
},
|
|
{
|
|
in: "Hello\nWorld"
|
|
sanitizedAsHTML: "Hello<br />World"
|
|
# Convert newline to br
|
|
sanitizedAsPlain: "Hello<br/>World"
|
|
},
|
|
{
|
|
in: "Hello\rWorld"
|
|
sanitizedAsHTML: "Hello<br />World"
|
|
# Convert carriage return to br
|
|
sanitizedAsPlain: "Hello<br/>World"
|
|
},
|
|
{
|
|
in: "Hello\n\n\nWorld"
|
|
# Never have more than 2 br's in a row
|
|
sanitizedAsHTML: "Hello<br/><br/>World"
|
|
# Convert multiple newlines to same number of brs
|
|
sanitizedAsPlain: "Hello<br/><br/><br/>World"
|
|
},
|
|
{
|
|
in: "<style>Yo</style> Foo Bar <div>Baz</div>"
|
|
# Strip bad tags
|
|
sanitizedAsHTML: " Foo Bar Baz"
|
|
# HTML encode tags for literal display
|
|
sanitizedAsPlain: "<style>Yo</style> Foo Bar <div>Baz</div>"
|
|
},
|
|
{
|
|
in: "<script>Bah</script> Yo < script>Boo! < / script >"
|
|
# Strip non white-list tags and encode malformed ones.
|
|
sanitizedAsHTML: " Yo < script>Boo! < / script >"
|
|
# HTML encode tags for literal display
|
|
sanitizedAsPlain: "<script>Bah</script> Yo < script>Boo! < / script >"
|
|
},
|
|
{
|
|
in: """
|
|
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">
|
|
<html>
|
|
<head>
|
|
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
|
|
<meta http-equiv="Content-Style-Type" content="text/css">
|
|
<title></title>
|
|
<meta name="Generator" content="Cocoa HTML Writer">
|
|
<meta name="CocoaVersion" content="1265.21">
|
|
<style type="text/css">
|
|
li.li1 {margin: 0.0px 0.0px 0.0px 0.0px; font: 12.0px Helvetica}
|
|
ul.ul1 {list-style-type: disc}
|
|
</style>
|
|
</head>
|
|
<body>
|
|
<ul class="ul1">
|
|
<li class="li1"><b>Packet pickup: </b>I'll pick up my packet at some point on Saturday at Fort Mason. Let me know if you'd like me to get yours. I'll need a photo of your ID and your confirmation number. Also, shirt color preference, I believe. Gray or black? Can't remember...</li>
|
|
</ul>
|
|
</body>
|
|
</html>"""
|
|
# Strip non white-list tags and encode malformed ones.
|
|
sanitizedAsHTML: "<ul><br /><li><b>Packet pickup: </b>I'll pick up my packet at some point on Saturday at Fort Mason. Let me know if you'd like me to get yours. I'll need a photo of your ID and your confirmation number. Also, shirt color preference, I believe. Gray or black? Can't remember...</li><br /></ul>"
|
|
# HTML encode tags for literal display
|
|
sanitizedAsPlain: "<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd"><br/><html><br/><head><br/><meta http-equiv="Content-Type" content="text/html; charset=UTF-8"><br/><meta http-equiv="Content-Style-Type" content="text/css"><br/><title></title><br/><meta name="Generator" content="Cocoa HTML Writer"><br/><meta name="CocoaVersion" content="1265.21"><br/><style type="text/css"><br/>li.li1 {margin: 0.0px 0.0px 0.0px 0.0px; font: 12.0px Helvetica}<br/>ul.ul1 {list-style-type: disc}<br/></style><br/></head><br/><body><br/><ul class="ul1"><br/><li class="li1"><b>Packet pickup: </b>I'll pick up my packet at some point on Saturday at Fort Mason. Let me know if you'd like me to get yours. I'll need a photo of your ID and your confirmation number. Also, shirt color preference, I believe. Gray or black? Can't remember...</li><br/></ul><br/></body><br/></html>"
|
|
}
|
|
]
|
|
|
|
it "sanitizes plain text properly", ->
|
|
for test in tests
|
|
expect(@clipboardService._sanitizeInput(test.in, "text/plain")).toBe test.sanitizedAsPlain
|
|
|
|
it "sanitizes html text properly", ->
|
|
for test in tests
|
|
expect(@clipboardService._sanitizeInput(test.in, "text/html")).toBe test.sanitizedAsHTML
|