Foundry376/Mailspring
1
1
Fork 0
mirror of https://github.com/Foundry376/Mailspring.git synced 2024-11-12 04:02:35 +08:00
Code Issues Projects Releases Packages Wiki Activity
Mailspring/internal_packages/open-tracking
History
Ben Gotow 585dab7cdf refactor(composer): Make session, draft available everywhere 
Summary:
Up until now, we've been requiring that every plugin control in the composer take the draftClientId, retreive the session, listen to it, build state from the draft, etc. This is a huge pain and is hard to explain to newcomers becaus it frankly makes no sense.

In 0.3.45 we made it so that the ComposerView always has a non-null draft and session. (It isn't rendered until they're available). In this diff, I just pass those through to all the plugins and remove all the session retrieval cruft.

Almost none of the buttons have state of their own, which I think is appropriate.

They do render on every keystroke, but they were already running code (to recompute their state) on each keystroke and profiling suggests this has no impact.

Prepare for immutable

In preparation for Immutable models, make the draft store proxy returns a !== draft if any changes have been made. This means you can safely know that a draft has changed if `props.draft !== nextProps.draft`

Test Plan: Run tests

Reviewers: juan, evan

Reviewed By: juan, evan

Differential Revision: https://phab.nylas.com/D2902
2016-04-19 16:05:15 -07:00
..
assets fix(plugin): better errors if plugins are malformed 2016-02-25 11:55:11 -08:00
lib refactor(composer): Make session, draft available everywhere 2016-04-19 16:05:15 -07:00
spec feat(calendar): add week view for quick scheduler 2016-04-04 15:05:48 -07:00
stylesheets fix(open-tracking): quick CSS fix to thread list icon 2016-02-24 16:55:17 -08:00
icon.png
package.json fix(plugins): Change server URLs for open/link tracking to final values 2016-02-24 16:29:12 -08:00
README.md

README.md

Open Tracking

Adds tracking pixels to messages and tracks whether they have been opened.