Mailspring/internal_packages
Juan Tejada b223a38b73 fix(mail-merge/preview): Don't unmount components when toggling preview
Summary:
See edgehill revision: https://phab.nylas.com/D3160

- CustomContenteditableComponents.get now takes a single component to register as an overlaid component, and this component will be passed a prop `{isPreview: true}` when it is meant to be rendered as a preview. Update scheduler and mail-merge to use this new api.

- This prevents the mail merge state from being incorrectly updated when we toggled preview mode -- previously, it believed that the tokens had been unmounted when toggling preview, so they were incorrectly removed from the mail merge state.

- Additionally, makes sure that tokens are correctly added to the mail merge state whenever a token is rendered via componentDidMount -- previously, we only added the token to state when a token was dropped on the contenteditable, however, a token might be pasted or an anchor node might be added by any other means, in which case we want the mail merge state to reflect that. (Adds docs about this)

Test Plan: Manual

Reviewers: jackie, evan

Reviewed By: jackie, evan

Differential Revision: https://phab.nylas.com/D3161
2016-08-16 13:21:41 -07:00
..
account-sidebar refactor(folders): Make folders disappear when deleted rather than graying out until confirmed 2016-07-28 12:10:54 -07:00
attachments fix(lint): various linter fixes 2016-05-06 14:11:05 -07:00
category-picker 🎨(signature): Fix signature dropdown styling on different themes 2016-08-01 14:18:13 -07:00
composer fix(mail-merge/preview): Don't unmount components when toggling preview 2016-08-16 13:21:41 -07:00
composer-emoji fix(specs): Fix specs on Linux 2016-06-15 16:30:52 -07:00
composer-signature 🎨(signature): Fix signature dropdown styling on different themes 2016-08-01 14:18:13 -07:00
composer-spellcheck fix(spellchecker): Make sure spellchecker returns selection to its original state 2016-07-28 13:42:53 -07:00
composer-templates fix(templates): fix new templates from draft 2016-06-09 15:21:20 -07:00
composer-translate fix(keybase): Disable by default, remove duplicate dependencies 2016-06-07 14:15:54 -07:00
draft-list Better support 24-hour time (#2622) 2016-07-28 17:42:14 -07:00
events fix(utils): Properly export DateUtils.timeZone, fix specs 2016-08-01 12:41:05 -07:00
github-contact-card fix(plugins): Update plugin descriptions 2016-06-07 16:41:04 -07:00
keybase Auth keybase and clearbit 2016-08-02 16:17:34 -07:00
message-autoload-images fix(lint): final linter fixes 2016-05-06 16:32:34 -07:00
message-list add(composer): Turn emails into mailto for debugging purposes 2016-08-12 16:06:22 -07:00
message-view-on-github fix(github): fix view on Github buttton 2016-06-17 10:07:05 -04:00
mode-switch rm(*): deprecated/unused Atom code, user stylesheet support 2016-05-04 14:27:46 -07:00
notification-mailto Revert "feat(mailto): Allow N1 to be default client on windows" 2016-05-03 19:04:04 -07:00
notification-update-available
notifications fix(identity): Modify language around subscribing 2016-07-26 15:46:50 -07:00
onboarding 🎨(onboarding): Fix clipped gears in onboarding 2016-07-27 20:08:18 -07:00
participant-profile Auth keybase and clearbit 2016-08-02 16:17:34 -07:00
personal-level-indicators fix(keybase): Disable by default, remove duplicate dependencies 2016-06-07 14:15:54 -07:00
phishing-detection fix(phising): Make detection lower case #1784 2016-07-28 18:19:07 -07:00
plugins Update broken links for guides, docs, and API (#2455) 2016-06-15 15:29:52 -07:00
preferences build(preferences): Add two buttons to the bottom of the general preferences page that clear email and clear all .nylas 2016-07-26 16:53:45 -07:00
print fixt(print): Update print header logo 2016-05-11 11:33:12 -07:00
remove-tracking-pixels feat(babel6): fix es6 describe function syntax 2016-05-06 11:55:20 -07:00
screenshot-mode
send-and-archive
system-tray feat(babel6): 1,774 linter errors 2016-05-06 11:55:46 -07:00
theme-picker fix(themes): Add Less is More to list ordering 2016-05-31 14:35:49 -07:00
thread-list Better support 24-hour time (#2622) 2016-07-28 17:42:14 -07:00
thread-search fix(deltas): Consolidate nylas-long-connection code 2016-07-27 02:56:55 -07:00
thread-search-index fix(search): Prevent from adding duplicate threads to the search index 2016-06-07 14:41:39 -07:00
thread-snooze fix(analytics): improved analytics 2016-06-07 13:38:47 -07:00
ui-dark Revert "🎨(ui-dark): Remove iframe inversion" 2016-05-25 23:46:36 -07:00
ui-darkside 🎨(darkside): Add UI tweaks for activity list 2016-06-09 16:11:27 -07:00
ui-less-is-more fix(lint): fix minor linter issue 2016-05-09 13:42:18 -04:00
ui-light
ui-taiga 🎨(signature): Fix signature dropdown styling on different themes 2016-08-01 14:18:13 -07:00
ui-ubuntu 🎨(ubuntu): Unhide toolbar for popout composer 2016-07-27 19:32:32 -07:00
undo-redo fix(undo): Improve messaging around label changes, modernize undo-redo-store 2016-06-01 14:36:57 -07:00
unread-notifications Clear notifications when emails are read 2016-07-08 11:36:51 -07:00
worker-sync fix(specs): Properly spy on streaming connection 2016-07-28 12:40:31 -07:00
worker-ui fix(env): add remove unload callback for stores 2016-08-05 12:15:39 -07:00