Mailspring/spec
Evan Morikawa 0be186302a refactor(account): remove unused accont refresh methods
Summary:
This removes `refreshHealthOfAccounts`, which I originally found because I
was trying to refactor it out of the IdentityStore. We need it gone from
the IdentityStore so that store can trigger frequently as things like the
usageLimits constantly update on it.

This also fixes T7520 where we'd get `ECONNREFUSED 127.0.0.1:2578` on
launch unnecessarily.

The concept of refreshing the health of accounts by occassionally polling
the /accounts endpoint is obsolete. This depends on
D3769 which entirely removes the /accounts endpoint
from K2.

Account health is pushed to us by `Actions.updateAccount` which is fired
directly from the main local-sync sync loop.

This also removes `refreshAccounts` and `Actions.refreshAllDeltaConnections`. These were fired by the Identity Store whenever it updated. We no longer need the Identity Store to tell us to reset the delta connections with our local-sync accounts. The delta connections will either be reset by our offline notification button, or when adding or removing an account. The Identity Store was a redundant mechanisms

Test Plan:
Manually verify things work with an existing account. Add a new account
and ensure sync starts. Remove an account and ensure it gets cleaned up.

Reviewers: halla, khamidou, mark, juan

Reviewed By: juan

Maniphest Tasks: T7520

Differential Revision: https://phab.nylas.com/D3770
2017-01-25 10:12:09 -05:00
..
components fix(spec): add support for async specs and disable misbehaving ones 2016-12-15 13:02:00 -05:00
fixtures 🎨(rename): Update Nylas N1 to Nylas Mail 2017-01-12 12:05:44 -08:00
models 🎨(rename): Update Nylas N1 to Nylas Mail 2017-01-12 12:05:44 -08:00
n1-spec-runner fix(spec): fix asynchronous specs 2016-12-20 16:47:26 -08:00
registries refactor(registry): move all registries into src/registries 2016-11-14 14:01:00 -08:00
services fix(rendering): Fix quote stripping of many plaintext emails 2016-12-15 18:40:34 -08:00
stores refactor(account): remove unused accont refresh methods 2017-01-25 10:12:09 -05:00
tasks feat(send) 2017-01-04 15:42:19 -08:00
themes rm(grim): We’re not using Grim for deprecations 2016-10-25 11:36:20 -07:00
utils fix(specs) Fix date-utils specs 2016-11-07 12:15:47 -08:00
action-bridge-spec.coffee perf(sync): don't send message bodies across IPC & limit global IPC 2017-01-16 10:28:49 -08:00
async-test-spec.es6 fix(spec): add support for async specs and disable misbehaving ones 2016-12-15 13:02:00 -05:00
auto-update-manager-spec.coffee Fix broken autoupdater, for reals. 2017-01-15 17:06:23 -08:00
buffered-process-spec.coffee refactor(spec) move spec-nylas to spec 2015-10-01 21:39:44 -07:00
database-object-registry-spec.es6 refactor(registry): move all registries into src/registries 2016-11-14 14:01:00 -08:00
default-client-helper-spec.coffee feat(win32): Allow N1 to become the system-wide mailto: handler 2016-10-12 16:05:36 -07:00
list-selection-spec.coffee fix(specs): Add regression test for list-selection 2016-11-02 11:46:28 -07:00
mail-rules-processor-spec.coffee fix(spec): add support for async specs and disable misbehaving ones 2016-12-15 13:02:00 -05:00
mailbox-perspective-spec.es6 lint(*): Bump to ESLint 3.8 2016-10-17 18:07:35 -07:00
menu-manager-spec.coffee es6(*): Misc src to ES2016 2016-10-27 12:08:59 -07:00
module-cache-spec.coffee fix(specs): Update specs following 0.29.2 > 0.34.3 move 2015-11-17 17:40:06 -08:00
nylas-api-spec.coffee fix(spec): add support for async specs and disable misbehaving ones 2016-12-15 13:02:00 -05:00
nylas-env-spec.es6 fix(spec): add support for async specs and disable misbehaving ones 2016-12-15 13:02:00 -05:00
nylas-protocol-handler-spec.es6 fix(specs) convert nylas-protocol-handler-spec to ES6 (#2886) 2016-10-12 11:38:30 -07:00
nylas-test-utils.coffee cson(cleanup): Remove imports, only used for config.cson now 2016-04-24 20:33:34 -05:00
package-manager-spec.coffee fix(spec): add support for async specs and disable misbehaving ones 2016-12-15 13:02:00 -05:00
package-spec.coffee cleanup(specs): Remove space-pen. Goodbye, jQuery! 2016-04-26 13:14:07 -07:00
spellchecker-spec.es6 fix(spec): add support for async specs and disable misbehaving ones 2016-12-15 13:02:00 -05:00
undo-stack-spec.es6 lint(*): Bump to ESLint 3.8 2016-10-17 18:07:35 -07:00