mirror of
https://github.com/Foundry376/Mailspring.git
synced 2024-11-12 04:25:31 +08:00
b4434f6617
Summary:
- Removes controlled focus in the composer!
- No React components ever perfom focus in lifecycle methods. Never again.
- A new `Utils.schedule({action, after, timeout})` helper makes it easy to say "setState or load draft, etc. and then focus"
- The DraftStore issues a focusDraft action after creating a draft, which causes the MessageList to focus and scroll to the desired composer, which itself decides which field to focus.
- The MessageList never focuses anything automatically.
- Refactors ComposerView apart — ComposerHeader handles all top fields, DraftSessionContainer handles draft session initialization and exposes props to ComposerView
- ComposerHeader now uses a KeyCommandRegion (with focusIn and focusOut) to do the expanding and collapsing of the participants fields. May rename that container very soon.
- Removes all CommandRegistry handling of tab and shift-tab. Unless you preventDefault, the browser does it's thing.
- Removes all tabIndexes greater than 1. This is an anti-pattern—assigning everything a tabIndex of 0 tells the browser to move between them based on their order in the DOM, and is almost always what you want.
- Adds "TabGroupRegion" which allows you to create a tab/shift-tabbing group, (so tabbing does not leave the active composer). Can't believe this isn't a browser feature.
Todos:
- Occasionally, clicking out of the composer contenteditable requires two clicks. This is because atomicEdit is restoring selection within the contenteditable and breaking blur.
- Because the ComposerView does not render until it has a draft, we're back to it being white in popout composers for a brief moment. We will fix this another way - all the "return unless draft" statements were untenable.
- Clicking a row in the thread list no longer shifts focus to the message list and focuses the last draft. This will be restored soon.
Test Plan: Broken
Reviewers: juan, evan
Reviewed By: juan, evan
Differential Revision: https://phab.nylas.com/D2814
48 lines
1.4 KiB
JavaScript
48 lines
1.4 KiB
JavaScript
import {DraftStore, React} from 'nylas-exports';
|
|
|
|
export default class MyComposerButton extends React.Component {
|
|
|
|
// Note: You should assign a new displayName to avoid naming
|
|
// conflicts when injecting your item
|
|
static displayName = 'MyComposerButton';
|
|
|
|
// When you register as a composer button, you receive a
|
|
// reference to the draft, and you can look it up to perform
|
|
// actions and retrieve data.
|
|
static propTypes = {
|
|
draftClientId: React.PropTypes.string.isRequired,
|
|
};
|
|
|
|
_onClick = () => {
|
|
// To retrieve information about the draft, we fetch the current editing
|
|
// session from the draft store. We can access attributes of the draft
|
|
// and add changes to the session which will be appear immediately.
|
|
DraftStore.sessionForClientId(this.props.draftClientId).then((session) => {
|
|
const newSubject = `${session.draft().subject} - It Worked!`;
|
|
|
|
const dialog = this._getDialog();
|
|
dialog.showMessageBox({
|
|
title: 'Here we go...',
|
|
detail: `Adjusting the subject line To "${newSubject}"`,
|
|
buttons: ['OK'],
|
|
type: 'info',
|
|
});
|
|
|
|
session.changes.add({subject: newSubject});
|
|
});
|
|
}
|
|
|
|
_getDialog() {
|
|
return require('remote').require('dialog');
|
|
}
|
|
|
|
render() {
|
|
return (
|
|
<div className="my-package">
|
|
<button className="btn btn-toolbar" onClick={() => this._onClick()} ref="button">
|
|
Hello World
|
|
</button>
|
|
</div>
|
|
);
|
|
}
|
|
}
|