Foundry376/Mailspring
1
1
Fork 0
mirror of https://github.com/Foundry376/Mailspring.git synced 2024-09-23 08:46:07 +08:00
Code Issues Packages Projects Releases Wiki Activity
Mailspring/packages/client-app/internal_packages/thread-list/lib
History
Juan Tejada b6a1fc5234 [client-app] Fix measurement of thread-list action metrics 
Summary:
We detect when a thread is removed from the thread-list by listening to
`Actions.threadListDidUpdate`. However, we were not firing the action at
the correct moment.

Before this commit, we fired the action on the root `ThreadList`'s
`componentDidUpdate`, however did this not actually fire when the
child list actually updated/removed threads from the list.

This sort of used to work because before 396a027bcb
the root ThreadList component re-rendered all the time, so it fired the
action, but after initial sync, we would never actually report any
thread-list action metrics at all

Test Plan: manual

Reviewers: spang, halla, evan

Reviewed By: halla, evan

Differential Revision: https://phab.nylas.com/D4051
2017-02-28 14:07:52 -08:00
..
category-removal-target-rulesets.es6 [client-*] Rename packages folders and update readme 2017-02-16 13:31:37 -08:00
injects-toolbar-buttons.jsx [client-*] Rename packages folders and update readme 2017-02-16 13:31:37 -08:00
main.es6 [client-*] Rename packages folders and update readme 2017-02-16 13:31:37 -08:00
message-list-toolbar.jsx [client-*] Rename packages folders and update readme 2017-02-16 13:31:37 -08:00
selected-items-stack.jsx [client-*] Rename packages folders and update readme 2017-02-16 13:31:37 -08:00
thread-list-columns.cjsx [client-*] Rename packages folders and update readme 2017-02-16 13:31:37 -08:00
thread-list-context-menu.es6 [client-app] For consistency, proxy marking unread thru ThreadListActionStore 2017-02-21 12:31:07 -08:00
thread-list-data-source.es6 [client-*] Rename packages folders and update readme 2017-02-16 13:31:37 -08:00
thread-list-icon.cjsx [client-app] For consistency, proxy starring thru ThreadListActionStore 2017-02-21 12:29:52 -08:00
thread-list-participants.cjsx [client-*] Rename packages folders and update readme 2017-02-16 13:31:37 -08:00
thread-list-quick-actions.cjsx [client-app] Measure and report times for trashing and marking as spam 2017-02-21 12:26:58 -08:00
thread-list-scroll-tooltip.cjsx [client-*] Rename packages folders and update readme 2017-02-16 13:31:37 -08:00
thread-list-store.coffee [client-*] Rename packages folders and update readme 2017-02-16 13:31:37 -08:00
thread-list-toolbar.jsx [client-*] Rename packages folders and update readme 2017-02-16 13:31:37 -08:00
thread-list.cjsx [client-app] Fix measurement of thread-list action metrics 2017-02-28 14:07:52 -08:00
thread-toolbar-buttons.jsx [client-app] For consistency, proxy marking unread thru ThreadListActionStore 2017-02-21 12:31:07 -08:00