mirror of
https://github.com/Foundry376/Mailspring.git
synced 2024-09-23 08:46:07 +08:00
b8ed562d19
Summary: The attachment components were the only React Components which used inheritance between components, which is an anti-pattern in react. I deleted these components in favor of new purely functional/dumb components exposed via the component-kit: Attachment Item and ImageAttachmentItem. These are defined in the same file to reuse some smaller components between them, like the progress-bar, etc. The attachments pacakage still remains, and only registers a single component to a new are called MessageAttachments. This InjectedComponent role is shared by the Composer and MessageItem, and is the only reason this exists as an injected component in a separate package. MessageAttachments renders all image and non image attachments for a message or draft, and binds the appropriate actions for removal, downloading, etc. The composer still used FileUpload and ImageUpload components for rendering uploads in the Composer (i.e. when you add an attachment (these are different from files because they aren't saved until the draft is sent)). These 2 components were pretty much copied and pasted from the ones in the attachments package, with subtle differences-- I got rid of these as well in favor of the new AttachmentItem and ImageAttachmentItem Also convert more coffee to ES6! Test Plan: Unit tests Reviewers: bengotow, evan Reviewed By: evan Differential Revision: https://phab.nylas.com/D3381 |
||
|---|---|---|
| .. | ||
| attachment-items.less | ||
| button-dropdown.less | ||
| contenteditable.less | ||
| date-input.less | ||
| date-picker-popover.less | ||
| date-picker.less | ||
| disclosure-triangle.less | ||
| editable-list.less | ||
| editable-table.less | ||
| empty-list-state.less | ||
| extra.less | ||
| fixed-popover.less | ||
| generated-form.less | ||
| key-commands-region.less | ||
| list-tabular.less | ||
| menu.less | ||
| modal.less | ||
| multiselect-dropdown.less | ||
| nylas-calendar.less | ||
| outline-view.less | ||
| scroll-region.less | ||
| spinner.less | ||
| switch.less | ||
| table.less | ||
| time-picker.less | ||
| toast.less | ||
| tokenizing-text-field.less | ||
| tutorial-overlay.less | ||
| undo-toast.less | ||
| unsafe.less | ||