mirror of
https://github.com/Foundry376/Mailspring.git
synced 2025-01-01 13:14:16 +08:00
149b389508
* Switch to using Typescript instead of Babel * Switch all es6 / jsx file extensions to ts / tsx * Convert Utils to a TS module from module.exports style module * Move everything from module.exports to typescript exports * Define .d.ts files for mailspring-exports and component kit… Yes it seems this is the best option :( * Load up on those @types * Synthesize TS types from PropTypes for standard components * Add types to Model classes and move constructor constants to instance vars * 9800 => 7700 TS errors * 7700 => 5600 TS errors * 5600 => 5330 TS errors * 5330 => 4866 TS errors * 4866 => 4426 TS errors * 4426 => 2411 TS errors * 2411 > 1598 TS errors * 1598 > 769 TS errors * 769 > 129 TS errors * 129 > 22 TS errors * Fix runtime errors * More runtime error fixes * Remove support for custom .es6 file extension * Remove a few odd remaining references to Nylas * Don’t ship Typescript support in the compiled app for now * Fix issues in compiled app - module resolution in TS is case sensitive? * README updates * Fix a few more TS errors * Make “No Signature” option clickable + selectable * Remove flicker when saving file and reloading keymaps * Fix mail rule item height in preferences * Fix missing spacing in thread sharing popover * Fix scrollbar ticks being nested incorrectly * Add Japanese as a manually reviewed language * Prevent the thread list from “sticking” * Re-use Sheet when switching root tabs, prevent sidebar from resetting * Ensure specs run * Update package configuration to avoid shpping types * Turn eslint back on - we will opt-in to the TS rules one by one
209 lines
6.6 KiB
TypeScript
209 lines
6.6 KiB
TypeScript
import { Message, SendActionsStore, ExtensionRegistry } from 'mailspring-exports';
|
|
|
|
const SendAction1 = {
|
|
title: 'Send Action 1',
|
|
isAvailableForDraft: () => true,
|
|
performSendAction: () => {},
|
|
};
|
|
|
|
const SendAction2 = {
|
|
title: 'Send Action 2',
|
|
isAvailableForDraft: () => true,
|
|
performSendAction: () => {},
|
|
};
|
|
|
|
const SendAction3 = {
|
|
title: 'Send Action 3',
|
|
isAvailableForDraft: () => true,
|
|
performSendAction: () => {},
|
|
};
|
|
|
|
const NoTitleAction = {
|
|
isAvailableForDraft: () => true,
|
|
performSendAction: () => {},
|
|
};
|
|
|
|
const NoPerformAction = {
|
|
title: 'No Perform',
|
|
isAvailableForDraft: () => true,
|
|
};
|
|
|
|
const NotAvailableAction = {
|
|
title: 'Not Available',
|
|
isAvailableForDraft: () => false,
|
|
performSendAction: () => {},
|
|
};
|
|
|
|
const GoodExtension = {
|
|
name: 'GoodExtension',
|
|
sendActions() {
|
|
return [SendAction1];
|
|
},
|
|
};
|
|
|
|
const BadExtension = {
|
|
name: 'BadExtension',
|
|
sendActions() {
|
|
return [null];
|
|
},
|
|
};
|
|
|
|
const NoTitleExtension = {
|
|
name: 'NoTitleExtension',
|
|
sendActions() {
|
|
return [NoTitleAction];
|
|
},
|
|
};
|
|
|
|
const NoPerformExtension = {
|
|
name: 'NoPerformExtension',
|
|
sendActions() {
|
|
return [NoPerformAction];
|
|
},
|
|
};
|
|
|
|
const NotAvailableExtension = {
|
|
name: 'NotAvailableExtension',
|
|
sendActions() {
|
|
return [NotAvailableAction];
|
|
},
|
|
};
|
|
|
|
const NullExtension = {
|
|
name: 'NullExtension',
|
|
sendActions() {
|
|
return null;
|
|
},
|
|
};
|
|
|
|
const OtherExtension = {
|
|
name: 'OtherExtension',
|
|
sendActions() {
|
|
return [SendAction2, SendAction3];
|
|
},
|
|
};
|
|
|
|
const { DefaultSendActionKey } = SendActionsStore;
|
|
|
|
function sendActionKeys() {
|
|
return SendActionsStore.collectSendActions().map(({ configKey }) => configKey);
|
|
}
|
|
|
|
describe('SendActionsStore', function describeBlock() {
|
|
beforeEach(() => {
|
|
this.id = 'client-23';
|
|
this.draft = new Message({ id: this.id, draft: true });
|
|
spyOn(AppEnv, 'reportError');
|
|
});
|
|
|
|
describe('sendActions', () => {
|
|
it('returns default action when no extensions registered', () => {
|
|
spyOn(ExtensionRegistry.Composer, 'extensions').andReturn([]);
|
|
SendActionsStore._onComposerExtensionsChanged();
|
|
expect(sendActionKeys()).toEqual([DefaultSendActionKey]);
|
|
});
|
|
|
|
it('returns correct send actions', () => {
|
|
spyOn(ExtensionRegistry.Composer, 'extensions').andReturn([GoodExtension, OtherExtension]);
|
|
SendActionsStore._onComposerExtensionsChanged();
|
|
expect(sendActionKeys()).toEqual([
|
|
DefaultSendActionKey,
|
|
'send-action-1',
|
|
'send-action-2',
|
|
'send-action-3',
|
|
]);
|
|
});
|
|
|
|
it('handles extensions that return null for `sendActions`', () => {
|
|
spyOn(ExtensionRegistry.Composer, 'extensions').andReturn([GoodExtension, NullExtension]);
|
|
SendActionsStore._onComposerExtensionsChanged();
|
|
expect(sendActionKeys()).toEqual([DefaultSendActionKey, 'send-action-1']);
|
|
});
|
|
|
|
it('handles extensions that return null actions', () => {
|
|
spyOn(ExtensionRegistry.Composer, 'extensions').andReturn([GoodExtension, BadExtension]);
|
|
SendActionsStore._onComposerExtensionsChanged();
|
|
expect(sendActionKeys()).toEqual([DefaultSendActionKey, 'send-action-1']);
|
|
});
|
|
|
|
it('omits and reports when action is missing a title', () => {
|
|
spyOn(ExtensionRegistry.Composer, 'extensions').andReturn([GoodExtension, NoTitleExtension]);
|
|
SendActionsStore._onComposerExtensionsChanged();
|
|
expect(sendActionKeys()).toEqual([DefaultSendActionKey, 'send-action-1']);
|
|
expect(AppEnv.reportError).toHaveBeenCalled();
|
|
});
|
|
|
|
it('omits reports when action is missing performSendAction', () => {
|
|
spyOn(ExtensionRegistry.Composer, 'extensions').andReturn([
|
|
GoodExtension,
|
|
NoPerformExtension,
|
|
]);
|
|
SendActionsStore._onComposerExtensionsChanged();
|
|
expect(sendActionKeys()).toEqual([DefaultSendActionKey, 'send-action-1']);
|
|
expect(AppEnv.reportError).toHaveBeenCalled();
|
|
});
|
|
|
|
it('includes not available actions', () => {
|
|
spyOn(ExtensionRegistry.Composer, 'extensions').andReturn([
|
|
GoodExtension,
|
|
NotAvailableExtension,
|
|
]);
|
|
SendActionsStore._onComposerExtensionsChanged();
|
|
expect(sendActionKeys()).toEqual([DefaultSendActionKey, 'send-action-1', 'not-available']);
|
|
});
|
|
});
|
|
|
|
describe('orderedSendActionsForDraft', () => {
|
|
it('returns default action when no extensions registered', () => {
|
|
spyOn(ExtensionRegistry.Composer, 'extensions').andReturn([]);
|
|
SendActionsStore._onComposerExtensionsChanged();
|
|
const [preferred, ...rest] = SendActionsStore.orderedSendActionsForDraft();
|
|
expect(preferred.configKey).toBe(DefaultSendActionKey);
|
|
expect(rest).toEqual([]);
|
|
});
|
|
|
|
it('returns actions in correct grouping', () => {
|
|
spyOn(ExtensionRegistry.Composer, 'extensions').andReturn([
|
|
GoodExtension,
|
|
OtherExtension,
|
|
NotAvailableExtension,
|
|
]);
|
|
spyOn(AppEnv.config, 'get').andReturn('send-action-1');
|
|
SendActionsStore._onComposerExtensionsChanged();
|
|
const [preferred, ...rest] = SendActionsStore.orderedSendActionsForDraft();
|
|
const restKeys = rest.map(({ configKey }) => configKey);
|
|
expect(preferred.configKey).toBe('send-action-1');
|
|
expect(restKeys).toEqual([DefaultSendActionKey, 'send-action-2', 'send-action-3']);
|
|
});
|
|
|
|
it('falls back to a default if value in config not present', () => {
|
|
spyOn(ExtensionRegistry.Composer, 'extensions').andReturn([GoodExtension, OtherExtension]);
|
|
spyOn(AppEnv.config, 'get').andReturn(null);
|
|
SendActionsStore._onComposerExtensionsChanged();
|
|
const [preferred] = SendActionsStore.orderedSendActionsForDraft();
|
|
expect(preferred.configKey).toBe(DefaultSendActionKey);
|
|
});
|
|
|
|
it("falls back to a default if the primary item can't be found", () => {
|
|
spyOn(ExtensionRegistry.Composer, 'extensions').andReturn([GoodExtension, OtherExtension]);
|
|
spyOn(AppEnv.config, 'get').andReturn('does-not-exist');
|
|
SendActionsStore._onComposerExtensionsChanged();
|
|
const [preferred] = SendActionsStore.orderedSendActionsForDraft();
|
|
expect(preferred.configKey).toBe(DefaultSendActionKey);
|
|
});
|
|
|
|
it('falls back to a default if the primary item is not available for draft', () => {
|
|
spyOn(ExtensionRegistry.Composer, 'extensions').andReturn([
|
|
GoodExtension,
|
|
NotAvailableExtension,
|
|
]);
|
|
spyOn(AppEnv.config, 'get').andReturn('not-available');
|
|
SendActionsStore._onComposerExtensionsChanged();
|
|
const [preferred] = SendActionsStore.orderedSendActionsForDraft();
|
|
expect(preferred.configKey).toBe(DefaultSendActionKey);
|
|
});
|
|
});
|
|
|
|
// TODO Should go Task spec
|
|
it('catches any errors in an extension performSendAction method', () => {});
|
|
});
|