mirror of
https://github.com/Foundry376/Mailspring.git
synced 2024-09-23 08:46:07 +08:00
f1c0a1615d
Summary:
- Removes controlled focus in the composer!
- No React components ever perfom focus in lifecycle methods. Never again.
- A new `Utils.schedule({action, after, timeout})` helper makes it easy to say "setState or load draft, etc. and then focus"
- The DraftStore issues a focusDraft action after creating a draft, which causes the MessageList to focus and scroll to the desired composer, which itself decides which field to focus.
- The MessageList never focuses anything automatically.
- Refactors ComposerView apart — ComposerHeader handles all top fields, DraftSessionContainer handles draft session initialization and exposes props to ComposerView
- ComposerHeader now uses a KeyCommandRegion (with focusIn and focusOut) to do the expanding and collapsing of the participants fields. May rename that container very soon.
- Removes all CommandRegistry handling of tab and shift-tab. Unless you preventDefault, the browser does it's thing.
- Removes all tabIndexes greater than 1. This is an anti-pattern—assigning everything a tabIndex of 0 tells the browser to move between them based on their order in the DOM, and is almost always what you want.
- Adds "TabGroupRegion" which allows you to create a tab/shift-tabbing group, (so tabbing does not leave the active composer). Can't believe this isn't a browser feature.
Todos:
- Occasionally, clicking out of the composer contenteditable requires two clicks. This is because atomicEdit is restoring selection within the contenteditable and breaking blur.
- Because the ComposerView does not render until it has a draft, we're back to it being white in popout composers for a brief moment. We will fix this another way - all the "return unless draft" statements were untenable.
- Clicking a row in the thread list no longer shifts focus to the message list and focuses the last draft. This will be restored soon.
Test Plan: Broken
Reviewers: juan, evan
Reviewed By: juan, evan
Differential Revision: https://phab.nylas.com/D2814
84 lines
4.2 KiB
CoffeeScript
84 lines
4.2 KiB
CoffeeScript
React = require 'react'
|
|
ReactDOM = require 'react-dom'
|
|
ComposerHeaderActions = require '../lib/composer-header-actions'
|
|
Fields = require '../lib/fields'
|
|
ReactTestUtils = require('react-addons-test-utils')
|
|
{Actions} = require 'nylas-exports'
|
|
|
|
describe "ComposerHeaderActions", ->
|
|
makeField = (props = {}) ->
|
|
@onShowAndFocusField = jasmine.createSpy("onShowAndFocusField")
|
|
props.onShowAndFocusField = @onShowAndFocusField
|
|
props.enabledFields ?= []
|
|
props.draftClientId = 'a'
|
|
@component = ReactTestUtils.renderIntoDocument(
|
|
<ComposerHeaderActions {...props} />
|
|
)
|
|
|
|
it "renders the 'show' buttons for 'cc', 'bcc' when participantsFocused", ->
|
|
makeField.call(@, {enabledFields: [Fields.To], participantsFocused: true})
|
|
showCc = ReactTestUtils.findRenderedDOMComponentWithClass(@component, "show-cc")
|
|
showBcc = ReactTestUtils.findRenderedDOMComponentWithClass(@component, "show-bcc")
|
|
showSubject = ReactTestUtils.findRenderedDOMComponentWithClass(@component, "show-subject")
|
|
expect(showCc).toBeDefined()
|
|
expect(showBcc).toBeDefined()
|
|
|
|
it "does not render the 'show' buttons for 'cc', 'bcc' when participantsFocused is false", ->
|
|
makeField.call(@, {enabledFields: [Fields.To], participantsFocused: false})
|
|
showCc = ReactTestUtils.scryRenderedDOMComponentsWithClass(@component, "show-cc")
|
|
showBcc = ReactTestUtils.scryRenderedDOMComponentsWithClass(@component, "show-bcc")
|
|
showSubject = ReactTestUtils.scryRenderedDOMComponentsWithClass(@component, "show-subject")
|
|
expect(showCc.length).toBe 0
|
|
expect(showBcc.length).toBe 0
|
|
|
|
it "hides show cc if it's enabled", ->
|
|
makeField.call(@, {enabledFields: [Fields.To, Fields.Cc], participantsFocused: true})
|
|
els = ReactTestUtils.scryRenderedDOMComponentsWithClass(@component, "show-cc")
|
|
expect(els.length).toBe 0
|
|
|
|
it "hides show bcc if it's enabled", ->
|
|
makeField.call(@, {enabledFields: [Fields.To, Fields.Bcc], participantsFocused: true})
|
|
els = ReactTestUtils.scryRenderedDOMComponentsWithClass(@component, "show-bcc")
|
|
expect(els.length).toBe 0
|
|
|
|
it "hides show subject if it's enabled", ->
|
|
makeField.call(@, {enabledFields: [Fields.To, Fields.Subject], participantsFocused: true})
|
|
els = ReactTestUtils.scryRenderedDOMComponentsWithClass(@component, "show-subject")
|
|
expect(els.length).toBe 0
|
|
|
|
it "renders 'popout composer' in the inline mode", ->
|
|
makeField.call(@, {enabledFields: [Fields.To], participantsFocused: true})
|
|
els = ReactTestUtils.scryRenderedDOMComponentsWithClass(@component, "show-popout")
|
|
expect(els.length).toBe 1
|
|
|
|
it "doesn't render 'popout composer' if in a composer window", ->
|
|
spyOn(NylasEnv, 'isComposerWindow').andReturn(true)
|
|
makeField.call(@, {enabledFields: [Fields.To], participantsFocused: true})
|
|
els = ReactTestUtils.scryRenderedDOMComponentsWithClass(@component, "show-popout")
|
|
expect(els.length).toBe 0
|
|
|
|
it "pops out the composer when clicked", ->
|
|
spyOn(Actions, "composePopoutDraft")
|
|
makeField.call(@, {enabledFields: [Fields.To], participantsFocused: true})
|
|
el = ReactTestUtils.findRenderedDOMComponentWithClass(@component, "show-popout")
|
|
ReactTestUtils.Simulate.click(ReactDOM.findDOMNode(el))
|
|
expect(Actions.composePopoutDraft).toHaveBeenCalled()
|
|
|
|
it "shows and focuses cc when clicked", ->
|
|
makeField.call(@, {enabledFields: [Fields.To], participantsFocused: true})
|
|
el = ReactTestUtils.findRenderedDOMComponentWithClass(@component, "show-cc")
|
|
ReactTestUtils.Simulate.click(ReactDOM.findDOMNode(el))
|
|
expect(@onShowAndFocusField).toHaveBeenCalledWith Fields.Cc
|
|
|
|
it "shows and focuses bcc when clicked", ->
|
|
makeField.call(@, {enabledFields: [Fields.To], participantsFocused: true})
|
|
el = ReactTestUtils.findRenderedDOMComponentWithClass(@component, "show-bcc")
|
|
ReactTestUtils.Simulate.click(ReactDOM.findDOMNode(el))
|
|
expect(@onShowAndFocusField).toHaveBeenCalledWith Fields.Bcc
|
|
|
|
it "shows subject when clicked", ->
|
|
makeField.call(@, {enabledFields: [Fields.To], participantsFocused: false})
|
|
el = ReactTestUtils.findRenderedDOMComponentWithClass(@component, "show-subject")
|
|
ReactTestUtils.Simulate.click(ReactDOM.findDOMNode(el))
|
|
expect(@onShowAndFocusField).toHaveBeenCalledWith Fields.Subject
|