mirror of
https://github.com/Foundry376/Mailspring.git
synced 2024-11-14 21:57:55 +08:00
c1ecd045d7
Summary: We had previously ripped send tasks outside the sync loop to make them run faster, but they run fast enough inside the loop. This commit will also fix the scenario where if you closed the app in the middle of a send task, the task would just hang forever and never succeed or fail (T7818); given that it was excluded from the loop, we also had to exclude it from the cleanup step to mark any INPROGRESS tasks as failed at the beginning of each loop, which caused send tasks in progress to never get cleaned. Putting them back inside the loop allows us to fix this without adding more messy logic, and it cleans up ugly duplicated code. Additionally, it will prevent more duplicated code for upcoming diffs that will improve syncback task reliability when the app is closed or window is restarted in the middle of a task. Depends on D3893 Test Plan: manually test sending, it still works, it's still fast. Restarted window in the middle of send task, task fails. Reviewers: mark, spang, halla, evan Reviewed By: spang, halla, evan Differential Revision: https://phab.nylas.com/D3894 |
||
|---|---|---|
| .. | ||
| images | ||
| spec | ||
| src | ||
| stylesheets | ||
| main.es6 | ||
| package.json | ||