mirror of
https://github.com/Foundry376/Mailspring.git
synced 2025-02-24 16:14:01 +08:00
Summary: After importing an uneven csv (not all rows have the same number of columns e.g. rows: [[1,2][3,4,5]]), deleting the last column would improperly delete data in rows with fewer columns. This is because we were slicing each row based on row.length - 1 which is not the same for all rows. Fixed this by creating a new variable newNumColumns which is columns.length - 1. Test Plan: Added new test data with uneven data and added a test in table-data-source-spec for removeLastColumn on this uneven set. Reviewers: juan Reviewed By: juan Subscribers: juan Differential Revision: https://phab.nylas.com/D3133 |
||
---|---|---|
.. | ||
table-data-source-spec.jsx | ||
table-spec.jsx |