Mailspring/spec/components/table
Annie c251884eaa fix(mail-merge): Fix column deletion and added a spec for uneven data
Summary: After importing an uneven csv (not all rows have the same number of columns e.g. rows: [[1,2][3,4,5]]), deleting the last column would improperly delete data in rows with fewer columns. This is because we were slicing each row based on row.length - 1 which is not the same for all rows. Fixed this by creating a new variable newNumColumns which is columns.length - 1.

Test Plan: Added new test data with uneven data and added a test in table-data-source-spec for removeLastColumn on this uneven set.

Reviewers: juan

Reviewed By: juan

Subscribers: juan

Differential Revision: https://phab.nylas.com/D3133
2016-07-28 12:12:10 -07:00
..
table-data-source-spec.jsx fix(mail-merge): Fix column deletion and added a spec for uneven data 2016-07-28 12:12:10 -07:00
table-spec.jsx fix(build): Fix linter errors 2016-05-11 16:38:30 -07:00