Mailspring/spec/components/participants-text-field-spec.jsx
Evan Morikawa d1c587a01c fix(spec): add support for async specs and disable misbehaving ones
More spec fixes

replace process.nextTick with setTimeout(fn, 0) for specs

Also added an unspy in the afterEach

Temporarily disable specs

fix(spec): start fixing specs

Summary:
This is the WIP fix to our spec runner.

Several tests have been completely commented out that will require
substantially more work to fix. These have been added to our sprint
backlog.

Other tests have been fixed to update to new APIs or to deal with genuine
bugs that were introduced without our knowing!

The most common non-trivial change relates to observing the `NylasAPI` and
`NylasAPIRequest`. We used to observe the arguments to `makeRequest`.
Unfortunately `NylasAPIRequest.run` is argumentless. Instead you can do:
`NylasAPIRequest.prototype.run.mostRecentCall.object.options` to get the
`options` passed into the object. the `.object` property grabs the context
of the spy when it was last called.

Fixing these tests uncovered several concerning issues with our test
runner. I spent a while tracking down why our participant-text-field-spec
was failling every so often. I chose that spec because it was the first
spec to likely fail, thereby requiring looking at the least number of
preceding files. I tried binary searching, turning on and off, several
files beforehand only to realize that the failure rate was not determined
by a particular preceding test, but rather the existing and quantity of
preceding tests, AND the number of console.log statements I had. There is
some processor-dependent race condition going on that needs further
investigation.

I also discovered an issue with the file-download-spec. We were getting
errors about it accessing a file, which was very suspicious given the code
stubs out all fs access. This was caused due to a spec that called an
async function outside ot a `waitsForPromise` block or a `waitsFor` block.
The test completed, the spies were cleaned up, but the downstream async
chain was still running. By the time the async chain finished the runner
was already working on the next spec and the spies had been restored
(causing the real fs access to run).

Juan had an idea to kill the specs once one fails to prevent cascading
failures. I'll implement this in the next diff update

Test Plan: npm test

Reviewers: juan, halla, jackie

Differential Revision: https://phab.nylas.com/D3501

Disable other specs

Disable more broken specs

All specs turned off till passing state

Use async-safe versions of spec functions

Add async test spec

Remove unused package code

Remove canary spec
2016-12-15 13:02:00 -05:00

184 lines
6.3 KiB
JavaScript

import React from 'react';
import { mount } from 'enzyme';
import { ContactStore, Contact } from 'nylas-exports';
import { ParticipantsTextField } from 'nylas-component-kit';
const participant1 = new Contact({
id: 'local-1',
email: 'ben@nylas.com',
});
const participant2 = new Contact({
id: 'local-2',
email: 'ben@example.com',
name: 'Ben Gotow',
});
const participant3 = new Contact({
id: 'local-3',
email: 'evan@nylas.com',
name: 'Evan Morikawa',
});
xdescribe('ParticipantsTextField', function ParticipantsTextFieldSpecs() {
beforeEach(() => {
spyOn(NylasEnv, "isMainWindow").andReturn(true)
this.propChange = jasmine.createSpy('change')
this.fieldName = 'to';
this.participants = {
to: [participant1, participant2],
cc: [participant3],
bcc: [],
};
this.renderedField = mount(
<ParticipantsTextField
field={this.fieldName}
visible
participants={this.participants}
draft={{clientId: 'draft-1'}}
session={{}}
change={this.propChange}
/>
)
this.renderedInput = this.renderedField.find('input')
this.expectInputToYield = (input, expected) => {
const reviver = function reviver(k, v) {
if (k === "id" || k === "client_id" || k === "server_id" || k === "object") { return undefined; }
return v;
};
runs(() => {
this.renderedInput.simulate('change', {target: {value: input}});
advanceClock(100);
return this.renderedInput.simulate('keyDown', {key: 'Enter', keyCode: 9});
});
waitsFor(() => {
return this.propChange.calls.length > 0;
});
runs(() => {
let found = this.propChange.mostRecentCall.args[0];
found = JSON.parse(JSON.stringify(found), reviver);
expect(found).toEqual(JSON.parse(JSON.stringify(expected), reviver));
// This advance clock needs to be here because our waitsFor latch
// catches the first time that propChange gets called. More stuff
// may happen after this and we need to advance the clock to
// "clear" all of that. If we don't do this it throws errors about
// `setState` being called on unmounted components :(
return advanceClock(100);
});
};
});
it('renders into the document', () => {
expect(this.renderedField.find(ParticipantsTextField).length).toBe(1)
});
describe("inserting participant text", () => {
it("should fire onChange with an updated participants hash", () => {
this.expectInputToYield('abc@abc.com', {
to: [participant1, participant2, new Contact({name: 'abc@abc.com', email: 'abc@abc.com'})],
cc: [participant3],
bcc: [],
});
});
it("should remove added participants from other fields", () => {
this.expectInputToYield(participant3.email, {
to: [participant1, participant2, new Contact({name: participant3.email, email: participant3.email})],
cc: [],
bcc: [],
});
});
it("should use the name of an existing contact in the ContactStore if possible", () => {
spyOn(ContactStore, 'searchContacts').andCallFake((val) => {
if (val === participant3.name) {
return Promise.resolve([participant3]);
}
return Promise.resolve([]);
});
this.expectInputToYield(participant3.name, {
to: [participant1, participant2, participant3],
cc: [],
bcc: [],
});
});
it("should use the plain email if that's what's entered", () => {
spyOn(ContactStore, 'searchContacts').andCallFake((val) => {
if (val === participant3.name) {
return Promise.resolve([participant3]);
}
return Promise.resolve([]);
});
this.expectInputToYield(participant3.email, {
to: [participant1, participant2, new Contact({email: "evan@nylas.com"})],
cc: [],
bcc: [],
});
});
it("should not have the same contact auto-picked multiple times", () => {
spyOn(ContactStore, 'searchContacts').andCallFake((val) => {
if (val === participant2.name) {
return Promise.resolve([participant2]);
}
return Promise.resolve([])
});
this.expectInputToYield(participant2.name, {
to: [participant1, participant2, new Contact({email: participant2.name, name: participant2.name})],
cc: [participant3],
bcc: [],
});
});
describe("when text contains Name (Email) formatted data", () => {
it("should correctly parse it into named Contact objects", () => {
const newContact1 = new Contact({id: "b1", name: 'Ben Imposter', email: 'imposter@nylas.com'});
const newContact2 = new Contact({name: 'Nylas Team', email: 'feedback@nylas.com'});
const inputs = [
"Ben Imposter <imposter@nylas.com>, Nylas Team <feedback@nylas.com>",
"\n\nbla\nBen Imposter (imposter@nylas.com), Nylas Team (feedback@nylas.com)",
"Hello world! I like cheese. \rBen Imposter (imposter@nylas.com)\nNylas Team (feedback@nylas.com)",
"Ben Imposter<imposter@nylas.com>Nylas Team (feedback@nylas.com)",
];
for (const input of inputs) {
this.expectInputToYield(input, {
to: [participant1, participant2, newContact1, newContact2],
cc: [participant3],
bcc: [],
});
}
});
});
describe("when text contains emails mixed with garbage text", () => {
it("should still parse out emails into Contact objects", () => {
const newContact1 = new Contact({id: 'gm', name: 'garbage-man@nylas.com', email: 'garbage-man@nylas.com'});
const newContact2 = new Contact({id: 'rm', name: 'recycling-guy@nylas.com', email: 'recycling-guy@nylas.com'});
const inputs = [
"Hello world I real. \n asd. garbage-man@nylas.com—he's cool Also 'recycling-guy@nylas.com'!",
"garbage-man@nylas.com1WHOA I REALLY HATE DATA,recycling-guy@nylas.com",
"nils.com garbage-man@nylas.com @nylas.com nope@.com nope! recycling-guy@nylas.com HOLLA AT recycling-guy@nylas.",
];
for (const input of inputs) {
this.expectInputToYield(input, {
to: [participant1, participant2, newContact1, newContact2],
cc: [participant3],
bcc: [],
});
}
});
});
});
});