mirror of
https://github.com/Foundry376/Mailspring.git
synced 2024-09-22 08:16:09 +08:00
cfe2971c2e
Summary:
Previously, the generic IMAP auth screen presented one security option to
users: "Require SSL". This was ambiguous and difficult to translate into
the correct security options behind the scenes, causing confusion and problems
connecting some accounts.
This patch does the following:
* Separates security settings for IMAP and SMTP, as these different protocols
may also require different SSL/TLS settings
* Reworks the generic IMAP auth page to allow specifying security settings
with higher fidelity. We looked at various different email apps and decided
that the best solution to this problem was to allow more detailed
specification of security settings and to ease the burden of more options
by having sane defaults that work correctly in the majority of cases.
This new screen allows users to pick from "SSL / TLS", "STARTTLS", or "none"
for the security settings for a protocol, and also to instruct us that
they're OK with us using known insecure SSL settings to connect to their
server by checking a checkbox.
We default to port 993 / SSL/TLS for IMAP and port 587 / STARTTLS for SMTP.
These are the most common settings for providers these days and will work
for most folks.
* Significantly tightens our default security. Now that we can allow folks to
opt-in to bad security, by default we should protect folks as best we can.
* Removes some now-unnecessary jank like specifying the SSLv3 "cipher"
in some custom SMTP configs. I don't think this was actually necessary
as SSLv3 is a protocol and not a valid cipher, but these custom
configs may have been necessary because of how the ssl_required flag was
linked between IMAP and SMTP before (and thus to specify different
settings for SMTP you'd have to override the SMTP config).
* Removes hard-coding of Gmail & Office365 settings in several
locations. (This was a major headache while working on the patch.)
This depends on version 2.0.1 of imap-provider-settings, which has major
breaking changes from version 1.0. See commit for more info:
|
||
|---|---|---|
| .. | ||
| account-sidebar | ||
| attachments | ||
| category-picker | ||
| composer | ||
| composer-emoji | ||
| composer-markdown | ||
| composer-signature | ||
| composer-spellcheck | ||
| composer-templates | ||
| composer-translate | ||
| contact-rankings | ||
| draft-list | ||
| events | ||
| github-contact-card | ||
| keybase | ||
| main-calendar | ||
| message-autoload-images | ||
| message-list | ||
| message-view-on-github | ||
| mode-switch | ||
| notifications | ||
| onboarding | ||
| participant-profile | ||
| personal-level-indicators | ||
| phishing-detection | ||
| plugins | ||
| preferences | ||
| remove-tracking-pixels | ||
| screenshot-mode | ||
| search-index | ||
| send-and-archive | ||
| sync-health-checker | ||
| system-tray | ||
| theme-picker | ||
| thread-list | ||
| thread-search | ||
| thread-snooze | ||
| ui-dark | ||
| ui-darkside | ||
| ui-less-is-more | ||
| ui-light | ||
| ui-taiga | ||
| ui-ubuntu | ||
| undo-redo | ||
| unread-notifications | ||
| verify-install-location | ||
| worker-ui | ||