Foundry376/Mailspring
1
1
Fork 0
mirror of https://github.com/Foundry376/Mailspring.git synced 2024-09-24 09:16:07 +08:00
Code Issues Packages Projects Releases Wiki Activity
Mailspring/packages/isomorphic-core
History
Karim Hamidou 3e3b0b84f1 Switch type of Metadata value column 
Summary:
Found a funny send-later bug I didn't catch when testing on staging: sometimes the data we're saving in the metadata table overflows. That's because MySQL's TEXT column are at most 64k, which is easy to reach when you have a draft + clearbit information and additional stuff.

To work around this, I decided to switch the database type of the metadata table to LONGTEXT. Since it can store 4Gb of text, we should be good. This diff makes those code changes. Obviously, we'll have to run migrations both on staging and prod.

Test Plan: Ran a basic smoke test. Shouldn't break anything.

Reviewers: juan, evan

Reviewed By: evan

Differential Revision: https://phab.nylas.com/D4250
2017-03-22 12:03:11 -07:00
..
spec Revert "Revert "[feat] Add support for send later"" 2017-03-07 17:21:29 -08:00
src Switch type of Metadata value column 2017-03-22 12:03:11 -07:00
index.js [client-app] Fix missing depedency for imap-provider-settings 2017-03-14 10:42:30 -07:00
package.json Revert "[iso-core] Upgrade nodemailer" 2017-03-16 15:09:09 -07:00
README.md [*] update and add READMEs to each package 2017-02-17 17:28:09 -08:00

README.md

Isomorphic Core

Isomorphic refers to javascript that can be run on both the client and the server.

This is shared code for mail and utilities that is designed to run both on deployed cloud servers and from within the Nylas Mail client.

Use through a regular import: import iso-core from 'isomorphic-core'

It is required as a dependency in the package.json of other modules.

This library isn't on the npm registry, but works as a dependency thanks to lerna bootstrap

See index.js for what gets explicitly exported by this library.

Important Usage Notes:

Since this code runs in both the client and the server, you must be careful with what libraries you use. Some common gotchas:

  • You can't use NylasEnv or NylasExports. These are injected only in the client.
  • If you require a 3rd party library, it must be added to the "dependencies" of isomorphic-core's package.json
  • You may use modern javascript syntax. Both the client and server get compiled with the same .babelrc setting