mirror of
https://github.com/Foundry376/Mailspring.git
synced 2024-09-22 00:06:06 +08:00
e1882ab61a
Summary: This diff replaces the UnreadCountStore with a better approach that is able to track unread counts for all folders/labels without continuous (and cripplingly slow) SELECT COUNT(*) queries. When models are written to the database, we currently don't send out notifications with the "previous" state of those objects in the database. This makes it hard to determine how to update counters. (In the future, we may need to do this for live queries). Unfortunately, getting the "previous" state is going to be very hard, because multiple windows write to the database and the "previous" state we have might be outdated. We'd almost have to run a "SELECT" right before every "REPLACE INTO". I created an API that allows you to register observers around persistModel and unpersistModel. With this API, you can run queries before and after the database changes are made and pluck just the "before" state you're interested in. The `ThreadCountsStore` uses this API to determine the impact of persisting a set of threads on the unread counts of different labels. Before the threads are saved, it says "how much do these thread IDs contribute to unread counts currently?". After the write is complete it looks at the models and computes the difference between the old count impact and the new count impact, and updates the counters. I decided not to attach the unread count to the Label objects themselves because 1) they update frequently and 2) most things observing the DatabaseStore for categories do not care about counts, so they would be updating unnecessarily. The AccountSidebar now listens to the ThreadCountsStore as well as the CategoryStore, and there's a new preference in the General tab for turning off the counts. Test Plan: Tests are a work in progress, want to get feedback first! Reviewers: juan, evan Reviewed By: evan Differential Revision: https://phab.nylas.com/D2232
16 lines
724 B
CoffeeScript
16 lines
724 B
CoffeeScript
Label = require '../../src/flux/models/label'
|
|
UnreadBadgeStore = require '../../src/flux/stores/unread-badge-store'
|
|
|
|
describe "UnreadBadgeStore", ->
|
|
describe "_setBadgeForCount", ->
|
|
it "should set the badge correctly", ->
|
|
spyOn(UnreadBadgeStore, '_setBadge')
|
|
UnreadBadgeStore._setBadgeForCount(0)
|
|
expect(UnreadBadgeStore._setBadge).toHaveBeenCalledWith("")
|
|
UnreadBadgeStore._setBadgeForCount(1)
|
|
expect(UnreadBadgeStore._setBadge).toHaveBeenCalledWith("1")
|
|
UnreadBadgeStore._setBadgeForCount(100)
|
|
expect(UnreadBadgeStore._setBadge).toHaveBeenCalledWith("100")
|
|
UnreadBadgeStore._setBadgeForCount(1000)
|
|
expect(UnreadBadgeStore._setBadge).toHaveBeenCalledWith("999+")
|