mirror of
https://github.com/Foundry376/Mailspring.git
synced 2025-01-04 07:10:06 +08:00
796af843a0
Summary: After importing an uneven csv (not all rows have the same number of columns e.g. rows: [[1,2][3,4,5]]), deleting the last column would improperly delete data in rows with fewer columns. This is because we were slicing each row based on row.length - 1 which is not the same for all rows. Fixed this by creating a new variable newNumColumns which is columns.length - 1. Test Plan: Added new test data with uneven data and added a test in table-data-source-spec for removeLastColumn on this uneven set. Reviewers: juan Reviewed By: juan Subscribers: juan Differential Revision: https://phab.nylas.com/D3133 |
||
|---|---|---|
| .. | ||
| components | ||
| fixtures | ||
| models | ||
| services | ||
| stores | ||
| tasks | ||
| action-bridge-spec.coffee | ||
| auto-update-manager-spec.coffee | ||
| buffered-process-spec.coffee | ||
| component-registry-spec.coffee | ||
| database-object-registry-spec.coffee | ||
| date-utils-spec.es6 | ||
| dom-utils-spec.coffee | ||
| extension-registry-spec.coffee | ||
| jasmine-helper.coffee | ||
| jasmine.js | ||
| launch-services-spec.coffee | ||
| list-selection-spec.coffee | ||
| mail-rules-processor-spec.coffee | ||
| mailbox-perspective-spec.es6 | ||
| menu-manager-spec.coffee | ||
| module-cache-spec.coffee | ||
| n1-spec-reporter.cjsx | ||
| nylas-api-spec.coffee | ||
| nylas-env-spec.es6 | ||
| nylas-protocol-handler-spec.coffee | ||
| nylas-test-utils.coffee | ||
| package-manager-spec.coffee | ||
| package-spec.coffee | ||
| quoted-html-transformer-spec.coffee | ||
| quoted-plain-text-transformer-spec.coffee | ||
| spec-bootstrap.coffee | ||
| spec-helper-platform.coffee | ||
| spec-helper.coffee | ||
| spec-suite.coffee | ||
| spellchecker-spec.coffee | ||
| style-manager-spec.coffee | ||
| styles-element-spec.coffee | ||
| task-factory-spec.es6 | ||
| theme-manager-spec.coffee | ||
| time-override.coffee | ||
| time-reporter.coffee | ||
| undo-stack-spec.es6 | ||
| utils-spec.coffee | ||