mirror of
https://github.com/Foundry376/Mailspring.git
synced 2025-01-09 09:38:07 +08:00
e441553b50
Summary: This commit makes it so we always continue retrying syncback tasks as long as they error with a retryable error. There's really no reason to not continue retrying syncback tasks after an arbitrary number of retries (especially such a low one) if we encounter a retryable error. Before this commit, if for example we got 2 random network errors in a row, we would just mark the task as failed even though it would eventually succeed in subsequent attempts. Previously, when N1 synced against the cloud api, we would indefinitely retry a Task if we continued getting retryable errors. This ensures that the app can work correctly offline and prevents displaying unecessary errors to the user, and having actions bouncing back or sending messages without putting them in the sent folder. Additionally, this commit ensures that when cleaning up messages without a folderImapUID we don't delete messages that are currently being added to the sent folder. This is relevant to this commit because given that we could retry the EnsureMessageInSentFolder task indefinitely, we might end up deleting that message because it wont have a uid until the task succeeds. Depends on D3898 Test Plan: manual Reviewers: mark, spang, evan, halla Reviewed By: spang, evan, halla Differential Revision: https://phab.nylas.com/D3900 |
||
|---|---|---|
| .. | ||
| isomorphic-core | ||
| local-private | ||
| local-sync | ||