mirror of
https://github.com/Foundry376/Mailspring.git
synced 2024-09-23 00:36:50 +08:00
e90735ed6e
Summary: This diff is designed to dramatically speed up new window load time for all window types and reduce memory consumption of our hot windows. Before this diff, windows loaded in ~3 seconds. They now boot in a couple hundred milliseconds without requiring to keep hot windows around for each and every type of popout window we want to load quickly. One of the largest bottlenecks was the `require`ing and initializing of everything in `NylasExports`. I changed `NylasExports` to be entirely lazily-loaded. Drafts and tasks now register their constructors with a `StoreRegistry` and the `TaskRegistry`. This lets us explicitly choose a time to activate these stores in the window initalization instead of whenever nylas-exports happens to be required first. Before, NylasExports was required first when components were first rendering. This made initial render extremely slow and made the proposed time picker popout slow. By moving require into the very initial window boot, we can create a new scheme of hot windows that are "half loaded". All of the expensive require-ing and store initialization is done. All we need to do is activate the packages for just the one window. This means that the hot window scheme needs to fundamentally change from have fully pre-loaded windows, to having half-loaded empty hot windows that can get their window props overridden again. This led to a major refactor of the WindowManager to support this new window scheme. Along the way the API of WindowManager was significantly simplifed. Instead of a bunch of special-cased windows, there are now consistent interfaces to get and `ensure` windows are created and displayed. This DRYed up a lot of repeated logic around showing or creating core windows. This also allowed the consolidation of the core window configurations into one place for much easier reasoning about what's getting booted up. When a hot window goes "live" and gets populated, we simply change the `windowType`. This now re-triggers the loading of all of the packages for the window. All of the loading time is now just for the packages that window requires since core Nylas is there thanks to the hot window mechanism. Unfortunately loading all of the packages for the composer was still unnaceptably slow. The major issue was that all of the composer plugins were taking a long time to process and initialize. The solution was to have the main composer load first, then trigger another window load settings change to change the `windowType` that loads in all of the plugins. Another major bottleneck was the `RetinaImg` name lookup on disk. This requires traversing the entire static folder synchronously on boot. This is now done once when the main window loads and saved in a cache in the browser process. Any secondary windows simply ask the backend for this cache and save the filesystem access time. The Paper Doc below is the current set of manual tests I'm doing to make sure no window interactions (there are a lot of them!) regressed. Test Plan: https://paper.dropbox.com/doc/Window-Refactor-UYsgvjgdXgVlTw8nXTr9h Reviewers: juan, bengotow Reviewed By: bengotow Differential Revision: https://phab.nylas.com/D2916 |
||
|---|---|---|
| .. | ||
| account-sidebar | ||
| attachments | ||
| category-picker | ||
| composer | ||
| composer-emoji | ||
| composer-scheduler | ||
| composer-signature | ||
| composer-spellcheck | ||
| composer-templates | ||
| composer-translate | ||
| draft-list | ||
| events | ||
| github-contact-card | ||
| link-tracking | ||
| message-autoload-images | ||
| message-list | ||
| message-view-on-github | ||
| mode-switch | ||
| notification-mailto | ||
| notification-update-available | ||
| notifications | ||
| onboarding | ||
| open-tracking | ||
| participant-profile | ||
| personal-level-indicators | ||
| phishing-detection | ||
| plugins | ||
| preferences | ||
| screenshot-mode | ||
| send-and-archive | ||
| send-later | ||
| sidebar-fullcontact | ||
| system-tray | ||
| theme-picker | ||
| thread-list | ||
| thread-search | ||
| thread-search-index | ||
| thread-snooze | ||
| ui-dark | ||
| ui-darkside | ||
| ui-light | ||
| ui-taiga | ||
| ui-ubuntu | ||
| undo-redo | ||
| unread-notifications | ||
| worker-sync | ||
| worker-ui | ||