Mailspring/internal_packages
Ben Gotow eaeeb9619b fix(reply-behavior): Reply keyboard shortcuts update existing draft rather than creating new ones
Summary:
When bcc or cc is added, the ComposerView should show the fields. We should never hide a populated field!

Move the logic for determining message reply / replyTo participant sets into the message object. This seems OK because the functions don't modify the message and deal entirely with message attributes

Fix miscelaneous scrollbar issue

The MessageList does not always fire a composeReply action in response to keyboard shortcuts and can update the existing draft instead

There are a couple goals here:
- If you have an existing draft, command-R and command-shift-R should never create a new draft, they should just update and focus the existing draft.
- If you actually press the Reply button on the message item it should still create a new draft. It's still possible to have two.
- If you press Command-R and add a participant, and then press Command-Shift-R, it should add participants but not blow away the one you've added manually.
- If you press Command-Shift-R and then Command-R, it should remove the participants that were part of the "reply all", but leave other participants you've added untouched.

Test Plan: Run new tests!

Reviewers: evan

Reviewed By: evan

Maniphest Tasks: T2140

Differential Revision: https://phab.nylas.com/D1734
2015-07-13 16:30:02 -07:00
..
account-sidebar fix(*): can select participant with space if it's an email 2015-07-13 10:25:30 -04:00
attachments fix(attachment-css): Tiny style tweaks 2015-06-29 17:25:00 -07:00
calendar-bar refactor(utils): switch to regular underscore 2015-05-19 16:06:59 -07:00
composer fix(reply-behavior): Reply keyboard shortcuts update existing draft rather than creating new ones 2015-07-13 16:30:02 -07:00
developer-bar feat(offline-mode, undo-redo): Tasks handle network errors better and retry, undo/redo based on tasks 2015-07-07 13:38:53 -04:00
file-list feat(attachment): improved downloading and draggable images 2015-06-15 18:48:17 -07:00
inbox-contact-elements refactor(utils): switch to regular underscore 2015-05-19 16:06:59 -07:00
message-list fix(reply-behavior): Reply keyboard shortcuts update existing draft rather than creating new ones 2015-07-13 16:30:02 -07:00
message-templates feat(salesforce): new UI for Salesforce 2015-06-17 20:40:08 -07:00
mode-switch fix(assets): New toolbar icons, shadows to achieve less heavy edges on messages 2015-06-26 10:38:07 -07:00
notification-mailto refactor(utils): switch to regular underscore 2015-05-19 16:06:59 -07:00
notification-update-available fix(notifications): Give notifications tag like HTML5 Notifications so you can de-dupe 2015-05-25 10:27:36 -07:00
notifications fix(*): can select participant with space if it's an email 2015-07-13 10:25:30 -04:00
onboarding feat(api): add api-experimental.nylas.com as login option 2015-07-08 13:25:11 -07:00
search-bar fix(search): remove red search x 2015-06-18 09:43:18 -07:00
settings fix(getting-started): New menu item, sample package for devs 2015-07-06 14:23:51 -04:00
sidebar-fullcontact feat(salesforce): new UI for Salesforce 2015-06-17 20:40:08 -07:00
sidebar-inbox-internal Adding ATag component which prevents <a> tags from taking over edgehill when clicked. 2015-06-25 10:28:31 -07:00
thread-list Delete button now appears when drafts are selected 2015-07-09 13:28:02 -07:00
today fix(nylas-api): Globally handle 401s and notify user they need to sign in 2015-06-17 12:29:49 -07:00
tooltip feat(theming): Definitely not hacker mode. I don't know what you're talking about. 2015-06-05 11:40:44 -07:00
ui-dark feat(theming): Definitely not hacker mode. I don't know what you're talking about. 2015-06-05 11:40:44 -07:00
ui-light fix(build): Temporarily disable 'Task' tests Jenkins can't run, and avoid empty ui-variables files 2015-06-03 12:04:43 -07:00
unread-notifications fix(thread-list): Narrow mode, and new selection rules for three-pane 2015-06-11 18:00:40 -07:00