mirror of
https://github.com/Foundry376/Mailspring.git
synced 2024-09-22 16:26:08 +08:00
f1c0a1615d
Summary: - Removes controlled focus in the composer! - No React components ever perfom focus in lifecycle methods. Never again. - A new `Utils.schedule({action, after, timeout})` helper makes it easy to say "setState or load draft, etc. and then focus" - The DraftStore issues a focusDraft action after creating a draft, which causes the MessageList to focus and scroll to the desired composer, which itself decides which field to focus. - The MessageList never focuses anything automatically. - Refactors ComposerView apart — ComposerHeader handles all top fields, DraftSessionContainer handles draft session initialization and exposes props to ComposerView - ComposerHeader now uses a KeyCommandRegion (with focusIn and focusOut) to do the expanding and collapsing of the participants fields. May rename that container very soon. - Removes all CommandRegistry handling of tab and shift-tab. Unless you preventDefault, the browser does it's thing. - Removes all tabIndexes greater than 1. This is an anti-pattern—assigning everything a tabIndex of 0 tells the browser to move between them based on their order in the DOM, and is almost always what you want. - Adds "TabGroupRegion" which allows you to create a tab/shift-tabbing group, (so tabbing does not leave the active composer). Can't believe this isn't a browser feature. Todos: - Occasionally, clicking out of the composer contenteditable requires two clicks. This is because atomicEdit is restoring selection within the contenteditable and breaking blur. - Because the ComposerView does not render until it has a draft, we're back to it being white in popout composers for a brief moment. We will fix this another way - all the "return unless draft" statements were untenable. - Clicking a row in the thread list no longer shifts focus to the message list and focuses the last draft. This will be restored soon. Test Plan: Broken Reviewers: juan, evan Reviewed By: juan, evan Differential Revision: https://phab.nylas.com/D2814 |
||
---|---|---|
.. | ||
account-error-header | ||
account-sidebar | ||
attachments | ||
category-picker | ||
composer | ||
composer-emoji | ||
composer-signature | ||
composer-spellcheck | ||
composer-templates | ||
composer-translate | ||
draft-list | ||
events | ||
github-contact-card | ||
link-tracking | ||
message-autoload-images | ||
message-list | ||
message-view-on-github | ||
mode-switch | ||
N1-Scheduler | ||
notification-mailto | ||
notification-update-available | ||
notifications | ||
onboarding | ||
open-tracking | ||
participant-profile | ||
personal-level-indicators | ||
phishing-detection | ||
plugins | ||
preferences | ||
screenshot-mode | ||
search-bar | ||
send-and-archive | ||
send-later | ||
sidebar-fullcontact | ||
system-tray | ||
theme-picker | ||
thread-list | ||
thread-snooze | ||
ui-dark | ||
ui-darkside | ||
ui-light | ||
ui-taiga | ||
ui-ubuntu | ||
undo-redo | ||
unread-notifications | ||
worker-sync | ||
worker-ui |