From 19588b045f06e91431cba217ac7b3a0d56144129 Mon Sep 17 00:00:00 2001 From: Philippe Teuwen Date: Sun, 24 Mar 2019 22:09:25 +0100 Subject: [PATCH] Fix realloc mistake: ptr nulled but not freed upon failure --- client/cmdflashmem.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/client/cmdflashmem.c b/client/cmdflashmem.c index af8584ce7..2a9709ef0 100644 --- a/client/cmdflashmem.c +++ b/client/cmdflashmem.c @@ -260,9 +260,12 @@ int CmdFlashMemLoad(const char *Cmd) { break; } - data = realloc(data, datalen); - if (!data) { + uint8_t *newdata = realloc(data, datalen); + if (newdata == NULL) { + free(data); return 1; + } else { + data = newdata; } //Send to device