From cf92d8edc02e1022edbf029cf8ff85fcb894a064 Mon Sep 17 00:00:00 2001 From: spandox2 <31641448+spandox2@users.noreply.github.com> Date: Mon, 11 Sep 2023 11:43:04 -0400 Subject: [PATCH 1/6] Update cmdhfmf.c Changed line 2510 to change DEBUG to ERR Signed-off-by: spandox2 <31641448+spandox2@users.noreply.github.com> --- client/src/cmdhfmf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/src/cmdhfmf.c b/client/src/cmdhfmf.c index be336bcb3..46d24f602 100644 --- a/client/src/cmdhfmf.c +++ b/client/src/cmdhfmf.c @@ -2508,7 +2508,7 @@ static int CmdHF14AMfAutoPWN(const char *Cmd) { uint64_t select_status = resp.oldarg[0]; if (select_status == 0) { - PrintAndLogEx(DEBUG, "iso14443a card select failed"); + PrintAndLogEx(ERR, "iso14443a card select failed (Hint: check card possition)"); return PM3_ECARDEXCHANGE; } From 5584410bbcdf225664ab4773d657defd94978653 Mon Sep 17 00:00:00 2001 From: spandox2 <31641448+spandox2@users.noreply.github.com> Date: Mon, 11 Sep 2023 11:56:45 -0400 Subject: [PATCH 2/6] Update cmdhfmf.c Problem: "hf mf autopwn" gave no response if no card was detected, leaving user confused. Solution: Change a DEBUG message to an ERR and give a hint that the card may be poorly positioned. Signed-off-by: spandox2 <31641448+spandox2@users.noreply.github.com> --- client/src/cmdhfmf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/src/cmdhfmf.c b/client/src/cmdhfmf.c index 46d24f602..4ae141cad 100644 --- a/client/src/cmdhfmf.c +++ b/client/src/cmdhfmf.c @@ -2508,7 +2508,7 @@ static int CmdHF14AMfAutoPWN(const char *Cmd) { uint64_t select_status = resp.oldarg[0]; if (select_status == 0) { - PrintAndLogEx(ERR, "iso14443a card select failed (Hint: check card possition)"); + PrintAndLogEx(ERR, "iso14443a card select failed (Hint: check card position)"); return PM3_ECARDEXCHANGE; } From 67bfddde57f885eef2ab226c9ac062d4dfbcc5b1 Mon Sep 17 00:00:00 2001 From: spandox2 <31641448+spandox2@users.noreply.github.com> Date: Mon, 11 Sep 2023 13:18:56 -0400 Subject: [PATCH 3/6] Update cmdhfmf.c Changed ERR to HINT Signed-off-by: spandox2 <31641448+spandox2@users.noreply.github.com> --- client/src/cmdhfmf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/src/cmdhfmf.c b/client/src/cmdhfmf.c index 4ae141cad..d8683707e 100644 --- a/client/src/cmdhfmf.c +++ b/client/src/cmdhfmf.c @@ -2508,7 +2508,7 @@ static int CmdHF14AMfAutoPWN(const char *Cmd) { uint64_t select_status = resp.oldarg[0]; if (select_status == 0) { - PrintAndLogEx(ERR, "iso14443a card select failed (Hint: check card position)"); + PrintAndLogEx(HINT, "iso14443a card select failed (Hint: check card position)"); return PM3_ECARDEXCHANGE; } From b9efd8ce48dd4b20c2503796986460fd879ca29a Mon Sep 17 00:00:00 2001 From: spandox2 <31641448+spandox2@users.noreply.github.com> Date: Mon, 11 Sep 2023 13:24:54 -0400 Subject: [PATCH 4/6] Update cmdhfmf.c text change Signed-off-by: spandox2 <31641448+spandox2@users.noreply.github.com> --- client/src/cmdhfmf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/client/src/cmdhfmf.c b/client/src/cmdhfmf.c index d8683707e..d9153fc61 100644 --- a/client/src/cmdhfmf.c +++ b/client/src/cmdhfmf.c @@ -2508,7 +2508,8 @@ static int CmdHF14AMfAutoPWN(const char *Cmd) { uint64_t select_status = resp.oldarg[0]; if (select_status == 0) { - PrintAndLogEx(HINT, "iso14443a card select failed (Hint: check card position)"); + PrintAndLogEx(DEBUG, "iso14443a card select failed"); + PrintAndLogEx(HINT, "Card Select failed. Hint: Try some distance and/or change the position of the card"); return PM3_ECARDEXCHANGE; } From 7a832e175e4fda6b7df1383e85495d8465a1c013 Mon Sep 17 00:00:00 2001 From: spandox2 <31641448+spandox2@users.noreply.github.com> Date: Mon, 11 Sep 2023 13:43:41 -0400 Subject: [PATCH 5/6] Update cmdhfmf.c Signed-off-by: spandox2 <31641448+spandox2@users.noreply.github.com> --- client/src/cmdhfmf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/src/cmdhfmf.c b/client/src/cmdhfmf.c index d9153fc61..6dda245be 100644 --- a/client/src/cmdhfmf.c +++ b/client/src/cmdhfmf.c @@ -2509,7 +2509,7 @@ static int CmdHF14AMfAutoPWN(const char *Cmd) { uint64_t select_status = resp.oldarg[0]; if (select_status == 0) { PrintAndLogEx(DEBUG, "iso14443a card select failed"); - PrintAndLogEx(HINT, "Card Select failed. Hint: Try some distance and/or change the position of the card"); + PrintAndLogEx(FAILED, "No tag detected or other tag communication error"); return PM3_ECARDEXCHANGE; } From 5baba1fd432f94efabc99019704fdeb7740c4a16 Mon Sep 17 00:00:00 2001 From: spandox2 <31641448+spandox2@users.noreply.github.com> Date: Mon, 11 Sep 2023 13:48:09 -0400 Subject: [PATCH 6/6] Update cmdhfmf.c Signed-off-by: spandox2 <31641448+spandox2@users.noreply.github.com> --- client/src/cmdhfmf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/client/src/cmdhfmf.c b/client/src/cmdhfmf.c index 6dda245be..7f8be4fbf 100644 --- a/client/src/cmdhfmf.c +++ b/client/src/cmdhfmf.c @@ -2508,8 +2508,9 @@ static int CmdHF14AMfAutoPWN(const char *Cmd) { uint64_t select_status = resp.oldarg[0]; if (select_status == 0) { - PrintAndLogEx(DEBUG, "iso14443a card select failed"); + // iso14443a card select failed PrintAndLogEx(FAILED, "No tag detected or other tag communication error"); + PrintAndLogEx(HINT, "Hint: Try some distance or position of the card"); return PM3_ECARDEXCHANGE; }