RfidResearchGroup/proxmark3
1
1
Fork 0
mirror of https://github.com/RfidResearchGroup/proxmark3.git synced 2025-02-13 18:57:12 +08:00
Code Issues Projects Releases Packages Wiki Activity

FIX: Coverity, out-of-bounds read, 124 is less than (0x10*8)+2 (130)

Browse source 
FIX: Coverity, dead-code, bitcomparison always false.   Copy-paste error?  but  0x0F can never be equal 0x10..  I guessing its 0x01. @pwpivi have to correct me if its wrong.
This commit is contained in:
iceman1001 2016-01-13 14:53:32 +01:00
parent 54d893143c
commit 63c236144b
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
client/cmdhftopaz.c
View file

@ -257,7 +257,7 @@ int CmdHFTopazReader(const char *Cmd) {
uint8_t atqa[2]; uint8_t atqa[2];
uint8_t rid_response[8]; uint8_t rid_response[8];
uint8_t *uid_echo = &rid_response[2]; uint8_t *uid_echo = &rid_response[2];
uint8_t rall_response[124]; uint8_t rall_response[130];
status = topaz_select(atqa, rid_response); status = topaz_select(atqa, rid_response);
@ -286,7 +286,7 @@ int CmdHFTopazReader(const char *Cmd) {
PrintAndLog("HR0 : %02x (%sa Topaz tag (%scapable of carrying a NDEF message), %s memory map)", rid_response[0], PrintAndLog("HR0 : %02x (%sa Topaz tag (%scapable of carrying a NDEF message), %s memory map)", rid_response[0],
(rid_response[0] & 0xF0) == 0x10 ? "" : "not ", (rid_response[0] & 0xF0) == 0x10 ? "" : "not ",
(rid_response[0] & 0xF0) == 0x10 ? "" : "not ", (rid_response[0] & 0xF0) == 0x10 ? "" : "not ",
(rid_response[0] & 0x0F) == 0x10 ? "static" : "dynamic"); (rid_response[0] & 0x0F) == 0x01 ? "static" : "dynamic");
PrintAndLog("HR1 : %02x", rid_response[1]); PrintAndLog("HR1 : %02x", rid_response[1]);
status = topaz_rall(uid_echo, rall_response); status = topaz_rall(uid_echo, rall_response);