From 6d950e1e48fa18a518b853209b410e5c0264001a Mon Sep 17 00:00:00 2001
From: iceman1001 <iceman@iuse.se>
Date: Mon, 18 Jul 2022 22:17:53 +0200
Subject: [PATCH] fix coverity scan

---
 client/src/cmdhf.c | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/client/src/cmdhf.c b/client/src/cmdhf.c
index 2c073e262..2fe5cbd9e 100644
--- a/client/src/cmdhf.c
+++ b/client/src/cmdhf.c
@@ -351,19 +351,24 @@ int CmdHFSniff(const char *Cmd) {
 
     params.samplesToSkip = arg_get_u32_def(ctx, 1, 0);
     params.triggersToSkip = arg_get_u32_def(ctx, 2, 0);
+
     int smode = 0;
-    if (CLIGetOptionList(arg_get_str(ctx, 3), HFSnoopSkipModeOpts, &smode))
+    if (CLIGetOptionList(arg_get_str(ctx, 3), HFSnoopSkipModeOpts, &smode)) {
+        CLIParserFree(ctx);
         return PM3_EINVARG;
+    }
 
-    if (smode > 0)
-        params.skipMode = smode;
-
+    params.skipMode = smode;
     params.skipRatio = arg_get_int_def(ctx, 4, 0);
+
     CLIParserFree(ctx);
 
-    if (params.skipMode != HF_SNOOP_SKIP_NONE)
+    if (params.skipMode != HF_SNOOP_SKIP_NONE) {
         PrintAndLogEx(INFO, "Skip mode. Function: %s, each: %d sample", 
-            CLIGetOptionListStr(HFSnoopSkipModeOpts, params.skipMode), params.skipRatio * 2);
+            CLIGetOptionListStr(HFSnoopSkipModeOpts, params.skipMode),
+            params.skipRatio * 2
+        );
+    }
 
     clearCommandBuffer();
     SendCommandNG(CMD_HF_SNIFF, (uint8_t *)&params, sizeof(params));
@@ -383,6 +388,7 @@ int CmdHFSniff(const char *Cmd) {
                 PrintAndLogEx(INFO, "Button pressed, user aborted");
                 break;
             }
+
             if (resp.status == PM3_SUCCESS) {
 
                 struct r {