RfidResearchGroup/proxmark3
1
1
Fork 0
mirror of https://github.com/RfidResearchGroup/proxmark3.git synced 2024-09-21 07:46:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

FIX, Coverity, Argument can't be negative. CID# 212322, ftell(f) can be negative. Not allowed in malloc...

Browse source
This commit is contained in:
iceman1001 2016-01-12 22:43:28 +01:00
parent 7144c99b07
commit 9c4e28a445
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
client/cmdhficlass.c
View file

@ -269,10 +269,9 @@ int CmdHFiClassELoad(const char *Cmd) {
//File handling and reading //File handling and reading
FILE *f; FILE *f;
char filename[FILE_PATH_SIZE]; char filename[FILE_PATH_SIZE];
if(opt == 'f' && param_getstr(Cmd, 1, filename) > 0) if(opt == 'f' && param_getstr(Cmd, 1, filename) > 0) {
{
f = fopen(filename, "rb"); f = fopen(filename, "rb");
}else{ } else {
return hf_iclass_eload_usage(); return hf_iclass_eload_usage();
} }
@ -285,9 +284,14 @@ int CmdHFiClassELoad(const char *Cmd) {
long fsize = ftell(f); long fsize = ftell(f);
fseek(f, 0, SEEK_SET); fseek(f, 0, SEEK_SET);
uint8_t *dump = malloc(fsize); if (fsize < 0) {
prnlog("Error, when getting filesize");
return 1;
}
uint8_t *dump = malloc(fsize);
size_t bytes_read = fread(dump, 1, fsize, f); size_t bytes_read = fread(dump, 1, fsize, f);
fclose(f); fclose(f);