From d23ebec93c0e81819f649fab15b963157d63d946 Mon Sep 17 00:00:00 2001 From: Ave Date: Sat, 19 Dec 2020 07:25:28 +0300 Subject: [PATCH] emrtd: Make emrtd_mrz_determine_separator less hacky --- client/src/cmdhfemrtd.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/client/src/cmdhfemrtd.c b/client/src/cmdhfemrtd.c index 32d42f523..14abc8c90 100644 --- a/client/src/cmdhfemrtd.c +++ b/client/src/cmdhfemrtd.c @@ -1106,13 +1106,12 @@ static int emrtd_mrz_determine_length(char *mrz, int offset, int max_length) { static int emrtd_mrz_determine_separator(char *mrz, int offset, int max_length) { int i; - for (i = max_length; i > 0; i--) { - if (mrz[offset + i - 1] == '<' && mrz[offset + i] == '<') { + for (i = max_length - 1; i > 0; i--) { + if (mrz[offset + i] == '<' && mrz[offset + i + 1] == '<') { break; } } - // Return i - 1 unless we couldn't find anything (in that case return 0). - return i ? i - 1 : 0; + return i; } static void emrtd_mrz_replace_pad(char *data, int datalen, char newchar) {