From dc002d224a840e70ed3c3c67eeee4dbe249e4341 Mon Sep 17 00:00:00 2001 From: Uli Heilmeier Date: Mon, 13 Apr 2020 12:56:36 +0200 Subject: [PATCH] cmdhfmfdes: Fix clang tautological-pointer-compare warning Fixes: RfidResearchGroup/proxmark3#676 --- client/cmdhfmfdes.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/client/cmdhfmfdes.c b/client/cmdhfmfdes.c index 57a3666ed..4dd01f958 100644 --- a/client/cmdhfmfdes.c +++ b/client/cmdhfmfdes.c @@ -648,7 +648,7 @@ int get_desfire_auth(mfdes_authinput_t *payload, mfdes_auth_res_t *rpayload) { // Part 1 - if (payload->key == NULL) { + if (payload->key[0] == '\0') { if (payload->algo == MFDES_AUTH_DES) { memcpy(keybytes, PICC_MASTER_KEY8, 8); } else if (payload->algo == MFDES_ALGO_AES || payload->algo == MFDES_ALGO_3DES) { @@ -1299,8 +1299,8 @@ typedef struct mfdes_file { } PACKED mfdes_file_t; static int get_desfire_create_std_file(mfdes_file_t *file) { - if (file->access_rights == NULL) return PM3_EINVARG; - if (file->filesize == NULL) return PM3_EINVARG; + if (file->access_rights[0] == '\0') return PM3_EINVARG; + if (file->filesize[0] == '\0') return PM3_EINVARG; sAPDU apdu = {0x90, MFDES_CREATE_STD_DATA_FILE, 0x00, 0x00, 1 + 2 + 1 + 2 + 3, (uint8_t *)file}; // 0xCD