Iceman
0388682591
Merge pull request #2061 from pentoo/master
...
fix -Wstringop-overread error
2023-08-02 15:57:34 +02:00
Iceman
c5dff6a55f
Merge pull request #2059 from ZeroChaos-/master
...
fix lto-type-mismatch in guidummy.cpp
2023-08-02 15:54:38 +02:00
Rick Farina (Zero_Chaos)
6b648396e7
fix -Wstringop-overread error
...
We are reading this 26 bytes into a 32 byte buffer, is this even any
worse?
Fixes: https://github.com/RfidResearchGroup/proxmark3/issues/2060
2023-07-31 23:33:36 -04:00
Rick Farina (Zero_Chaos)
d522a46fca
fix lto-type-mismatch in guidummy.cpp
...
link time optimization requires all functions named the same to actually
operate the same. I am pretty sure this fixes it without breaking
anything.
Fixes: https://github.com/RfidResearchGroup/proxmark3/issues/2058
src/proxgui.h:35:6: error: type of ‘ShowPictureWindow’ does not match original declaration [-Werror=lto-type-mismatch]
35 | void ShowPictureWindow(uint8_t *data, int len);
| ^
src/guidummy.cpp:33:17: note: type mismatch in parameter 2
33 | extern "C" void ShowPictureWindow(char *fn) {
| ^
src/guidummy.cpp:33:17: note: type ‘void’ should match type ‘int’
src/guidummy.cpp:33:17: note: ‘ShowPictureWindow’ was previously declared here
2023-07-31 15:57:09 -04:00
kormax
ef79fb91eb
Add annotation for new DESFire command code
2023-07-31 12:48:40 +03:00
iceman1001
48b61c6438
ATR from the flipper zero seader project
2023-07-30 21:21:59 +02:00
iceman1001
9943235e31
updated atr table
2023-07-30 21:20:32 +02:00
iceman1001
708cfca850
add default marking of crc bytes for these protocols
2023-07-30 20:32:56 +02:00
iceman1001
0c98550177
dont mark crc byte everywhere in the alias list. have to set it for those commands that would benefit from it
2023-07-30 17:17:08 +02:00
iceman1001
6df79e3926
missed to remove exclamation mark
2023-07-29 12:44:32 +02:00
iceman1001
97a1f97308
style
2023-07-27 23:42:06 +02:00
iceman1001
944af6be95
fixed the missing erasing of flash memory bank.
2023-07-27 22:55:58 +02:00
iceman1001
19251645e1
shorten LEN variable to match the available space in string
2023-07-27 20:12:42 +02:00
iceman1001
a44e2fbc36
text
2023-07-27 19:47:11 +02:00
iceman1001
39eecc917e
improved the messages reported when loading json files fails. Usually because we have reserved the wrong size memory
2023-07-27 19:38:51 +02:00
iceman1001
8bfb915624
adapt the leftovers
2023-07-27 19:01:46 +02:00
iceman1001
40533497d3
text
2023-07-27 18:50:41 +02:00
iceman1001
3b91c1a47f
text
2023-07-27 18:50:19 +02:00
iceman1001
5faf625032
adapt name to match code style
2023-07-27 18:02:53 +02:00
iceman1001
7440e617e0
add stupid extra checks to see why this code overflows on pentoo...
2023-07-27 16:26:36 +02:00
iceman1001
795745ea32
text
2023-07-27 14:20:37 +02:00
iceman1001
dc199b62ca
text
2023-07-27 12:38:40 +02:00
iceman1001
7f5590d942
checks
2023-07-27 01:15:31 +02:00
iceman1001
a57cfdde70
size?
2023-07-27 01:12:08 +02:00
iceman1001
e1e4133564
coverity string formatter
2023-07-27 01:11:47 +02:00
iceman1001
123ef14667
style
2023-07-26 23:50:12 +02:00
iceman1001
fc3a518f28
There is a race condition when we go from iclass commands to mf command. Especially noticable when eload large files where we used to spam the device with usb packages.\ntry iclass eload, then mf eload, and you see the client hang. With this change we trigger a preload of the fpga image before we start uploading to the device. Current places I could trigger this bug was in eload and gsave. With this patch only the first call takes some time if fpga image must be loaded. The following goes fast.\n\n if you find that the client hangs when going between, this could be the root cause.
2023-07-26 23:47:55 +02:00
iceman1001
b696a2036f
improved the eload upload times by using large chunks. Quite much faster now.\nAddapted the dots and text for eload / sim across the client
2023-07-26 23:39:27 +02:00
iceman1001
fbdf50d756
minor text stuff
2023-07-26 17:49:14 +02:00
iceman1001
00133a04ee
added the hf mfu list
2023-07-26 17:41:48 +02:00
iceman1001
282af80153
Merge branch 'master' of github.com:RfidResearchGroup/proxmark3
2023-07-26 11:08:57 +02:00
iceman1001
9dc6ce552c
I remembered not to add calls to functions inside macro calls...
2023-07-26 11:08:45 +02:00
nvx
c3c08e07e4
Fix hf mf gdmsetlbk block data being accidentally prefixed with a 0x00.
...
This fixes a regression caused by edd8e36
(PR #2021 ).
gdm auth has no concept of A or B keys, a partial cleanup in the
previous PR removed the key type from the arm code, but the
corresponding removal was missed in the client side resulting in
mismatched structs for cmd CMD_HF_MIFARE_G4_GDM_WRBL.
2023-07-26 18:53:31 +10:00
iceman1001
30162f3d87
remove debug statement
2023-07-26 01:35:27 +02:00
iceman1001
c85258e042
zerobased index
2023-07-25 23:55:38 +02:00
iceman1001
e5b075ed3b
hf mf restore got some textual updates in order to be easier to understand if keyB writes fails. We use a default ACL when wiping a card that doesnt allow key B to be used for writing. Restore command tries key B first, so there will be several failed key b attempts normally.
2023-07-25 22:42:42 +02:00
iceman1001
cb9ee94ed6
lets see if this sorts out the memory crash on pentoo
2023-07-25 12:39:22 +02:00
iceman1001
1a4df13aae
fix coverity cid #416068
2023-07-24 22:18:35 +02:00
iceman1001
4179ce1e42
text
2023-07-24 21:34:01 +02:00
iceman1001
b446c36da6
style
2023-07-24 21:04:32 +02:00
iceman1001
41ff9191d6
text
2023-07-24 21:04:21 +02:00
iceman1001
1a788b1c14
make style
2023-07-24 17:42:27 +02:00
iceman1001
eaee05908c
text
2023-07-24 17:01:33 +02:00
iceman1001
97ca694c10
added a view command for ISO15693
2023-07-24 16:39:48 +02:00
iceman1001
90a3b968fd
coverity dont think we check if we got enough bytes to operate on. The sizeof the bmp_header_t gives a bit, we would need more ...
2023-07-24 15:24:53 +02:00
iceman1001
fb35a29ba0
coverity doesnt think we checked the bytes_read values enough. lets add a check
2023-07-24 15:18:56 +02:00
iceman1001
90d1fed1fa
coverity somehow believes we read a long string from a file and the data isnt null terminated (i.e. last char is 0x00) so let see if a ugly + 1 will do the trick
2023-07-24 15:14:17 +02:00
iceman1001
fcde2978a8
coverity believes somehow the return value from mfSectorNum can be 31. And wants us to check that it is only same size as sectors allocated
2023-07-24 15:11:21 +02:00
iceman1001
72057f9b81
text
2023-07-24 13:34:24 +02:00
iceman1001
fa82c46ff7
minor text
2023-07-24 03:15:42 +02:00