StackExchange/dnscontrol
1
1
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2025-09-06 21:24:18 +08:00
Code Issues Projects Releases Packages Wiki Activity

verifyCNAMEAssertions should warn, not panic (#2340)

Browse source 
Co-authored-by: Tom Limoncelli <tal@whatexit.org>
This commit is contained in:
Tom Limoncelli 2023-05-09 14:29:09 -04:00 • committed by GitHub
parent ace2242daf
commit 0d479b2780
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
pkg/diff2/compareconfig.go
View file

@ -156,13 +156,13 @@ func (cc *CompareConfig) verifyCNAMEAssertions() {
if len(td.existingTargets) != 0 {
if j != 0 {
panic("should not happen: (CNAME not in first position)")
fmt.Println("WARNING: should not happen: (CNAME not in FIRST position)")
}
}
if len(td.desiredTargets) != 0 {
if j != highest(ld.tdata) {
panic("should not happen: (CNAME not in last position)")
fmt.Println("WARNING: should not happen: (CNAME not in last position). There are multiple records on a label with a CNAME.")
}
}
}