From 0d9bdc2ddcad2c9c3231fe89f8d32f47cfd9805c Mon Sep 17 00:00:00 2001 From: Simen Bai <34043829+SimenBai@users.noreply.github.com> Date: Sat, 20 Aug 2022 07:51:25 +0300 Subject: [PATCH] DOMAINNAMESHOP: Domainnameshop documentation update (#1726) Co-authored-by: Simen Bai --- README.md | 2 +- docs/_includes/matrix.html | 16 +++++++-------- docs/_providers/domainnameshop.md | 10 +++++----- .../domainnameshop/domainnameshopProvider.go | 20 +++++++++---------- 4 files changed, 24 insertions(+), 24 deletions(-) diff --git a/README.md b/README.md index 2ba5fb862..0487b1e25 100644 --- a/README.md +++ b/README.md @@ -31,7 +31,7 @@ Currently supported DNS providers: - DNS Made Easy - DNSimple - DigitalOcean -- DomainNameShop (domeneshop) +- Domainnameshop (Domeneshop) - Exoscale - Gandi - Google DNS diff --git a/docs/_includes/matrix.html b/docs/_includes/matrix.html index 2b84635f7..23c99a608 100644 --- a/docs/_includes/matrix.html +++ b/docs/_includes/matrix.html @@ -458,7 +458,7 @@ - + @@ -740,8 +740,8 @@ - - + + @@ -840,8 +840,8 @@ - - + + @@ -1090,8 +1090,8 @@ - - + + @@ -1180,7 +1180,7 @@ - + diff --git a/docs/_providers/domainnameshop.md b/docs/_providers/domainnameshop.md index 7d5163582..58e6a395a 100644 --- a/docs/_providers/domainnameshop.md +++ b/docs/_providers/domainnameshop.md @@ -1,6 +1,6 @@ --- -name: DomainNameShop -title: DomainNameShop Provider +name: Domainnameshop +title: Domainnameshop Provider layout: default jsId: DOMAINNAMESHOP --- @@ -9,7 +9,7 @@ jsId: DOMAINNAMESHOP ## Configuration To use this provider, add an entry to `creds.json` with `TYPE` set to `DOMAINNAMESHOP` -along with your [DomainNameShop Token and Secret](https://www.domeneshop.no/admin?view=api). +along with your [Domainnameshop Token and Secret](https://www.domeneshop.no/admin?view=api). Example: @@ -24,7 +24,7 @@ Example: ``` ## Metadata -This provider does not recognize any special metadata fields unique to DomainNameShop. +This provider does not recognize any special metadata fields unique to Domainnameshop. ## Usage An example `dnsconfig.js` configuration: @@ -43,4 +43,4 @@ D("example.tld", REG_NONE, DnsProvider(DSP_DOMAINNAMESHOP), ## Limitations -- DomainNameShop DNS only supports TTLs which are a multiple of 60. \ No newline at end of file +- Domainnameshop DNS only supports TTLs which are a multiple of 60. \ No newline at end of file diff --git a/providers/domainnameshop/domainnameshopProvider.go b/providers/domainnameshop/domainnameshopProvider.go index 0224f4ea8..a08580162 100644 --- a/providers/domainnameshop/domainnameshopProvider.go +++ b/providers/domainnameshop/domainnameshopProvider.go @@ -9,7 +9,7 @@ import ( /** -DomainNameShop Provider +Domainnameshop Provider Info required in 'creds.json': - token API Token @@ -25,16 +25,16 @@ type domainNameShopProvider struct { var features = providers.DocumentationNotes{ providers.CanAutoDNSSEC: providers.Cannot(), // Maybe there is support for it providers.CanGetZones: providers.Unimplemented(), // - providers.CanUseAlias: providers.Unimplemented(), // Can possibly be implemented, needs further research + providers.CanUseAlias: providers.Unimplemented("Needs custom implementation"), // Can possibly be implemented, needs further research providers.CanUseCAA: providers.Can(), providers.CanUseDS: providers.Unimplemented(), // Seems to support but needs to be implemented providers.CanUseDSForChildren: providers.Unimplemented(), // Seems to support but needs to be implemented - providers.CanUseNAPTR: providers.Cannot(), // Does not seem to support it - providers.CanUsePTR: providers.Unimplemented(), // Seems to support but needs to be implemented + providers.CanUseNAPTR: providers.Cannot("According to Domainnameshop this will probably never be supported"), // Does not seem to support it + providers.CanUsePTR: providers.Cannot("According to Domainnameshop this will probably never be supported"), // Seems to support but needs to be implemented providers.CanUseSOA: providers.Cannot(), // Does not seem to support it providers.CanUseSRV: providers.Can(), - providers.CanUseSSHFP: providers.Cannot(), // Does not seem to support it - providers.CanUseTLSA: providers.Unimplemented(), // Seems to support but needs to be implemented + providers.CanUseSSHFP: providers.Cannot("Might be supported in the future"), // Does not seem to support it + providers.CanUseTLSA: providers.Unimplemented("Has support but no documentation. Needs to be investigated."), // Seems to support but needs to be implemented providers.DocCreateDomains: providers.Unimplemented(), // Not tested providers.DocDualHost: providers.Unimplemented(), // Not tested providers.DocOfficiallySupported: providers.Cannot(), @@ -51,12 +51,12 @@ func init() { providers.RegisterDomainServiceProviderType("DOMAINNAMESHOP", fns, features) } -// newDomainNameShopProvider creates a DomainNameShop specific DNS provider. +// newDomainNameShopProvider creates a Domainnameshop specific DNS provider. func newDomainNameShopProvider(conf map[string]string, metadata json.RawMessage) (providers.DNSServiceProvider, error) { if conf["token"] == "" { - return nil, fmt.Errorf("no DomainNameShop token provided") + return nil, fmt.Errorf("no Domainnameshop token provided") } else if conf["secret"] == "" { - return nil, fmt.Errorf("no DomainNameShop secret provided") + return nil, fmt.Errorf("no Domainnameshop secret provided") } api := &domainNameShopProvider{ @@ -76,7 +76,7 @@ type domainResponse struct { // The Actual fields are the values in the right format according to what is needed for RecordConfig. // -// While the values without Actual are the values directly as received from the DomainNameShop API. +// While the values without Actual are the values directly as received from the Domainnameshop API. // This is done to make it easier to use the values at later points. type domainNameShopRecord struct { ID int `json:"id"`