move providers/diff to pkg/diff like we should have 2 years ago (#692)

Co-authored-by: Tom Limoncelli <tlimoncelli@stackoverflow.com>

providers/activedir/domains.go

@@ -8,8 +8,8 @@ import (
 	"time"
 
 	"github.com/StackExchange/dnscontrol/v2/models"
+	"github.com/StackExchange/dnscontrol/v2/pkg/diff"
 	"github.com/StackExchange/dnscontrol/v2/pkg/printer"
-	"github.com/StackExchange/dnscontrol/v2/providers/diff"
 	"github.com/TomOnTime/utfutil"
 )
 

providers/azuredns/azureDnsProvider.go

@@ -12,8 +12,8 @@ import (
 	"github.com/Azure/go-autorest/autorest/to"
 
 	"github.com/StackExchange/dnscontrol/v2/models"
+	"github.com/StackExchange/dnscontrol/v2/pkg/diff"
 	"github.com/StackExchange/dnscontrol/v2/providers"
-	"github.com/StackExchange/dnscontrol/v2/providers/diff"
 )
 
 type azureDnsProvider struct {

providers/bind/bindProvider.go

@@ -26,9 +26,9 @@ import (
 	"github.com/miekg/dns"
 
 	"github.com/StackExchange/dnscontrol/v2/models"
+	"github.com/StackExchange/dnscontrol/v2/pkg/diff"
 	"github.com/StackExchange/dnscontrol/v2/pkg/prettyzone"
 	"github.com/StackExchange/dnscontrol/v2/providers"
-	"github.com/StackExchange/dnscontrol/v2/providers/diff"
 )
 
 var features = providers.DocumentationNotes{

providers/cloudflare/cloudflareProvider.go

@@ -11,10 +11,10 @@ import (
 	"github.com/miekg/dns/dnsutil"
 
 	"github.com/StackExchange/dnscontrol/v2/models"
+	"github.com/StackExchange/dnscontrol/v2/pkg/diff"
 	"github.com/StackExchange/dnscontrol/v2/pkg/printer"
 	"github.com/StackExchange/dnscontrol/v2/pkg/transform"
 	"github.com/StackExchange/dnscontrol/v2/providers"
-	"github.com/StackExchange/dnscontrol/v2/providers/diff"
 )
 
 /*

providers/cloudns/cloudnsProvider.go

@@ -8,8 +8,8 @@ import (
 	"github.com/miekg/dns/dnsutil"
 
 	"github.com/StackExchange/dnscontrol/v2/models"
+	"github.com/StackExchange/dnscontrol/v2/pkg/diff"
 	"github.com/StackExchange/dnscontrol/v2/providers"
-	"github.com/StackExchange/dnscontrol/v2/providers/diff"
 )
 
 /*

providers/digitalocean/digitaloceanProvider.go

@@ -7,8 +7,8 @@ import (
 	"net/http"
 
 	"github.com/StackExchange/dnscontrol/v2/models"
+	"github.com/StackExchange/dnscontrol/v2/pkg/diff"
 	"github.com/StackExchange/dnscontrol/v2/providers"
-	"github.com/StackExchange/dnscontrol/v2/providers/diff"
 	"github.com/miekg/dns/dnsutil"
 
 	"github.com/digitalocean/godo"

providers/dnsimple/dnsimpleProvider.go

@@ -12,8 +12,8 @@ import (
 	"golang.org/x/oauth2"
 
 	"github.com/StackExchange/dnscontrol/v2/models"
+	"github.com/StackExchange/dnscontrol/v2/pkg/diff"
 	"github.com/StackExchange/dnscontrol/v2/providers"
-	"github.com/StackExchange/dnscontrol/v2/providers/diff"
 )
 
 var features = providers.DocumentationNotes{

providers/exoscale/exoscaleProvider.go

@@ -9,8 +9,8 @@ import (
 	"github.com/exoscale/egoscale"
 
 	"github.com/StackExchange/dnscontrol/v2/models"
+	"github.com/StackExchange/dnscontrol/v2/pkg/diff"
 	"github.com/StackExchange/dnscontrol/v2/providers"
-	"github.com/StackExchange/dnscontrol/v2/providers/diff"
 )
 
 type exoscaleProvider struct {

providers/gandi/gandiProvider.go

@@ -10,9 +10,9 @@ import (
 	gandirecord "github.com/prasmussen/gandi-api/domain/zone/record"
 
 	"github.com/StackExchange/dnscontrol/v2/models"
+	"github.com/StackExchange/dnscontrol/v2/pkg/diff"
 	"github.com/StackExchange/dnscontrol/v2/pkg/printer"
 	"github.com/StackExchange/dnscontrol/v2/providers"
-	"github.com/StackExchange/dnscontrol/v2/providers/diff"
 )
 
 /*

providers/gandi/livedns.go

@@ -14,9 +14,9 @@ import (
 	gandilivezone "github.com/prasmussen/gandi-api/live_dns/zone"
 
 	"github.com/StackExchange/dnscontrol/v2/models"
+	"github.com/StackExchange/dnscontrol/v2/pkg/diff"
 	"github.com/StackExchange/dnscontrol/v2/pkg/printer"
 	"github.com/StackExchange/dnscontrol/v2/providers"
-	"github.com/StackExchange/dnscontrol/v2/providers/diff"
 )
 
 var liveFeatures = providers.DocumentationNotes{

providers/gandi_v5/gandi_v5Provider.go

@@ -25,9 +25,9 @@ import (
 	gandi "github.com/tiramiseb/go-gandi"
 
 	"github.com/StackExchange/dnscontrol/v2/models"
+	"github.com/StackExchange/dnscontrol/v2/pkg/diff"
 	"github.com/StackExchange/dnscontrol/v2/pkg/printer"
 	"github.com/StackExchange/dnscontrol/v2/providers"
-	"github.com/StackExchange/dnscontrol/v2/providers/diff"
 )
 
 // Section 1: Register this provider in the system.

providers/gcloud/gcloudProvider.go

@@ -10,8 +10,8 @@ import (
 	gdns "google.golang.org/api/dns/v1"
 
 	"github.com/StackExchange/dnscontrol/v2/models"
+	"github.com/StackExchange/dnscontrol/v2/pkg/diff"
 	"github.com/StackExchange/dnscontrol/v2/providers"
-	"github.com/StackExchange/dnscontrol/v2/providers/diff"
 )
 
 var features = providers.DocumentationNotes{

providers/hexonet/records.go

@@ -9,7 +9,7 @@ import (
 	"strings"
 
 	"github.com/StackExchange/dnscontrol/v2/models"
-	"github.com/StackExchange/dnscontrol/v2/providers/diff"
+	"github.com/StackExchange/dnscontrol/v2/pkg/diff"
 )
 
 // HXRecord covers an individual DNS resource record.

providers/linode/linodeProvider.go

@@ -13,8 +13,8 @@ import (
 	"golang.org/x/oauth2"
 
 	"github.com/StackExchange/dnscontrol/v2/models"
+	"github.com/StackExchange/dnscontrol/v2/pkg/diff"
 	"github.com/StackExchange/dnscontrol/v2/providers"
-	"github.com/StackExchange/dnscontrol/v2/providers/diff"
 )
 
 /*

providers/namecheap/namecheapProvider.go

@@ -11,9 +11,9 @@ import (
 	"golang.org/x/net/publicsuffix"
 
 	"github.com/StackExchange/dnscontrol/v2/models"
+	"github.com/StackExchange/dnscontrol/v2/pkg/diff"
 	"github.com/StackExchange/dnscontrol/v2/pkg/printer"
 	"github.com/StackExchange/dnscontrol/v2/providers"
-	"github.com/StackExchange/dnscontrol/v2/providers/diff"
 )
 
 // NamecheapDefaultNs lists the default nameservers for this provider.

providers/namedotcom/records.go

@@ -9,7 +9,7 @@ import (
 	"github.com/namedotcom/go/namecom"
 
 	"github.com/StackExchange/dnscontrol/v2/models"
-	"github.com/StackExchange/dnscontrol/v2/providers/diff"
+	"github.com/StackExchange/dnscontrol/v2/pkg/diff"
 )
 
 var defaultNameservers = []*models.Nameserver{

providers/ns1/ns1provider.go

@@ -10,8 +10,8 @@ import (
 	"gopkg.in/ns1/ns1-go.v2/rest/model/dns"
 
 	"github.com/StackExchange/dnscontrol/v2/models"
+	"github.com/StackExchange/dnscontrol/v2/pkg/diff"
 	"github.com/StackExchange/dnscontrol/v2/providers"
-	"github.com/StackExchange/dnscontrol/v2/providers/diff"
 )
 
 var docNotes = providers.DocumentationNotes{

providers/octodns/octodnsProvider.go

@@ -28,8 +28,8 @@ import (
 	"strings"
 
 	"github.com/StackExchange/dnscontrol/v2/models"
+	"github.com/StackExchange/dnscontrol/v2/pkg/diff"
 	"github.com/StackExchange/dnscontrol/v2/providers"
-	"github.com/StackExchange/dnscontrol/v2/providers/diff"
 	"github.com/StackExchange/dnscontrol/v2/providers/octodns/octoyaml"
 )
 

providers/ovh/ovhProvider.go

@@ -7,8 +7,8 @@ import (
 	"strings"
 
 	"github.com/StackExchange/dnscontrol/v2/models"
+	"github.com/StackExchange/dnscontrol/v2/pkg/diff"
 	"github.com/StackExchange/dnscontrol/v2/providers"
-	"github.com/StackExchange/dnscontrol/v2/providers/diff"
 	"github.com/ovh/go-ovh/ovh"
 )
 

providers/route53/route53Provider.go

@@ -15,8 +15,8 @@ import (
 	r53d "github.com/aws/aws-sdk-go/service/route53domains"
 
 	"github.com/StackExchange/dnscontrol/v2/models"
+	"github.com/StackExchange/dnscontrol/v2/pkg/diff"
 	"github.com/StackExchange/dnscontrol/v2/providers"
-	"github.com/StackExchange/dnscontrol/v2/providers/diff"
 )
 
 type route53Provider struct {

providers/softlayer/softlayerProvider.go

@@ -12,8 +12,8 @@ import (
 	"github.com/softlayer/softlayer-go/session"
 
 	"github.com/StackExchange/dnscontrol/v2/models"
+	"github.com/StackExchange/dnscontrol/v2/pkg/diff"
 	"github.com/StackExchange/dnscontrol/v2/providers"
-	"github.com/StackExchange/dnscontrol/v2/providers/diff"
 )
 
 // SoftLayer is the protocol handle for this provider.

providers/vultr/vultrProvider.go

@@ -12,8 +12,8 @@ import (
 	"github.com/vultr/govultr"
 
 	"github.com/StackExchange/dnscontrol/v2/models"
+	"github.com/StackExchange/dnscontrol/v2/pkg/diff"
 	"github.com/StackExchange/dnscontrol/v2/providers"
-	"github.com/StackExchange/dnscontrol/v2/providers/diff"
 )
 
 /*