StackExchange/dnscontrol
1
1
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2024-11-10 09:12:47 +08:00
Code Issues Projects Releases Packages Wiki Activity

PORKBUN: Improve non .DE domain delegation processing (remove the trailing dot in NS) (#2624)

Browse source 
Co-authored-by: Tom Limoncelli <tlimoncelli@stackoverflow.com>
This commit is contained in:
imlonghao 2023-11-16 23:56:31 +08:00 committed by GitHub
parent b8096b7b8a
commit 32fe2753d8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
providers/porkbun/api.go
View file

@ -7,6 +7,7 @@ import (
"io"
"net/http"
"sort"
"strings"
"time"
)
@ -156,7 +157,15 @@ func (c *porkbunProvider) getNameservers(domain string) ([]string, error) {
json.Unmarshal(bodyString, &ns)
sort.Strings(ns.Nameservers)
return ns.Nameservers, nil
var nameservers []string
for _, nameserver := range ns.Nameservers {
// Remove the trailing dot only if it exists.
// This provider seems to add the trailing dot to some domains but not others.
// The .DE domains seem to always include the dot, others don't.
nameservers = append(nameservers, strings.TrimSuffix(nameserver, "."))
}
return nameservers, nil
}
func (c *porkbunProvider) updateNameservers(ns []string, domain string) error {